From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id OMi5Mc3vU2EgBgEAgWs5BA (envelope-from ) for ; Wed, 29 Sep 2021 06:47:09 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0 with LMTPS id 8Nd9Lc3vU2G5BQAA1q6Kng (envelope-from ) for ; Wed, 29 Sep 2021 04:47:09 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 436F29C32 for ; Wed, 29 Sep 2021 06:47:09 +0200 (CEST) Received: from localhost ([::1]:52176 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mVRUq-0005Sz-BS for larch@yhetil.org; Wed, 29 Sep 2021 00:47:08 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:45350) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mVRUk-0005Sm-IQ for guix-patches@gnu.org; Wed, 29 Sep 2021 00:47:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:35964) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mVRUk-0002ej-BP for guix-patches@gnu.org; Wed, 29 Sep 2021 00:47:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mVRUk-000368-AE for guix-patches@gnu.org; Wed, 29 Sep 2021 00:47:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#49946] [PATCH 08/31] gnu: node: Patch /usr/bin/env in node-gyp. Resent-From: Philip McGrath Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Wed, 29 Sep 2021 04:47:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 49946 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Maxime Devos , Pierre Langlois Cc: 49946@debbugs.gnu.org Received: via spool by 49946-submit@debbugs.gnu.org id=B49946.163289076911846 (code B ref 49946); Wed, 29 Sep 2021 04:47:02 +0000 Received: (at 49946) by debbugs.gnu.org; 29 Sep 2021 04:46:09 +0000 Received: from localhost ([127.0.0.1]:47510 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mVRTs-00034z-QO for submit@debbugs.gnu.org; Wed, 29 Sep 2021 00:46:09 -0400 Received: from mail-qt1-f178.google.com ([209.85.160.178]:37392) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mVRTn-00034L-Ui for 49946@debbugs.gnu.org; Wed, 29 Sep 2021 00:46:07 -0400 Received: by mail-qt1-f178.google.com with SMTP id e16so1202388qts.4 for <49946@debbugs.gnu.org>; Tue, 28 Sep 2021 21:46:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=philipmcgrath.com; s=google; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=dz7TmOqo0Jydswh5JOONQTDW8s0VcE0iI7U/UTgkpcc=; b=HJjO7p7NuetueWLPDxH23jKSpl3cfLMsP+b/shIUC7uwjkC+d8KxVFkAkxwEj+9jU2 JurVHtTG/GKtWp5ZEYbqgDSvO+fVEAslRS5dE3gJYnCej+9U8I4UgeHy7gUoODG+b6k5 on9uLRGUMv+SlljAgNM7HvROlpembswf20vi2hMl1Ww3NR3gOgR6YgBHpSE9XeGOlkl1 HgTcBa96l9EvpoVZ72oUBHNioeokXXgv47Nt/xzjnY4mTRt5QFZmYKpCdu+L5k6IDM3x reIzJl4gS1toowzrsIUe/SEyg2txfwWol87WABh6wW8Re9zvCSYBXv5GCwEbCio7alqO OsDQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=dz7TmOqo0Jydswh5JOONQTDW8s0VcE0iI7U/UTgkpcc=; b=zwNnpHihwKJ/cHbj8rgHkRkgIQDAAf+qXTkIuAV+wodTl3mXlL4BqQhEaVG+0OqIqk 9tEZPyEkuLQ2eef7pXdeLLhUeO0ecD4H+tTShn+4ecPOqndbyEdoi2tXxKnnX2FbYFF2 Xa5ddBt/khlDHzRqPJoS/O9wjNYAHn39Yt2topmoKrp4QgsPBAsum3efqWC8YdKhkTi8 7SaingIZ/aw2M3lHgrsh06Ekj7t+QEaTo1KSlo0aynX1R6g3Evz2S8qSmAh2gl5OSyJh npX/91r5fbLH/9OrLYKu1qbWoVH0nw96KqPCDE68tSbyIjBLCjG6intOIDEv2lmzVYyk 3vCw== X-Gm-Message-State: AOAM530ueNKdrMbzTdsNNTVlA0ouiFJ2gtjfKOnF0FrshSIYRfbK6UfZ h9hW8InZm1PRooMGFl/R7t5Pf9iHSGHYrRMJ X-Google-Smtp-Source: ABdhPJy1lHIepGnupxyVzNAKhAAtWrWbOY51GZKL9mNNyOYpv0schjOSW5SWmotg0NjGo0ESsjljXw== X-Received: by 2002:a05:622a:4d1:: with SMTP id q17mr9610031qtx.64.1632890758049; Tue, 28 Sep 2021 21:45:58 -0700 (PDT) Received: from [192.168.45.37] (c-73-125-89-242.hsd1.fl.comcast.net. [73.125.89.242]) by smtp.gmail.com with ESMTPSA id z10sm956287qtv.6.2021.09.28.21.45.57 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 28 Sep 2021 21:45:57 -0700 (PDT) References: <87h7fztt60.fsf@gmx.com> <20210808233354.6745-1-pierre.langlois@gmx.com> <20210808233354.6745-8-pierre.langlois@gmx.com> <42e10baddb6afe308f67c3240bf5da8159e6f118.camel@telenet.be> <87o88gq5p5.fsf@gmx.com> <592a9a571437c4c053ceeb27ed0512deeb0667c6.camel@telenet.be> From: Philip McGrath Message-ID: Date: Wed, 29 Sep 2021 00:45:56 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 MIME-Version: 1.0 In-Reply-To: <592a9a571437c4c053ceeb27ed0512deeb0667c6.camel@telenet.be> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1632890829; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=dz7TmOqo0Jydswh5JOONQTDW8s0VcE0iI7U/UTgkpcc=; b=TbCGO5gIXxeESMcJ9t/OkhhlT30UxMDquYE0JqC8w44piEfTsHAqayBEQKXK+LJThF3YWF qeuEcEuoGL/YOB4DROnw01A1WvBTtOh56lOjH7dkiNAPGbRlQ22atvo63bQBM3gBWHMHC6 rolPqfrausMImNQm/DMTGtBmj0c7LP6I++WPz/g9zIGJL8Hu4xDkh7vHzRWlH1KbWuXknQ +NT2ovbeNZNjI/FqRBpDMZIrAxPSLIjJZz38pI2q43BwHmOLJvZAm1nGgb7IgaIh6IM82O Fzsm9xRzfFo9nnGbZw1XH3LHxHjWbTGl+rR1xAnhViYonHTI79CN/+E64ErPCw== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1632890829; a=rsa-sha256; cv=none; b=ouHroC5diK904EnCz0Cq34pp6YLmBClCwUeYfsn9KaDGU5eO5HfGOFlHfOSVnNgw2J1JHj fnUnEZ1iVR57sXEVIjBlXL/fzgQ4d7K53jCp/rW+uAQA6tv/v9cwMFngZvVirxOv3UXx4Q QmSZidfmawwgPXXBYXjFGtVYCJG/dVo1UbSPcQtMrMoSnFfFC7CDOIJVEo/h7orquN8Qs7 C5twbAMft4oVxxZnh3BQc7GwufH88lOd0eCEa1Sq2lpDUKmMbuolcUsIIO/+2ke1yFfZ4k pAoN43QohH3VV1XM1JpLTuzfXZwUhmqJGiDIn8ZIzMp06f5v0+M/7F41z3wtnA== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=philipmcgrath.com header.s=google header.b=HJjO7p7N; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Spam-Score: -1.80 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=philipmcgrath.com header.s=google header.b=HJjO7p7N; dmarc=none; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Queue-Id: 436F29C32 X-Spam-Score: -1.80 X-Migadu-Scanner: scn1.migadu.com X-TUID: wgnGDI9jWrQu On 9/27/21 6:11 AM, Maxime Devos wrote: > Philip McGrath schreef op zo 26-09-2021 om 18:02 [-0400]: >> Looking at `gnu-build-system`, it seems that the `'patch-shebangs` phase >> only operates on files installed in the "/bin" and "/sbin" >> subdirectories of the package's outputs. That restriction doesn't make >> sense to me in general: for instance, what about "/libexec"? > > 'libexec' is included on core-updates{,-frozen}. I believe the idea of the > restriction is to avoid patching too much. E.g., "autoconf" has a file > share/autoconf/build-aux/config.guess with a #!/bin/sh shebang. It should > not be patched, otherwise tarballs created with "make dist" would include > a store path and hence be Guix-specific and architecture-specific. That makes some sense. I would have thought checking that the file is executable would catch most such cases, but, if this works for `gnu-build-system`, great. As I look at potentially making a patch, another thing that seems odd is that `(gnu packages node)` exports node@10.24.0 as `node` (via `define-public`), but node@14.16.0 as `node-lts`. Normally, if I saw that there were packages `node` and `node-lts`, I'd assume that `node-lts` was *older*. It's especially confusing because, at the command line, `guix install node` refers to what in Scheme you have to write as `node-lts`. I wonder if it was a mistake, and should have used `define` rather than `define-public`, since this code: ``` ;; This should be the latest version of node that still builds without ;; depending on llhttp. (define-public node-bootstrap (hidden-package node)) ``` seems to be trying to hide the older node. It looks like `node` has only a few dependents, and it seems like at least several of them only used it because it had the more obvious name. The `node-build-system` uses `node-lts` as the `(default-node)`. Would it make sense to change the names? Or just to remove the `define-public` of `node`? -Philip