From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp11.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id GIK/FPq9ZmPt4AAAbAwnHQ (envelope-from ) for ; Sat, 05 Nov 2022 20:48:10 +0100 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp11.migadu.com with LMTPS id eDzIFPq9ZmPgggAA9RJhRA (envelope-from ) for ; Sat, 05 Nov 2022 20:48:10 +0100 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id E49AB8215 for ; Sat, 5 Nov 2022 20:48:09 +0100 (CET) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1orP9A-0007OI-Dy; Sat, 05 Nov 2022 15:48:04 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1orP98-0007O1-Tx for guix-patches@gnu.org; Sat, 05 Nov 2022 15:48:03 -0400 Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1orP98-0002ph-CM for guix-patches@gnu.org; Sat, 05 Nov 2022 15:48:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1orP98-0000DW-9F for guix-patches@gnu.org; Sat, 05 Nov 2022 15:48:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#59048] [PATCH] guix: modify-input: Recommend prepend instead of append. Resent-From: Vivien Kraus Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sat, 05 Nov 2022 19:48:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 59048 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Christopher Baines Cc: 59048@debbugs.gnu.org, paren@disroot.org X-Debbugs-Original-Cc: 59048@debbugs.gnu.org, guix-patches@gnu.org, "\(" Received: via spool by 59048-submit@debbugs.gnu.org id=B59048.1667677668722 (code B ref 59048); Sat, 05 Nov 2022 19:48:02 +0000 Received: (at 59048) by debbugs.gnu.org; 5 Nov 2022 19:47:48 +0000 Received: from localhost ([127.0.0.1]:58109 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1orP8u-0000BW-62 for submit@debbugs.gnu.org; Sat, 05 Nov 2022 15:47:48 -0400 Received: from planete-kraus.eu ([89.234.140.182]:49034) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1orP8q-0000Ah-1P for 59048@debbugs.gnu.org; Sat, 05 Nov 2022 15:47:47 -0400 Received: from planete-kraus.eu (localhost.lan [127.0.0.1]) by planete-kraus.eu (OpenSMTPD) with ESMTP id e5a0f9f1; Sat, 5 Nov 2022 19:47:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=planete-kraus.eu; h= message-id:subject:from:to:cc:date:in-reply-to:references :content-type:content-transfer-encoding:mime-version; s=dkim; bh=ve17mX0FOuRug11a0UsjvVFlhHI=; b=ZKKjGAZE5VZ6c2ikJSoSaighFVaC alQ5ezykanbhutXQWRF4rYjgQtnQekbGCrcGX2mBh46MZajnomeW4hFXpkEuZnF9 sgPifuiemLrFb3/D4Ju01PMvo3RbBC1es1g3cWmmR2CaG79i4EvtqhGw9+d3j+oj zvwI+tg8gCVPU6Q= Received: by planete-kraus.eu (OpenSMTPD) with ESMTPSA id e68ddf81 (TLSv1.3:AEAD-CHACHA20-POLY1305-SHA256:256:NO); Sat, 5 Nov 2022 19:47:38 +0000 (UTC) Message-ID: Date: Sat, 05 Nov 2022 20:47:35 +0100 In-Reply-To: <87eduhgqgj.fsf@cbaines.net> References: <7c0fbbe321c736a5757c637b33bf3a9909a6f63e.camel@planete-kraus.eu> <87eduhgqgj.fsf@cbaines.net> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.46.0 MIME-Version: 1.0 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "Guix-patches" Reply-to: Vivien Kraus X-ACL-Warn: , Vivien Kraus via Guix-patches From: Vivien Kraus via Guix-patches via Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1667677690; h=from:from:sender:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=HsmVqHeRUGNnbMSIIa4Q4s/m/NjTEYFDLPhKDm5TLbs=; b=u59H8dqCc1X4p2S+sKFneWekc6l8oTpL8k7PaP/9jOKjwcl/k6LSFoFXkyhUUNqt8Bu5ho wKhY/wBAVLbhOyxFiE23layNsUXdrtVx3ABGbHp+KRz2JyPnRFVAghZ0WG6/i/b1NqdorL kaiRIBnTSg+5LVvv/odzvvHYMhUJ8PhWRJWDBIZ5xhzV0vEHD6LEtCkkxwjlnR/JnNGQsL w1GotpAdt67QehRHsuLxXwaG1vf4zzVKw7Cl0QCWJaRJybvhDiQSYcarOohjpmAzXl630t uRB7o3KJ+QhV2MAGfwZVaKJjEaDD88v6O9K0W40OD1ZUSSs4vM8qz7G8Dg98Zw== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1667677690; a=rsa-sha256; cv=none; b=nez8ASIBLmO++qyS6Cm9PJE2ocsXcKIEhaO/UjR2sFsL+IlnzTrRZ85wegHjnS5IKxMTLK vKePAR2n+2IA61JcFOUZFwhRnGkl86kXGpWQ4qfvOnHmQg4Bk1QStSe793B0W9qRHr1lhy TUkQi5SP9tTkMW/KevL8orkQrIp1GP2An2El5dK63MMl42JKQd7oBnpQ6nD1Mq9WnYfFho aYGcgbKb1pN0KCiRfcx9dJfHS5lNCUnpPptgzr/1jaCQZoBnjLSUmtQGpOVrpfoUrAklRa VAOt0U6XIGmNmXbgSmherX+4NDKrPYcUoL+LXXiSXf0ILZDww9kfxIgpJO6guA== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=planete-kraus.eu header.s=dkim header.b=ZKKjGAZE; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: -2.81 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=planete-kraus.eu header.s=dkim header.b=ZKKjGAZE; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: E49AB8215 X-Spam-Score: -2.81 X-Migadu-Scanner: scn0.migadu.com X-TUID: 5PgMo9mgCVT5 Hello! Le samedi 05 novembre 2022 =C3=A0 20:17 +0100, Christopher Baines a =C3=A9c= rit=C2=A0: >=20 > Vivien Kraus via Guix-patches via writes: >=20 > > * doc/guix.texi (Defining Package Variants): Document the "prepend" > > clause of > > modify-inputs first. > > * guix/packages.scm (modify-inputs): use "prepend" in the > > docstring. > > --- > > =C2=A0doc/guix.texi=C2=A0=C2=A0=C2=A0=C2=A0 | 12 ++++++------ > > =C2=A0guix/packages.scm |=C2=A0 4 ++-- > > =C2=A02 files changed, 8 insertions(+), 8 deletions(-) >=20 > This seems OK, but it would be good to know why you're wanting to > change > this? In other words, how does this make things better? I=E2=80=99m not sure of anything. What I gathered so far is: - it could be more efficient; - most instances in the packages use prepend rather than append: $ grep -R '(modify-inputs' gnu -A 3 | grep '(append' | wc -l 34 $ grep -R '(modify-inputs' gnu -A 3 | grep '(prepend' | wc -l 128 I=E2=80=99m inviting ( in the discussion because the issue was raised in an= IRC discussion about a previous patch of mine (test). Now, the old way I would reply to this message would be to attach an updated patch, but since I have been told to send patches as emails instead of attachments I don=E2=80=99t know how to proceed. Vivien