From: Maxime Devos <maximedevos@telenet.be>
To: Brian Cully <bjc@spork.org>, 55369@debbugs.gnu.org
Cc: Brian Cully <bjc@kublai.com>
Subject: [bug#55369] [PATCH v2 1/2] gnu: zfs: Use new package style.
Date: Wed, 11 May 2022 21:33:23 +0200 [thread overview]
Message-ID: <ab646edfe766d2578687ee19eb084e8ab0ffabe5.camel@telenet.be> (raw)
In-Reply-To: <d0a42dc8c2ba95b0b97c7cb6a6a7ccaaf06ef056.1652283785.git.bjc@spork.org>
[-- Attachment #1: Type: text/plain, Size: 805 bytes --]
Brian Cully via Guix-patches via schreef op wo 11-05-2022 om 11:43 [-
0400]:
> [inputs]: Remove labels.
Nice.
> ---
> This patch replaces ungexp'd package references with
> (search-input-file …) and puts ‘util-linux’ back in the inputs.
The uses of 'search-input-file' look good to me at first sight.
One additional nitpick:
> + (string-append "--with-linux="
> + (assoc-ref inputs "linux-
module-builder")
> + "/lib/modules/build"))))
You can remove an input label here as well, try 'search-input-
directory' (untested):
(string-append "--with-linux="
;; provided by 'linux-module-build-system'
(search-input-directory inputs "lib/modules/build"))
Greetings,
Maxime.
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 260 bytes --]
next prev parent reply other threads:[~2022-05-11 19:34 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-11 13:37 [bug#55369] [PATCH 1/2] gnu: zfs: Use new package style Brian Cully via Guix-patches via
2022-05-11 13:40 ` [bug#55369] [PATCH] gnu: Change OpenZFS home page to reflect new project ownership Brian Cully via Guix-patches via
2022-05-11 14:53 ` [bug#55369] [PATCH 1/2] gnu: zfs: Use new package style Maxime Devos
2022-05-11 14:57 ` Maxime Devos
2022-05-11 15:43 ` [bug#55369] [PATCH v2 " Brian Cully via Guix-patches via
2022-05-11 19:33 ` Maxime Devos [this message]
2022-05-11 15:48 ` [bug#55369] [PATCH v2] gnu: Change OpenZFS home page to reflect new project ownership Brian Cully via Guix-patches via
2022-05-11 19:36 ` Maxime Devos
2022-05-12 3:05 ` Brian Cully via Guix-patches via
2022-05-12 14:36 ` Brian Cully via Guix-patches via
2022-05-12 14:43 ` Maxime Devos
2022-05-12 15:07 ` Brian Cully via Guix-patches via
2022-05-12 15:05 ` [bug#55369] [PATCH v3 1/2] gnu: zfs: Use new package style Brian Cully via Guix-patches via
2022-05-20 18:15 ` bug#55369: [PATCH " Ludovic Courtès
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ab646edfe766d2578687ee19eb084e8ab0ffabe5.camel@telenet.be \
--to=maximedevos@telenet.be \
--cc=55369@debbugs.gnu.org \
--cc=bjc@kublai.com \
--cc=bjc@spork.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).