From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id qOFnDsntrl6QcQAA0tVLHw (envelope-from ) for ; Sun, 03 May 2020 16:14:01 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2 with LMTPS id KP8sONLtrl7hSAAAB5/wlQ (envelope-from ) for ; Sun, 03 May 2020 16:14:10 +0000 Received: from lists.gnu.org (lists.gnu.org [IPv6:2001:470:142::17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id A62D39445E3 for ; Sun, 3 May 2020 16:14:09 +0000 (UTC) Received: from localhost ([::1]:40410 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jVHFp-00014b-VL for larch@yhetil.org; Sun, 03 May 2020 12:14:09 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:37584) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jVHFi-00011k-9i for guix-patches@gnu.org; Sun, 03 May 2020 12:14:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:46184) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1jVHFh-0000t8-W1 for guix-patches@gnu.org; Sun, 03 May 2020 12:14:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1jVHFh-0000jR-Ow for guix-patches@gnu.org; Sun, 03 May 2020 12:14:01 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#41033] [PATCH] gnu: libusb-0.1: fix build failure on newer gcc Resent-From: Christopher Howard Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sun, 03 May 2020 16:14:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 41033 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Jakub =?UTF-8?Q?K=C4=85dzio=C5=82ka?= Cc: 41033@debbugs.gnu.org X-Debbugs-Original-Cc: guix-patches@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.15885224272771 (code B ref -1); Sun, 03 May 2020 16:14:01 +0000 Received: (at submit) by debbugs.gnu.org; 3 May 2020 16:13:47 +0000 Received: from localhost ([127.0.0.1]:57727 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jVHFS-0000iY-Rn for submit@debbugs.gnu.org; Sun, 03 May 2020 12:13:47 -0400 Received: from lists.gnu.org ([209.51.188.17]:44488) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jVHFP-0000iP-JJ for submit@debbugs.gnu.org; Sun, 03 May 2020 12:13:45 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:37444) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jVHFP-0000FO-9V for guix-patches@gnu.org; Sun, 03 May 2020 12:13:43 -0400 Received: from mx.kolabnow.com ([95.128.36.42]:39140) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jVHFO-0000g9-16 for guix-patches@gnu.org; Sun, 03 May 2020 12:13:42 -0400 Received: from localhost (unknown [127.0.0.1]) by ext-mx-out001.mykolab.com (Postfix) with ESMTP id DF1AF65B; Sun, 3 May 2020 18:13:39 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kolabnow.com; h= content-transfer-encoding:mime-version:content-type:content-type :references:in-reply-to:date:date:from:from:subject:subject :message-id:received:received:received; s=dkim20160331; t= 1588522417; x=1590336818; bh=t1BXUAhZxYoX3rfBlPX8TQBfL6ddnxnbPFr 52fG/WJE=; b=j2hBnHHJ3Bnr7bVqg0vrxFEjatGSSVt4q0Nz6eDwhcliP9hs7Lx Tu+hZT8Kgd6cuU/h0dmLHpbPE7Di1HzNd/gFvhfMkJhqCAzYuG+dbXbjTh4j5AVt 5KIEgCQ63LT1hB3wlnQDwmFvxWBHqQw30GNhy4E1zBmPlRF7bQQFnQyC9mhXIePq 9khKKqhD11KBgCPbfP+YvWHk8NBKXP4zRJBadlVfeGzDqpsAqGeKytpji4c+5jwA ktc3oQB/SPQwcF5D8mG6R4NASwiI2H/mlamHuiyVHS3dlX6jW0/tK3dfhsB93dB1 MTubSrxRwI1MFbv+SN4Ps8tnE2uT1SE6QlVAyIX1CofcCf8vwNep8bVi+pv37c7w H1QS1pTlFFQryIn8yMBw9UCZt4gIflCZQyYvq6Fo3tZhN0oIXtJqtxpKYqh1CZ17 mHnTTpvL/gAl11b5bSV5POThQUyFzfiy8aRaf9YzoBrc+bAJqIl94ktg7d0D7u5P /sujN+/BfKatwEEaF4BZwELL+7UvOMOlNEXGZeTQ3FSGeH3h+31fwlRI+i8BtRU3 LsFU0uHF+b1aUUI5W69+20D9KbBIc8QBiKdWNN0b2qcbebDB0b3EqFkgRc+QIzLH duoj7o7Fj+9m9Smd4Urm+dPgzzH0XV2C58cRFln3g1ayJzdlvCayMscE= X-Virus-Scanned: amavisd-new at mykolab.com X-Spam-Score: -1.9 Received: from mx.kolabnow.com ([127.0.0.1]) by localhost (ext-mx-out001.mykolab.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id lx9yV2Urf4wY; Sun, 3 May 2020 18:13:37 +0200 (CEST) Received: from int-mx002.mykolab.com (unknown [10.9.13.2]) by ext-mx-out001.mykolab.com (Postfix) with ESMTPS id A1BA435F; Sun, 3 May 2020 18:13:36 +0200 (CEST) Received: from ext-subm001.mykolab.com (unknown [10.9.6.1]) by int-mx002.mykolab.com (Postfix) with ESMTPS id 51CEF12EBC; Sun, 3 May 2020 18:13:36 +0200 (CEST) Message-ID: From: Christopher Howard Date: Sun, 03 May 2020 08:13:32 -0800 In-Reply-To: <20200503105846.fvouqze7r5qhb5nf@gravity> References: <1a3c1bf5091742ae78a5946c92a622206dcdf596.camel@librehacker.com> <20200503105846.fvouqze7r5qhb5nf@gravity> Content-Type: text/plain; charset="UTF-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Received-SPF: none client-ip=95.128.36.42; envelope-from=christopher@librehacker.com; helo=mx.kolabnow.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/05/03 12:13:40 X-ACL-Warn: Detected OS = Linux 3.11 and newer [fuzzy] X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, URIBL_BLOCKED=0.001 autolearn=_AUTOLEARN X-Spam_action: no action X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-Spam-Score: -3.3 (---) X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Scanner: scn0 X-Spam-Score: -0.01 Authentication-Results: aspmx1.migadu.com; dkim=fail (rsa verify failed) header.d=kolabnow.com header.s=dkim20160331 header.b=j2hBnHHJ; dmarc=none; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 2001:470:142::17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Scan-Result: default: False [-0.01 / 13.00]; GENERIC_REPUTATION(0.00)[-0.49381381928053]; TO_DN_SOME(0.00)[]; R_SPF_ALLOW(-0.20)[+ip6:2001:470:142::/48:c]; IP_REPUTATION_HAM(0.00)[asn: 22989(0.14), country: US(-0.00), ip: 2001:470:142::17(-0.49)]; DWL_DNSWL_FAIL(0.00)[2001:470:142::17:server fail]; RCVD_COUNT_TWELVE(0.00)[13]; R_DKIM_REJECT(1.00)[kolabnow.com:s=dkim20160331]; MX_GOOD(-0.50)[cached: eggs.gnu.org]; RCPT_COUNT_TWO(0.00)[2]; DKIM_TRACE(0.00)[kolabnow.com:-]; MAILLIST(-0.20)[mailman]; FORGED_RECIPIENTS_MAILLIST(0.00)[]; RCVD_IN_DNSWL_FAIL(0.00)[2001:470:142::17:server fail]; MIME_TRACE(0.00)[0:+]; RCVD_TLS_LAST(0.00)[]; ASN(0.00)[asn:22989, ipnet:2001:470:142::/48, country:US]; MID_RHS_MATCH_FROM(0.00)[]; TAGGED_FROM(0.00)[larch=yhetil.org]; FROM_NEQ_ENVFROM(0.00)[christopher@librehacker.com,guix-patches-bounces@gnu.org]; ARC_NA(0.00)[]; URIBL_BLOCKED(0.00)[gnusocial.club:url,gnupg.net:url,librehacker.com:url]; FROM_HAS_DN(0.00)[]; MIME_GOOD(-0.10)[text/plain]; DMARC_NA(0.00)[librehacker.com]; HAS_LIST_UNSUB(-0.01)[]; FORGED_SENDER_MAILLIST(0.00)[] X-TUID: /0IKxnQoi3De Sounds good to me. Can you make the edit to the patch? -- Christopher Howard p: +1 (907) 374-0257 w: https://librehacker.com social: https://gnusocial.club/librehacker gpg: ADDEAADE5D607C8D (keys.gnupg.net) On Sun, 2020-05-03 at 12:58 +0200, Jakub Kądziołka wrote: > On Sat, May 02, 2020 at 02:47:56PM -0800, Christopher Howard wrote: > > I need libusb-0.1 to build some older software, but libusb-0.1 > > build > > fails due to a warning from the current GCC version. (Evidently > > libusb- > > 0.1 is set to die on any warning.) The attached patch silences the > > warning. > > Thanks for your patch! I'm wondering though, whether it wouldn't be > more > resilient to add a -Wno-error flag instead. After all, the compiler > is > going to get upgraded sooner or later, which will introduce new > warnings, and libusb 0.1 isn't getting any upgrades... > > A quick grep suggests that this wouldn't be the first package to > disable > Werror. Makes sense, since this mode is mostly useful to developers, > and > not packagers. > > What do you think? > > Kind regards, > Jakub Kądziołka