From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp12.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id wPE5I9WDI2OjKQEAbAwnHQ (envelope-from ) for ; Thu, 15 Sep 2022 21:58:13 +0200 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp12.migadu.com with LMTPS id GEobI9WDI2OeAwAAauVa8A (envelope-from ) for ; Thu, 15 Sep 2022 21:58:13 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 168BC1D1DB for ; Thu, 15 Sep 2022 21:58:13 +0200 (CEST) Received: from localhost ([::1]:38912 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oYuzz-00071v-PR for larch@yhetil.org; Thu, 15 Sep 2022 15:58:11 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:35244) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oYuzq-00071l-G9 for guix-patches@gnu.org; Thu, 15 Sep 2022 15:58:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:42299) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oYuzq-0005fd-4S for guix-patches@gnu.org; Thu, 15 Sep 2022 15:58:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1oYuzp-0003p0-Vz for guix-patches@gnu.org; Thu, 15 Sep 2022 15:58:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#57744] [PATCH 0/3] Add shirah and dependencies Resent-From: Mathieu Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Thu, 15 Sep 2022 19:58:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 57744 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Christopher Baines Cc: 57744@debbugs.gnu.org Received: via spool by 57744-submit@debbugs.gnu.org id=B57744.166327186814671 (code B ref 57744); Thu, 15 Sep 2022 19:58:01 +0000 Received: (at 57744) by debbugs.gnu.org; 15 Sep 2022 19:57:48 +0000 Received: from localhost ([127.0.0.1]:59231 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oYuzc-0003oZ-DH for submit@debbugs.gnu.org; Thu, 15 Sep 2022 15:57:48 -0400 Received: from knopi.disroot.org ([178.21.23.139]:41648) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oYuzZ-0003oP-BJ for 57744@debbugs.gnu.org; Thu, 15 Sep 2022 15:57:46 -0400 Received: from localhost (localhost [127.0.0.1]) by disroot.org (Postfix) with ESMTP id 0F6614A026; Thu, 15 Sep 2022 21:57:44 +0200 (CEST) X-Virus-Scanned: SPAM Filter at disroot.org Received: from knopi.disroot.org ([127.0.0.1]) by localhost (disroot.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id W48NJ6KWDT3i; Thu, 15 Sep 2022 21:57:43 +0200 (CEST) Date: Thu, 15 Sep 2022 21:57:42 +0200 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=disr.it; s=mail; t=1663271863; bh=VgqPElKYXXygKD8hizrXP5m+wo8Ivqj7cdk6yra1ZSs=; h=Date:From:To:Cc:In-Reply-To:References:Subject; b=slZasPGA4Cn1dzYoQgfHkO1COuzKG4lr91GF4Ng7vLF5DAm6dvObLAKvVCydWD4rv gDlIK0qVXgzZvqWChCK3km7E9oIdDhF0L8Ns2iWhAyvk9qltNTpWH16oVguG9j64sF rcSHzS5DsHJ06wD8PpXN7uhJJqcWX8LiEFg528DpUR8Msf72smXA/PQ34OqQVW0FoG ceq7AGr1e/uyjo8+qX8ssX+eMtbXLIySr1kivNWYPXkuZM06ujpKWPiOaAXEhcNzUY NKdPWKFHMAgXrPpJH8vZYfxzqeX47XBXx4AftR1j4jX3NWNF0XGJQcg33ZA/Yki3BL ld0Lznp73D8fA== From: Mathieu Message-ID: In-Reply-To: <87mtb28jfe.fsf@cbaines.net> References: <87mtb28jfe.fsf@cbaines.net> Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Content-Disposition: inline X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN X-Migadu-To: larch@yhetil.org X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1663271893; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=kSaVZPBpviG0Q59EZTykrNVGhNKzWbAQ+a07JmI37rM=; b=q3gxOmT0HDnPe3GfyBBrifKnum9kJoClYalNRuqiTdn6zP/g/+/B6r+EiogH+y3FWElr7V 532sTzPSU/FoQlT1pAjylYCBQot4dhVuR7PikGpRKg5QxuDHSsqdw/w8EXU47nyHY6CyWd +9gT5w72vH5uPXFpLsUI7rMOsbij9f4VcgWy+evrHr+az9TvYjh5AQeNlCO6+gKlpqKtN4 ElvflUUam3b63Cvd8aevm2TxmCo4hB1YhJXDn+iiQN8U0p3sPlUk4xU8ZvTNBuYayiaSH7 7mhSxguUyq17lJnHLoNO0nPAUjp+d0AMNTR+CpcJszF1Dw/FBHKlKsvzjWs+pg== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1663271893; a=rsa-sha256; cv=none; b=NvI7a1qlmcwsQjoMqX3XBmUw7XpUp1NSFONRX18vkWiIQxGImneSDlaN/WJIDt4U/vLTmA s85U/RVC/NBdvRF0GTMsjO1vvBIMYyKf8OlcHQCoS4p5ldo5C4jpSkAmRfOF2ykiPUatW+ J2w4yVnML6B7oyG+bfr8mgCNKwLs0beKwA8nkmvrcJBTdWYMOnY6HW4nrqGgQJ87LDHy3v rKMoyDwMicflqasRmKNz4NwhRPU37UMJIvPqiEgKwys5/XbZIzXgnCOADhPuHTu9WYqPaI WkNiUVXPIibpLSdwKVmKwujj22CrS49y0wo3anBrankeVRi0tTboErdiadHjpg== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=disr.it header.s=mail header.b=slZasPGA; dmarc=fail reason="SPF not aligned (relaxed)" header.from=disr.it (policy=none); spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: 9.67 X-Spam: Yes Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=disr.it header.s=mail header.b=slZasPGA; dmarc=fail reason="SPF not aligned (relaxed)" header.from=disr.it (policy=none); spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: 168BC1D1DB X-Spam-Score: 9.67 X-Migadu-Spam: Yes X-Migadu-Scanner: scn1.migadu.com X-TUID: /Lq798RvL2FQ Thanks for the review=21 I fixed the synopsis and licenses for shirah and= python-syllables, but python-ebooklib's agpl3 is correct, is it not=3F On 2022-09-14 10:09 Christopher Baines wrote: > =20 > M writes: > =20 >> shirah is a terminal-based ebook reader, which alone I'd see as a >> nice >> addition to Guix packages considering how light, flexible and >> customizable (themes, opacity, font options, keybindings) terminal >> emulators are, but it also comes with an optional RSVP mode for >> speed >> reading, which can be pretty convenient for a terminal reader since >> terminal windows can be resized to very small geometry without >> breaking. shirah also supports basic ebook-reading features, like >> resuming a read, or browsing from the TOC. >> =20 >> M (3): >> gnu: Add python-ebooklib. >> gnu: Add python-syllables. >> gnu: Add shirah. >> =20 >> gnu/packages/ebook.scm =7C 40 >> +++++++++++++++++++++++++++++++++++++ >> gnu/packages/python-xyz.scm =7C 20 +++++++++++++++++++ >> 2 files changed, 60 insertions(+) > =20 > =20 > Hey, > =20 > These generally look good to me, but I think there are a few things > to > fix before merging. > =20 > The license information looks off for all packages, can you take a > look=3F > =20 > Also, the linter makes some comments about some package synopsis. > =20 > Thanks, > =20 > Chris