From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp10.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id QDZXHsOYpmIUxwAAbAwnHQ (envelope-from ) for ; Mon, 13 Jun 2022 03:54:11 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp10.migadu.com with LMTPS id mG9YHcOYpmICTQAAG6o9tA (envelope-from ) for ; Mon, 13 Jun 2022 03:54:11 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 216B117F9D for ; Mon, 13 Jun 2022 03:54:11 +0200 (CEST) Received: from localhost ([::1]:39318 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1o0ZHO-0006We-6A for larch@yhetil.org; Sun, 12 Jun 2022 21:54:10 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:35722) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1o0ZHG-0006WF-7a for guix-patches@gnu.org; Sun, 12 Jun 2022 21:54:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:34647) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1o0ZHF-0005ST-U3 for guix-patches@gnu.org; Sun, 12 Jun 2022 21:54:01 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1o0ZHF-0006PZ-T9 for guix-patches@gnu.org; Sun, 12 Jun 2022 21:54:01 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#54906] [PATCH] build: go-build-system: Add support for #:skip-build? #t. Resent-From: Maxime Devos Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Mon, 13 Jun 2022 01:54:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 54906 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Attila Lendvai Cc: 54906@debbugs.gnu.org Received: via spool by 54906-submit@debbugs.gnu.org id=B54906.165508521124606 (code B ref 54906); Mon, 13 Jun 2022 01:54:01 +0000 Received: (at 54906) by debbugs.gnu.org; 13 Jun 2022 01:53:31 +0000 Received: from localhost ([127.0.0.1]:56777 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1o0ZGk-0006Oo-QT for submit@debbugs.gnu.org; Sun, 12 Jun 2022 21:53:31 -0400 Received: from xavier.telenet-ops.be ([195.130.132.52]:40802) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1o0ZGi-0006Oe-QU for 54906@debbugs.gnu.org; Sun, 12 Jun 2022 21:53:29 -0400 Received: from ptr-bvsjgyhxw7psv60dyze.18120a2.ip6.access.telenet.be ([IPv6:2a02:1811:8c09:9d00:3c5f:2eff:feb0:ba5a]) by xavier.telenet-ops.be with bizsmtp id iRtR2700F4UW6Th01RtSMV; Mon, 13 Jun 2022 03:53:26 +0200 Message-ID: From: Maxime Devos Date: Mon, 13 Jun 2022 03:53:16 +0200 In-Reply-To: <3D-9L8EDNEWZf3igXJF7tggNU1dw8wj5nUKGHbiHtcWciiKmwAP5QdazadE4OYLDYgzvPeOOehdi7fnc4ktx7f3KmR3N76ukjSopOc-hkS4=@lendvai.name> References: <20220413120052.25602-1-attila@lendvai.name> <2011a56256b561e89fcecc3febdc8dbc2bf7beae.camel@telenet.be> <3D-9L8EDNEWZf3igXJF7tggNU1dw8wj5nUKGHbiHtcWciiKmwAP5QdazadE4OYLDYgzvPeOOehdi7fnc4ktx7f3KmR3N76ukjSopOc-hkS4=@lendvai.name> Content-Type: multipart/signed; micalg="pgp-sha512"; protocol="application/pgp-signature"; boundary="=-77OvUAFG1RdBgcZiQ3js" User-Agent: Evolution 3.38.3-1 MIME-Version: 1.0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=telenet.be; s=r22; t=1655085206; bh=sL5HaGUx38qfcB0Jm1/md1cCaVxmWUhiOBJEEbvK8g8=; h=Subject:From:To:Cc:Date:In-Reply-To:References; b=N0a4OqjESOUWjkz4BKvUfwFJzYVWjEoObqjc+fpm0ToQyr9zGfEsz7OlLSF7aqEQJ eoUoPyRDi9yDnN3qVk2DTADuq52NlzuxXZ7VDYuu+Wr6wmAkJsAbpb+aeIhSvcOpha IgX69HuHCszDZGrpRVBQcDyb1YSDgS8R94nq3BfpQglWX5usA8/oXGktza9bA9s/vW Du26APEJnLUBLjM5L4gvR+VAQNdJz9qotDfKIJ5W6K30EWH09SoB1XJaYOPSAceb+D zYB7Ae0zE0Nd+KWM20g2RAB4OMo1S8VP6K5YShqVp/3HRyefo8uyGz6l37eNka/k9q s/uPgojCThAoQ== X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN X-Migadu-To: larch@yhetil.org X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1655085251; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post: dkim-signature; bh=sL5HaGUx38qfcB0Jm1/md1cCaVxmWUhiOBJEEbvK8g8=; b=OzU2JMNwi1YuivJyQ+V+DgeY7hDGuI7sYLqxUYVibpWybSdNy+SduF8gzjPdhaP18NHlmz svmRJeqWY9veCiCRljMQNoKj4rJqerugY7Uo/cIt9tuLZcqpg0wuBi0kIn6O9DMfi/Sdp8 WJtn/BjkpmvuDsGmj8otwMJJCjZO85DDkKawtf9dJvD9hCUlFARJ0AM6rs5eJGcPn3MPFm hAcLSDNzFIajs0B81dgbJmhFEYH1r6LpT/YZEuJhZaHohB6fcXJV47k2wc5u1sfWWbFj2y Ilo0Y3r5ez/r3RS7ndQrDy+o/F29X+dkBEyLzNN6mTf6DZ8vGrX5/nwh/xRUqw== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1655085251; a=rsa-sha256; cv=none; b=KW7A4ocxdPAzV4r6awVRBkBFfn6fB8Obw9aEFIhVEx8USQYWtT+DPPxvJE/gWC+1sZQsWo Zu4/njYw25WfNbg/SmNr5qD35duBzpVeLJ13t/TQAPtS6G5fHVo6Buu9C/AbBtTqWOHAPA DVvXs2vGwpByx2XnfDYrC7/mcG6wU4HpgMp0bMFeJRChRLbU5chuDmJ8Iy9e31vkTarTim GAus4xryMlzgu7u4NkvTFkc+sN7R6yP7b89/6KXHiPbVbjBz+oWISmlXgdZRHuK60+4vYQ 33gTt36BLu7veJ6s1lqiSMrZQLIGExOnIuCMB6Zkrrb4m2uMHRLFxopDtumskQ== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=telenet.be header.s=r22 header.b=N0a4OqjE; dmarc=fail reason="SPF not aligned (relaxed)" header.from=telenet.be (policy=none); spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: 3.11 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=telenet.be header.s=r22 header.b=N0a4OqjE; dmarc=fail reason="SPF not aligned (relaxed)" header.from=telenet.be (policy=none); spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: 216B117F9D X-Spam-Score: 3.11 X-Migadu-Scanner: scn0.migadu.com X-TUID: VPRSNLBbB6XS --=-77OvUAFG1RdBgcZiQ3js Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Attila Lendvai schreef op do 28-04-2022 om 12:14 [+0000]: > i'm afraid i'm stepping beyond my level of knowledge here... but i >=C2=A0think this may not be true for golang. Barring any evidence to the contrary, I'm going to assume this is not the case, because this tends to be false for other languages. And even if the dependent does build while the dependency doesn't, then either that would cause problems at runtime due to the dependency being broken or the dependency is unused, i.e., it wasn't an actual dependency after all. Attila Lendvai schreef op do 28-04-2022 om 12:14 [+0000]: > and AFAIU, the current GO-BUILD-SYSTEM doesn't reuse any build > artifacts. Currently, it doesn't reuse them, but in the past it did, and maybe in the future it can do again. More generally, the use of #:skip-build? and =E2=80=98let's only actually b= uild all the things in the leaf package=E2=80=99 has lead to several problems in Rust: * things that weren't actually dependencies were packaged E.g.: all crates that require an unstable rust compiler. * things that are only required on platforms that Guix doesn't support anyways were packaged (e.g.: winapi, redox, cocoa and foundation crates (e.g.: crates using =E2=80=98unstable=E2=80=99 features which cannot be= compiled, or crates * cycles (doesn't apply to Go though) * packages with incorrect dependency information, that only happen to work because of how #:skip-build? implies propagation and because of Cargo's dependency resolving algorithms smoothing over them (don't know if this applies to Go). * impossibility of grafting (not relevant to Go, I think Go is too static-library-specific for that?) While maybe not all are 100% caused by #:skip-build? or apply to Go 100%, I don't think these issues should be spread to Go as well, so TBC, =C2=ACLGTM. (I guess this invalid my previous remark: > To be clear, my comment was more about the wording (feature / work- > around / ...) than about the addition of #:skip-build?. ). Greetings, Maxime. --=-77OvUAFG1RdBgcZiQ3js Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- iI0EABYKADUWIQTB8z7iDFKP233XAR9J4+4iGRcl7gUCYqaYjBccbWF4aW1lZGV2 b3NAdGVsZW5ldC5iZQAKCRBJ4+4iGRcl7oH0AQD+X5NB8o4tjBbKi3iKDKR9pD8e 7Ir5foDHhICT+CVcxAD+O2CoNHE7iQ/hrwKVW2ZRr1czYRB3feTorjZ+kx20Jgw= =l5To -----END PGP SIGNATURE----- --=-77OvUAFG1RdBgcZiQ3js--