[bug#42460] [PATCH 0/2] gnu: vlc: add support for MIDI and chiptunes

[bug#42460] [PATCH 0/2] gnu: vlc: add support for MIDI and chiptunes

[Jesse Gibbons]

The following patch series adds support for MIDI (with FluidSynth) and 
chiptunes (with gme) in VLC.

-Jesse

[bug#42460] [PATCH 1/2] gnu: vlc: Add support for MIDI files

[Jesse Gibbons]

* gnu/packages/video.scm (vlc): add MIDI support with FluidSynth
[inputs]: Add FluidSynth.
[arguments]: Pass "--enable-fluidsynth" to configure
---
gnu/packages/video.scm | 2 ++
1 file changed, 2 insertions(+)

diff --git a/gnu/packages/video.scm b/gnu/packages/video.scm
index 4120174484..a4e097e9a2 100644
--- a/gnu/packages/video.scm
+++ b/gnu/packages/video.scm
@@ -1249,6 +1249,7 @@ videoformats depend on the configuration flags of 
ffmpeg.")
("dbus" ,dbus)
("eudev" ,eudev)
("flac" ,flac)
+ ("fluidsynth" ,fluidsynth)
("ffmpeg" ,ffmpeg)
("fontconfig" ,fontconfig)
("freetype" ,freetype)
@@ -1319,6 +1320,7 @@ videoformats depend on the configuration flags of 
ffmpeg.")
(arguments
`(#:configure-flags
`("BUILDCC=gcc"
+ "--enable-fluidsynth"
,(string-append "LDFLAGS=-Wl,-rpath -Wl,"
(assoc-ref %build-inputs "ffmpeg")
"/lib")) ;needed for the tests

[bug#42460] [PATCH 2/2] gnu: vlc: Add support for gme.

[Jesse Gibbons]

* gnu/packages/video.scm: vlc (inputs): Add libgme.
---
gnu/packages/video.scm | 4 ++++
1 file changed, 4 insertions(+)

diff --git a/gnu/packages/video.scm b/gnu/packages/video.scm
index a4e097e9a2..6b57d384e1 100644
--- a/gnu/packages/video.scm
+++ b/gnu/packages/video.scm
@@ -44,6 +44,7 @@
;;; Copyright © 2020 Michael Rohleder <mike@rohleder.de>
;;; Copyright © 2020 Vinicius Monego <monego@posteo.net>
;;; Copyright © 2020 Brett Gilio <brettg@gnu.org>
+;;; Copyright © 2020 Jesse Gibbons <jgibbons2357+guix@gmail.com>
;;;
;;; This file is part of GNU Guix.
;;;
@@ -131,6 +132,7 @@
#:use-module (gnu packages markup)
#:use-module (gnu packages maths)
#:use-module (gnu packages mp3)
+ #:use-module (gnu packages music)
#:use-module (gnu packages ncurses)
#:use-module (gnu packages networking)
#:use-module (gnu packages ocr)
@@ -1268,6 +1270,7 @@ videoformats depend on the configuration flags of 
ffmpeg.")
("libdvdread" ,libdvdread)
("libebml" ,libebml)
("libgcrypt" ,libgcrypt)
+ ("libgme" ,libgme)
("libidn" ,libidn)
("libkate" ,libkate)
("libmad" ,libmad)
@@ -1321,6 +1324,7 @@ videoformats depend on the configuration flags of 
ffmpeg.")
`(#:configure-flags
`("BUILDCC=gcc"
"--enable-fluidsynth"
+ "--enable-gme"
,(string-append "LDFLAGS=-Wl,-rpath -Wl,"
(assoc-ref %build-inputs "ffmpeg")
"/lib")) ;needed for the tests

[bug#42460] [PATCH 0/2] gnu: vlc: add support for MIDI and chiptunes

[Marius Bakke]

[-- Attachment #1: Type: text/plain, Size: 299 bytes --]

Jesse Gibbons <jgibbons2357@gmail.com> writes:

> The following patch series adds support for MIDI (with FluidSynth) and 
> chiptunes (with gme) in VLC.

These patches are also ill-formatted.

And note that the libgme GCC issue should be fixed before adding it as a
dependency to packages.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 487 bytes --]

[bug#42460] [PATCH 0/2] gnu: vlc: add support for MIDI and chiptunes

[Jesse Gibbons]

I'll look into this and combine with #42455 when libgme doesn't have gcc 
as a transitive package.

On 7/25/20 9:31 AM, Marius Bakke wrote:
> Jesse Gibbons <jgibbons2357@gmail.com> writes:
>
>> The following patch series adds support for MIDI (with FluidSynth) and
>> chiptunes (with gme) in VLC.
> These patches are also ill-formatted.
>
> And note that the libgme GCC issue should be fixed before adding it as a
> dependency to packages.

[bug#42460] [PATCH 0/2] gnu: vlc: add support for MIDI and chiptunes

[Jesse Gibbons]

Is there a bug corresponding to the libgme GCC issue?

On 7/25/20 9:31 AM, Marius Bakke wrote:
> Jesse Gibbons <jgibbons2357@gmail.com> writes:
>
>> The following patch series adds support for MIDI (with FluidSynth) and 
>> chiptunes (with gme) in VLC.
> These patches are also ill-formatted.
>
> And note that the libgme GCC issue should be fixed before adding it as a
> dependency to packages.

[bug#42460]

[Clément Lassieur]

[-- Attachment #1: Type: text/plain, Size: 186 bytes --]

Hi,

Any update on this patch?

It looks like libgme GCC is fixed: https://git.savannah.gnu.org/cgit/guix.git/commit/?id=5c4b76ce372899db9d6e85dbadfb168436e0123f

Thanks,
Clément

[-- Attachment #2: Type: text/html, Size: 537 bytes --]