unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: phodina via Guix-patches via <guix-patches@gnu.org>
To: Maxime Devos <maximedevos@telenet.be>
Cc: 56664@debbugs.gnu.org, Julien Lepiller <julien@lepiller.eu>
Subject: [bug#56664] [PATCH] gnu: Add qtscrcpy.
Date: Wed, 20 Jul 2022 15:03:50 +0000	[thread overview]
Message-ID: <aFW_3GO_xxcIBIsJ-jSVwWYZkUFtX5Vs4IbtP4XC8FRmFWLSvY6nRbweVFekQdbUFFoyY_LG4RyR-_ObGIiSOONMsFkyF_bnqi7AxQTA2Io=@protonmail.com> (raw)
In-Reply-To: <acd00d5a-ded1-1a01-3072-7fc09813afed@telenet.be>

[-- Attachment #1: Type: text/plain, Size: 2200 bytes --]

Hi Maxime,

> - The Android part scrcpy-server is prebuild due to Guix not supporting gradle and Android builds. Without this the tool does not work.
>
> OK, though then this is a draft patch that's blocked by supporting gradle and Android; Guix is a build-from-source distro (there are some bootstrap seeds, but the idea is to reduce them, not enlarge them).

I understand that the aim is to reduce the prebuild stuff not vice versa that's why I labeled it here. One solution could be to replace the location by specifying some env variable and the user would supply either the prebuild version from the repo or build it themself e.g. in Docker.

This way the package would not have any prebuild files. Would that be okay?

> Someone else has been looking into supporting Android (something about a longsoon-build-system), maybe you can test that, and I don't know if anyone has been looking at addressing the gradle problems.

Do you mean the work of Julien Lepiller [1]?

> Also, from a cursory look, I'm not seeing gradle there and neither am I seeing Android builds, maybe all that's needed is adding the adb package (which is packaged in Guix), no gradle or Android support needed, or I didn't look in the right places?

Android sources are located under the directory server [2]. There's also meson build file but it will still need Android build environment to create the executable out of the java files.

> I've currently hardcoded the x86 architecture in the install phase. Not sure how to make it architecture agnostic.

Here I'm refering to the CMake which places the output in 'output/x86/...' directory. Unfortunately the CMakeLists.txt does not specify how to install the files so it has to be done manually.

Could you suggest some package which I could use as an example to write Guile code that will make it independent of the machine arch?

> Also, why are tests disabled?

Haven't found any. Will add note about no test suite.

> We are not restricted to plain text in descriptions, you can use Texinfo markup like @emph.

Thanks, will use more the markup :-)

[1] https://framagit.org/tyreunom/guix-android
[2] https://github.com/barry-ran/QtScrcpy/tree/v2.0.1/server

----
Petr

[-- Attachment #2: Type: text/html, Size: 5365 bytes --]

  reply	other threads:[~2022-07-20 15:05 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-07-20 13:20 [bug#56664] [PATCH] gnu: Add qtscrcpy phodina via Guix-patches via
2022-07-20 13:48 ` Maxime Devos
2022-07-20 15:03   ` phodina via Guix-patches via [this message]
2022-07-20 15:10     ` Maxime Devos
2022-07-20 15:18       ` Maxime Devos
2022-07-20 15:17     ` Maxime Devos
2022-07-20 15:32       ` phodina via Guix-patches via

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='aFW_3GO_xxcIBIsJ-jSVwWYZkUFtX5Vs4IbtP4XC8FRmFWLSvY6nRbweVFekQdbUFFoyY_LG4RyR-_ObGIiSOONMsFkyF_bnqi7AxQTA2Io=@protonmail.com' \
    --to=guix-patches@gnu.org \
    --cc=56664@debbugs.gnu.org \
    --cc=julien@lepiller.eu \
    --cc=maximedevos@telenet.be \
    --cc=phodina@protonmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).