unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: Brendan Tildesley <mail@brendan.scot>
To: "Prafulla Giri <pratheblackdiamond"@gmail.com,
	Andreas Enge <andreas@enge.fr>
Cc: 43249@debbugs.gnu.org, 43151@debbugs.gnu.org
Subject: [bug#43249] Resolve Calibre run-time dependency
Date: Mon, 7 Sep 2020 18:12:37 +1000	[thread overview]
Message-ID: <a99e52ae-decc-0396-6d4e-d3dff56dd5d2@brendan.scot> (raw)
In-Reply-To: <CAFw+=j010xqQencD-4RiGBswmkK9HAyxnnqnQ2NN_nHkZbtGew@mail.gmail.com>

There is actually a Bug report by Andreas for this very issue. I created 
a bug report just for updating, and fixed this issue after it while I 
could, without realising. Sorry for all the confusion with things 
happening in 3 different threads.

I created an updated patch just for this one here. 
https://issues.guix.gnu.org/43151#5

Your patch also works I think but it will wrap the programs twice, so 
you will get calibre, .calibre-real, and ..calibre-real-real, etc for 
every program, which seems ugly. My patch reproduces the same PYTHONPATH 
that is set in python-build-system in addition to wrapping PYTHONPATH 
(unless I made a mistake), although at the cost of code duplication. I 
leave it to you and who ever is reviewing this to decide which way is 
more correct and push one, haha.


Please continue any discussion of the QtWebEngine bug on issue 43121: 
43151@debbugs.gnu.org / https://issues.guix.gnu.org/43151





  parent reply	other threads:[~2020-09-07  8:13 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-09-06 18:32 [bug#43249] Resolve Calibre run-time dependency Prafulla Giri
2020-09-06 20:09 ` Jonathan Brielmaier
2020-09-07  8:12 ` Brendan Tildesley [this message]
     [not found]   ` <6492c3cc-07e0-b56b-ea72-99d403770755@brendan.scot>
     [not found]     ` <20200908201144.GA25269@jurong>
2020-09-09  8:38       ` [bug#43249] bug#43151: " Prafulla Giri
2020-09-08 12:22 ` [bug#43249] Prafulla Giri
2020-09-08 13:38   ` [bug#43249] Brendan Tildesley
2020-09-08 19:57   ` [bug#43249] Ricardo Wurmus
2020-09-10 12:46     ` [bug#43249] Brendan Tildesley
2020-09-10 13:22       ` [bug#43249] Ricardo Wurmus
2020-09-11  8:18         ` [bug#43249] Brendan Tildesley
2020-09-11  8:38           ` [bug#43249] Ricardo Wurmus
2020-09-12 11:33             ` [bug#43249] Brendan Tildesley
2020-09-12 12:21               ` [bug#43249] Ricardo Wurmus
2020-09-13 12:43   ` [bug#43249] Brendan Tildesley
2020-09-15 11:50     ` [bug#43249] Prafulla Giri
2020-09-18 13:26       ` [bug#43249] Prafulla Giri

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=a99e52ae-decc-0396-6d4e-d3dff56dd5d2@brendan.scot \
    --to=mail@brendan.scot \
    --cc="Prafulla Giri <pratheblackdiamond"@gmail.com \
    --cc=43151@debbugs.gnu.org \
    --cc=43249@debbugs.gnu.org \
    --cc=andreas@enge.fr \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).