From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:470:142:3::10]:55161) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1igHV1-00079A-FQ for guix-patches@gnu.org; Sat, 14 Dec 2019 19:11:04 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1igHV0-0005O6-2E for guix-patches@gnu.org; Sat, 14 Dec 2019 19:11:03 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:58154) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1igHUz-0005Np-U6 for guix-patches@gnu.org; Sat, 14 Dec 2019 19:11:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1igHUz-0000D8-PQ for guix-patches@gnu.org; Sat, 14 Dec 2019 19:11:01 -0500 Subject: [bug#38480] [PATCH] gnu: Add lolcat Resent-Message-ID: Message-ID: From: Leo Prikler Date: Sun, 15 Dec 2019 01:10:30 +0100 In-Reply-To: <87k16ywkpp.fsf@gnu.org> References: <20191204014644.1491-1-leo.prikler@student.tugraz.at> <877e3ciylo.fsf@posteo.net> <87k16ywkpp.fsf@gnu.org> Content-Type: multipart/mixed; boundary="=-vGosJ4/aO7DH+J77wT8B" MIME-Version: 1.0 List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: Ludovic =?UTF-8?Q?Court=C3=A8s?= Cc: 38480@debbugs.gnu.org, Brett Gilio --=-vGosJ4/aO7DH+J77wT8B Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit Hello! Am Sonntag, den 15.12.2019, 00:28 +0100 schrieb Ludovic Courtès: > Hello! > > Leo Prikler skribis: > > > From: Leo Prikler > > Date: Wed, 4 Dec 2019 02:46:44 +0100 > > Subject: [PATCH] gnu: Add lolcat > > > > * gnu/packages/games.scm (lolcat): New package. > > [...] > > > + (replace 'install > > + (lambda* (#:key outputs #:allow-other-keys) > > + (let ((dest (map (lambda (path) (string-append path > > "/bin")) > > + (list (assoc-ref outputs "out") > > + (assoc-ref outputs > > "censor"))))) > > + (for-each mkdir-p dest) > > + (install-file "lolcat" (car dest)) > > + (install-file "censor" (cadr dest)) > > + #t)))))) > > + (outputs (list "out" "censor")) > > Can’t we keep them both in the same output? Separate outputs are > normally only used when it helps save space, but I don’t think that’s > a > concern here. :-) Of course we can. I initially separated them, because it's really two very different programs put into one git repo, but of course the separation serves no real purpose. > > + (home-page "https://github.com/jaseg/lolcat") > > + (synopsis "Rainbow coloring effect for text console > > display") > > + (description "Lolcat concatenates files and streams like > > regular cat, > ^ > ^ > Maybe @command{cat} and @command{lolcat}. Not sure about @command{lolcat}, since it's at the start of the sentence, but okay. > Could you send an updated patch? > > Thanks, > Ludo’. Patch is attached. Regards, Leo --=-vGosJ4/aO7DH+J77wT8B Content-Disposition: attachment; filename="0001-gnu-Add-lolcat.patch" Content-Type: text/x-patch; name="0001-gnu-Add-lolcat.patch"; charset="UTF-8" Content-Transfer-Encoding: base64 RnJvbSA0MjgyNzc0OGU1MGZlMjBmZGYyM2ZmMTEzNzA2N2E3ZDZjODBjODdlIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBMZW8gUHJpa2xlciA8bGVvLnByaWtsZXJAc3R1ZGVudC50dWdy YXouYXQ+CkRhdGU6IFdlZCwgNCBEZWMgMjAxOSAwMjo0Njo0NCArMDEwMApTdWJqZWN0OiBbUEFU Q0hdIGdudTogQWRkIGxvbGNhdAoKKiBnbnUvcGFja2FnZXMvZ2FtZXMuc2NtIChsb2xjYXQpOiBO ZXcgcGFja2FnZS4KLS0tCiBnbnUvcGFja2FnZXMvZ2FtZXMuc2NtIHwgMzggKysrKysrKysrKysr KysrKysrKysrKysrKysrKysrKysrKysrKysKIDEgZmlsZSBjaGFuZ2VkLCAzOCBpbnNlcnRpb25z KCspCgpkaWZmIC0tZ2l0IGEvZ251L3BhY2thZ2VzL2dhbWVzLnNjbSBiL2dudS9wYWNrYWdlcy9n YW1lcy5zY20KaW5kZXggZGVkMjdjMWY2My4uMWYwOGRkMjQwYSAxMDA2NDQKLS0tIGEvZ251L3Bh Y2thZ2VzL2dhbWVzLnNjbQorKysgYi9nbnUvcGFja2FnZXMvZ2FtZXMuc2NtCkBAIC01MDIsNiAr NTAyLDQ0IEBAIGNvd3MgY2FuIHRoaW5rIHRvbzogYWxsIHlvdSBoYXZlIHRvIGRvIGlzIHJ1biBA Y29tbWFuZHtjb3d0aGlua30uICBJZiB5b3UncmUKIHRpcmVkIG9mIGNvd3MsIGEgdmFyaWV0eSBv ZiBvdGhlciBBU0NJSS1hcnQgbWVzc2VuZ2VycyBhcmUgYXZhaWxhYmxlLiIpCiAgICAgKGxpY2Vu c2UgbGljZW5zZTpncGwzKykpKQogCisoZGVmaW5lLXB1YmxpYyBsb2xjYXQKKyAgKGxldCAoKGNv bW1pdCAiMzVkY2EzZDBhMzgxNDk2ZDcxOTVjZDc4ZjViMjRhYTdiNjJmMjE1NCIpCisgICAgICAg IChyZXZpc2lvbiAiMCIpKQorICAgIChwYWNrYWdlCisgICAgICAobmFtZSAibG9sY2F0IikKKyAg ICAgICh2ZXJzaW9uIChnaXQtdmVyc2lvbiAiMS4wIiByZXZpc2lvbiBjb21taXQpKQorICAgICAg KHNvdXJjZQorICAgICAgIChvcmlnaW4KKyAgICAgICAgIChtZXRob2QgZ2l0LWZldGNoKQorICAg ICAgICAgKHVyaSAoZ2l0LXJlZmVyZW5jZQorICAgICAgICAgICAgICAgKHVybCAiaHR0cHM6Ly9n aXRodWIuY29tL2phc2VnL2xvbGNhdC5naXQiKQorICAgICAgICAgICAgICAgKGNvbW1pdCBjb21t aXQpKSkKKyAgICAgICAgIChzaGEyNTYKKyAgICAgICAgICAoYmFzZTMyCisgICAgICAgICAgICIw ampia3FjYzJpa2p4ZDF4Z2R5djRyYjB2c3cyMTgxODFoODlmMnl3ZzI5ZmZzM3lwZDhnIikpCisg ICAgICAgICAoZmlsZS1uYW1lIChnaXQtZmlsZS1uYW1lIG5hbWUgdmVyc2lvbikpKSkKKyAgICAg IChidWlsZC1zeXN0ZW0gZ251LWJ1aWxkLXN5c3RlbSkKKyAgICAgIChhcmd1bWVudHMKKyAgICAg ICBgKCM6dGVzdHM/ICNmIDs7IG5vIGNoZWNrIHRhcmdldAorICAgICAgICAgIzptYWtlLWZsYWdz IChsaXN0ICJDQz1nY2MiKQorICAgICAgICAgIzpwaGFzZXMKKyAgICAgICAgIChtb2RpZnktcGhh c2VzICVzdGFuZGFyZC1waGFzZXMKKyAgICAgICAgICAgKGRlbGV0ZSAnYm9vdHN0cmFwKQorICAg ICAgICAgICAoZGVsZXRlICdjb25maWd1cmUpCisgICAgICAgICAgIChyZXBsYWNlICdpbnN0YWxs CisgICAgICAgICAgICAgKGxhbWJkYSogKCM6a2V5IG91dHB1dHMgIzphbGxvdy1vdGhlci1rZXlz KQorICAgICAgICAgICAgICAgKGxldCAoKGRlc3QgKHN0cmluZy1hcHBlbmQgcGF0aCAiL2JpbiIp KSkKKyAgICAgICAgICAgICAgICAgKG1rZGlyLXAgZGVzdCkKKyAgICAgICAgICAgICAgICAgKGlu c3RhbGwtZmlsZSAibG9sY2F0IiBkZXN0KQorICAgICAgICAgICAgICAgICAjdCkpKSkpKQorICAg ICAgKG91dHB1dHMgKGxpc3QgIm91dCIgImNlbnNvciIpKQorICAgICAgKGhvbWUtcGFnZSAiaHR0 cHM6Ly9naXRodWIuY29tL2phc2VnL2xvbGNhdCIpCisgICAgICAoc3lub3BzaXMgIlJhaW5ib3cg Y29sb3JpbmcgZWZmZWN0IGZvciB0ZXh0IGNvbnNvbGUgZGlzcGxheSIpCisgICAgICAoZGVzY3Jp cHRpb24gIkBjb21tYW5ke2xvbGNhdH0gY29uY2F0ZW5hdGVzIGZpbGVzIGFuZCBzdHJlYW1zIGxp a2UKK3JlZ3VsYXIgQGNvbW1hbmR7Y2F0fSwgYnV0IGl0IGFsc28gYWRkcyB0ZXJtaW5hbCBlc2Nh cGUgY29kZXMgYmV0d2VlbgorY2hhcmFjdGVycyBhbmQgbGluZXMgcmVzdWx0aW5nIGluIGEgcmFp bmJvdyBlZmZlY3QuIikKKyAgICAgIChsaWNlbnNlIGxpY2Vuc2U6d3RmcGwyKSkpKQorCiAoZGVm aW5lLXB1YmxpYyBmcmVlZG9vbQogICAocGFja2FnZQogICAgIChuYW1lICJmcmVlZG9vbSIpCi0t IAoyLjI0LjAKCg== --=-vGosJ4/aO7DH+J77wT8B--