From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1 ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id AJlGOfJOjmCnYAAAgWs5BA (envelope-from ) for ; Sun, 02 May 2021 09:04:18 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1 with LMTPS id qNHTNPJOjmBMJwAAbx9fmQ (envelope-from ) for ; Sun, 02 May 2021 07:04:18 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 74E261FE41 for ; Sun, 2 May 2021 09:04:17 +0200 (CEST) Received: from localhost ([::1]:59240 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ld69I-00081d-Na for larch@yhetil.org; Sun, 02 May 2021 03:04:16 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:51594) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ld694-00080h-R2 for guix-patches@gnu.org; Sun, 02 May 2021 03:04:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:57661) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1ld694-0008IC-Jc for guix-patches@gnu.org; Sun, 02 May 2021 03:04:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1ld694-0004yW-Ei for guix-patches@gnu.org; Sun, 02 May 2021 03:04:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#48028] [PATCH wip-gnome 0/8]: Misc. Resent-From: Leo Prikler Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sun, 02 May 2021 07:04:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 48028 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: =?UTF-8?Q?=E5=AE=8B=E6=96=87=E6=AD=A6?= Cc: Raghav Gururajan , 48028@debbugs.gnu.org Received: via spool by 48028-submit@debbugs.gnu.org id=B48028.161993899219089 (code B ref 48028); Sun, 02 May 2021 07:04:02 +0000 Received: (at 48028) by debbugs.gnu.org; 2 May 2021 07:03:12 +0000 Received: from localhost ([127.0.0.1]:40966 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ld68F-0004xp-Kp for submit@debbugs.gnu.org; Sun, 02 May 2021 03:03:11 -0400 Received: from mailrelay.tugraz.at ([129.27.2.202]:30454) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ld68C-0004xj-Tc for 48028@debbugs.gnu.org; Sun, 02 May 2021 03:03:10 -0400 Received: from nijino.local (91-114-247-246.adsl.highway.telekom.at [91.114.247.246]) by mailrelay.tugraz.at (Postfix) with ESMTPSA id 4FXxrn1F31z3xn5; Sun, 2 May 2021 09:03:05 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tugraz.at; s=mailrelay; t=1619938985; bh=vZybsBEh5n4H0zgHeUW2Gb4f0Fewz24QBjzV4cFCErc=; h=Subject:From:To:Cc:Date:In-Reply-To:References; b=fqvWjMc3HhHgJAwzVWNTLj9F6EcBZEwqHuvOiwED3y7a8CE6bwQ60i/WNLVKyZ9S9 LlxVsPM/0ZMTcutgIYTywRNFIqHU30kXdGCx7EQyQFqC8KTAR7GZQcdR5arPjsbeCi Fj1QcBjwgjP1sE0q5xkWrAay4kG5Qa1iqpEQtsMQ= Message-ID: From: Leo Prikler Date: Sun, 02 May 2021 09:03:04 +0200 In-Reply-To: References: <20210427092334.23537-1-rg@raghavgururajan.name> <20210427092334.23537-5-rg@raghavgururajan.name> Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.34.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-TUG-Backscatter-control: bt4lQm5Tva3SBgCuw0EnZw X-Spam-Scanner: SpamAssassin 3.003001 X-Spam-Score-relay: -1.9 X-Scanned-By: MIMEDefang 2.74 on 129.27.10.117 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1619939057; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=vZybsBEh5n4H0zgHeUW2Gb4f0Fewz24QBjzV4cFCErc=; b=jDBYn7cvhcXujHHJ1+Q174SyjOT6wUAov2LfIAOTGkIcVN8iMrbm+5pEHIKg25FxkMgobk WRn8hSrVE7AiqfxJL1OgyAVd+U82bvu6bi6WFoVJsnRxXrnwB375vYuAU9S4BHxnYrsSHN K1nX8tzLSbIlsErHwf9Y8/PzbiGiuD/7CIK4pVVHvvsBLVg9fg5cKilzD0Q4JYmaPqzr6/ IudB0tSSa0VDXt6ADf2N1B2/1dt70CpoleA3z9WHs7MBav/4FkuaNRC20ZpCoZGcILxyvc F0DcjwoBD1treFm8j+AAMjEDzZMKp49Q8fvrBYLAD3Y6Zv5GnMMals9oO4s5lQ== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1619939057; a=rsa-sha256; cv=none; b=AtRSCunQs1IBzFUVhErmsVv+H4Y6mjl82Q7pJZ+D0CjJ/WZ1WUCoF1uPX4v0j8yCCAwZCF mjv0qn5LbVKf4HQZ3Pcc0PHsOpK9kq9vm8VhISp5W0bh9GQ7FfGZ64kmoOGkTqqo7rteex O4JErJ7aQmBZjDQX+aB9s+dqfl2O3efcwYQChlviEPEi4Em8zr0zcWxTUbt790oOr/w2y4 ICVITP1wmlVrseHjdl097PHk0Wzg8RhvaZJ8dVRya1wg2KFvXaAwTbsXFeLvYvHNH+kXjQ 4mRfE6jZlM3ffLkKP+gQWHWUN0EDjgZk72SAQ1NTioloeVhFDeXjmWNEZBV6qA== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=tugraz.at header.s=mailrelay header.b=fqvWjMc3; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Spam-Score: -0.53 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=tugraz.at header.s=mailrelay header.b=fqvWjMc3; dmarc=fail reason="SPF not aligned (relaxed)" header.from=student.tugraz.at (policy=none); spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Queue-Id: 74E261FE41 X-Spam-Score: -0.53 X-Migadu-Scanner: scn0.migadu.com X-TUID: uyg348ZlrpCM Am Sonntag, den 02.05.2021, 13:14 +0800 schrieb 宋文武: > Leo Prikler writes: > > > Am Mittwoch, den 28.04.2021, 09:07 -0400 schrieb Raghav Gururajan: > > > Hi Leo, > > > > > > > After looking at this more closely, the comment is a little > > > > misleading, > > > > since the libsoup-2.4.pc does not actually refer to glib- > > > > networking. > > > > What is the rationale behind this propagation? > > > > In v1 you claimed the .pc file mentions this, but I don't see > > > > any > > > > of > > > > it: > > > > libsoup-2.4.pc:Requires: glib-2.0 >= 2.58, gobject-2.0 > > > > >= 2.58, > > > > gio- > > > > 2.0 >= 2.58 > > > > libsoup-2.4.pc:Requires.private: libxml-2.0, sqlite3, libpsl > > > > > = 0.20, > > > > libbrotlidec, zlib > > > > libsoup-gnome-2.4.pc:Requires: libsoup-2.4 > > > > libsoup-gnome-2.4.pc:Requires.private: glib-2.0 >= 2.58, > > > > gobject- > > > > 2.0 > > > > > = 2.58, gio-2.0 >= 2.58, libxml-2.0, sqlite3, libpsl > > > > > >= 0.20, > > > > libbrotlidec, zlib > > > > > > It `gio` I was referring to. GIO can mean [glib]/lib/libgio or > > > [glib-networking]/lib/gio/modules/libgio* or both. It depends on > > > what > > > package it is. Libsoup is a networking package, which uses > > > glib-networking as tls backend. So GIO networking modules > > > provided > > > by > > > glib-networking, is required by libsoup at runtime. > > Yes, glib-networking provides 2 gio modules: > - libgiognutls.so: Let GIO based applications access HTTPS (TLS). > - libgiognomeproxy.so: Let GIO based applications use GNOME proxy > settings. > > They're required at runtime, and optional (one may argue that HTTPS > is a > must have feature though). Currently we add glib-networking to > webkit > browsers's inputs (eg: epiphany, luakit, etc.) directly, and wrap it > with 'GIO_EXTRA_MODULES'. By propagated glib-networking in libsoup, > we > can remove it from inputs of thoese web browsers, but we still have > to > wrap them... > > Maybe there is a way to hardcode glib-networking in libsoup so that > we > can get rid of GIO_EXTRA_MODULES? (another gio module is the > gsettings > backends dconf, which also need a user dbus-daemon user spawn its > backend service...) > > > I don't think "gio inside .pc" means that, however. I do agree, > > that > > it might be worth propagating it as a runtime dependency, but it > > should > > be done with a suitable comment. > > I Agree with Leo. Raghav, could you look into if we can get rid of > GIO_EXTRA_MODULES for glib-networking or add a specified comment for > this comment (maybe: "For HTTPS and GNOME proxy support")? I didn't go as far as you. All I wanted to say, was that insinuating it to be a pkg-config dependency might be misleading, and that we ought to have a suitable comment. I've already pushed that patch to master with one I wrote myself. I'm not quite sure what's the problem with wrapping here. Does glib- or-gtk-build-system not take care of GIO_EXTRA_MODULES? Regards, Leo