From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0.migadu.com ([2001:41d0:403:58f0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms13.migadu.com with LMTPS id wLlaJrsLh2a1QAAAqHPOHw:P1 (envelope-from ) for ; Thu, 04 Jul 2024 20:53:15 +0000 Received: from aspmx1.migadu.com ([2001:41d0:403:58f0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0.migadu.com with LMTPS id wLlaJrsLh2a1QAAAqHPOHw (envelope-from ) for ; Thu, 04 Jul 2024 22:53:15 +0200 X-Envelope-To: larch@yhetil.org Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=dismail.de header.s=20190914 header.b=s46mh3Eq; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1720126395; h=from:from:sender:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=5pZv9UvtbiVgSYL1DwrAeNN3ovv0dZdGHk7gxew52Uw=; b=L2WOMmR4cxfDp/YEnmzB3HshUL4uQNpCj/YjsSAV8HFcHZgY/p+2KqDhzvNT29GavXF4A8 lanALuzTVRudSnhpXue/5Gk8y++ntao4dWSWyODgBrczUueyCnX8TSUzeRIxQX2yXIVnIO txnEl+Qb+kcBBZLab4rIOV09msKgJrf5+a4dKRkOv21p7yYzGiUwHrcqwutfGe+/O5oqBl TsuOvq3IcE+G7wKt2z1nAVoNBSSGVWILkjdkyO/kPJvkghXuFuTgb/IVHzPfUaDbNLcBow TMcr7NuIUPt7b/7v4wPqyIFrG8rJ+B+Z9RtDKgSoi1RNSuLGaP6GOZiKXXOJhA== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1720126395; a=rsa-sha256; cv=none; b=Zx7JlPLKqfknbkwuRmRjNulbFH8z7RD3/vWFhDduRkHxoJSve/2vqlrn8b0TmwWpJT4ZOz urLNo+kKNPLPs51GgHcYR0wsoyhUlgbMdDbWycaBQcJI8D3+kkCB+RLF+2BOCeK199I3Ml cnmQj4RRXlSUWIRokmjZQBlJh9m/nH7OIbiFmfsOIEqthBCGG7EOouLiUV6vPLiRm1W4Nk noEssqcPobuScELMhJRmooONBC0y5qYp+Ps8GpLuOHYJuMtrmontFyd0kaudeFBhsRdNZr ew7+f+6n4Y4+ldKvIeNHruZV68DmRkcSpHbkEHgMm/eIgNBcPuCsj+RSeqj5FA== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=dismail.de header.s=20190914 header.b=s46mh3Eq; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 5FEBF67032 for ; Thu, 04 Jul 2024 22:53:15 +0200 (CEST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sPTRu-0000Ub-VT; Thu, 04 Jul 2024 16:53:02 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sPTRs-0000UI-G1 for guix-patches@gnu.org; Thu, 04 Jul 2024 16:53:00 -0400 Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1sPTRs-0006Fp-6S for guix-patches@gnu.org; Thu, 04 Jul 2024 16:53:00 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1sPTRu-0008I5-Ex for guix-patches@gnu.org; Thu, 04 Jul 2024 16:53:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#69074] [PATCH] Add python-angr. Resent-From: "jgart" Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Thu, 04 Jul 2024 20:53:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 69074 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: "=?UTF-8?Q?S=C3=B6ren?= Tempel" Cc: Troy Figiel , 69074@debbugs.gnu.org Received: via spool by 69074-submit@debbugs.gnu.org id=B69074.172012634631816 (code B ref 69074); Thu, 04 Jul 2024 20:53:02 +0000 Received: (at 69074) by debbugs.gnu.org; 4 Jul 2024 20:52:26 +0000 Received: from localhost ([127.0.0.1]:43186 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sPTRK-0008H5-8E for submit@debbugs.gnu.org; Thu, 04 Jul 2024 16:52:26 -0400 Received: from mx1.dismail.de ([78.46.223.134]:9119) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sPTRH-0008Gm-Eh for 69074@debbugs.gnu.org; Thu, 04 Jul 2024 16:52:24 -0400 Received: from mx1.dismail.de (localhost [127.0.0.1]) by mx1.dismail.de (OpenSMTPD) with ESMTP id 2fb8b44a; Thu, 4 Jul 2024 22:52:13 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed; d=dismail.de; h= mime-version:date:content-type:content-transfer-encoding:from :message-id:subject:to:cc:in-reply-to:references; s=20190914; bh=5pZv9UvtbiVgSYL1DwrAeNN3ovv0dZdGHk7gxew52Uw=; b=s46mh3EqeswR +iH1a/HKgGj0+S9LtFMgoxo7FL6uK2rnqGTRyUICi2kgpY6c+xtIg38nvhm5RFOB 48prOLokTCsQrftkz6TrIz0OMJt/rbBMAvGtU6h32k/eeyLrONkT/oqmOWI4e7Pu rg/ZQwsiAC7n1ZbztGqw2BF6NnLn7nDT07LEXi/Gg6WFstBeUWVXR+MLrM2beIyC ZAjKfzs49bIUiwZuFe1pvAB4Kl7Hh7HpPjInjX7KPC0p5/NAR29IKNxV7y2LSMu5 kqvLBjEtsx+Uju+Wqo5MKgyWxDTC0lTB9wbuRAk7DBptCXW6YMpvg0R62Vn7Duz/ sZcPtsRKDw== Received: from smtp1.dismail.de ( [10.240.26.11]) by mx1.dismail.de (OpenSMTPD) with ESMTP id 20d4729f; Thu, 4 Jul 2024 22:52:13 +0200 (CEST) Received: from smtp1.dismail.de (localhost [127.0.0.1]) by smtp1.dismail.de (OpenSMTPD) with ESMTP id 7da904cb; Thu, 4 Jul 2024 22:52:12 +0200 (CEST) Received: by dismail.de (OpenSMTPD) with ESMTPSA id 5b401105 (TLSv1.3:TLS_AES_256_GCM_SHA384:256:NO); Thu, 4 Jul 2024 22:52:12 +0200 (CEST) MIME-Version: 1.0 Date: Thu, 04 Jul 2024 20:52:11 +0000 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-ID: TLS-Required: No In-Reply-To: <3C16M9FD36BME.3EMO3MFHGE9NG@8pit.net> References: <87ikxltdfu.fsf@unknown72cc92733c3c.attlocal.net> <3C16M9FD36BME.3EMO3MFHGE9NG@8pit.net> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-to: jgart X-ACL-Warn: , jgart via Guix-patches From: jgart via Guix-patches via Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US X-Migadu-Spam-Score: -3.99 X-Spam-Score: -3.99 X-Migadu-Queue-Id: 5FEBF67032 X-Migadu-Scanner: mx11.migadu.com X-TUID: pZQS66zmZ7VY > Hi, thanks a lot for the response! I rebased the patch, the v3 now >=20 >=20applies cleanly on top of eeb24a50d2f1f78095bdb16b40ddb93bb51474bc wh= ich >=20 >=20is the current HEAD of the master branch. If you have any tips on mak= ing >=20 >=20this easier to review feel free to let me know. Hi, One tip I can provide is submitting smaller patch sets. Larger patch sets= require more review time investment so structuring your contributions sm= all bits at a time allows the reviewer to not be overwhelmed by the amoun= t of stuff they have to review in order to close the ticket. In addition to that, I would also say to make sure you run the linter on = all of your code to check for warnings and fix suggestions. That said, can you send a revision fixing the suggestions made by the lin= ter in the latest version of your patch set? Please add the linter fixes = grouped to their respective logical commit. all the best, jgart