unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: Hilton Chain via Guix-patches via <guix-patches@gnu.org>
To: 65413@debbugs.gnu.org
Cc: "Hilton Chain" <hako@ultrarare.space>, "Ludovic Courtès" <ludo@gnu.org>
Subject: [bug#65413] [PATCH] services: mcron: Add module for %user-log-dir.
Date: Mon, 21 Aug 2023 12:33:22 +0800	[thread overview]
Message-ID: <a6fdad6d07523a320eb682aa0b025573c4d66ed8.1692591833.git.hako@ultrarare.space> (raw)

* gnu/services/mcron.scm (mcron-shepherd-services)[modules]: Add
(shepherd support) for home service.
---

This patch fixes the following error:
  Loading /gnu/store/...-shepherd.conf.
  herd: error: exception caught while executing 'load' on service 'root':
  Unbound variable: %user-log-dir

I wasn't fully sure to report the issue in #65119 since the error didn't occur
in a home container, sorry for my hesitation.

 gnu/services/mcron.scm | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/gnu/services/mcron.scm b/gnu/services/mcron.scm
index db8b539ff5..efb7465549 100644
--- a/gnu/services/mcron.scm
+++ b/gnu/services/mcron.scm
@@ -165,6 +165,9 @@ (define (mcron-shepherd-services config)
                             (ice-9 popen) ;for the 'schedule' action
                             (ice-9 rdelim)
                             (ice-9 match)
+                            ,(if home-service?
+                                 '(shepherd support) ;for '%user-log-dir'
+                                 '())
                             ,@%default-modules))
                  (start #~(make-forkexec-constructor
                            (list #$(file-append mcron "/bin/mcron")

base-commit: 7cad70566322262f6acdbbb965e867e34010eb55
-- 
2.41.0





             reply	other threads:[~2023-08-21  4:36 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-08-21  4:33 Hilton Chain via Guix-patches via [this message]
2023-08-22 12:47 ` bug#65413: Close: [PATCH] services: mcron: Add module for %user-log-dir Hilton Chain via Guix-patches via
2023-08-22 15:21   ` [bug#65413] " Hilton Chain via Guix-patches via
2023-08-22 16:11 ` [bug#65413] " Ludovic Courtès

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=a6fdad6d07523a320eb682aa0b025573c4d66ed8.1692591833.git.hako@ultrarare.space \
    --to=guix-patches@gnu.org \
    --cc=65413@debbugs.gnu.org \
    --cc=hako@ultrarare.space \
    --cc=ludo@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).