From: Liliana Marie Prikler <liliana.prikler@gmail.com>
To: Jack Hill <jackhill@jackhill.us>
Cc: 52730@debbugs.gnu.org
Subject: [bug#52730] [PATCH] gnu: gst-plugins/selection: Make #:configure-flags optional.
Date: Fri, 24 Dec 2021 08:56:21 +0100 [thread overview]
Message-ID: <a4d48c487a9d1572b58bea5c0791d724d2a352a7.camel@gmail.com> (raw)
In-Reply-To: <alpine.DEB.2.21.2112240132370.9433@marsh.hcoop.net>
Hi Jack,
Am Freitag, dem 24.12.2021 um 01:37 -0500 schrieb Jack Hill:
> On Fri, 24 Dec 2021, Jack Hill wrote:
>
> I've looked at it for a little bit now, but I'm afraid that I'm
> stuck. I tried setting the default to #f (which may have been
> happening implicitly anyway):
Yes, if you don't supply an optional argument in Guile (or I guess in
Scheme generally), that argument gets #f as value.
> ```
> (define-public gst-plugins/selection
> (lambda* (pkg #:key plugins (configure-flags #f))
> "Build PKG with only PLUGINS enabled. Optionally, if CONFIGURE-
> FLAGS are
> given, also pass them to the build system instead of the ones used by
> PKG."
> (package/inherit pkg
> (arguments
> (substitute-keyword-arguments (package-arguments pkg)
> ((#:configure-flags flags `(,@(or configure-flags '())))
> `(append
> (list
> ,@(map (lambda (plugin)
> (string-append "-D" plugin "=enabled"))
> plugins))
> (list ,@(or configure-flags flags))))
> ((#:phases phases)
> `(modify-phases ,phases
> (add-after 'unpack 'disable-auto-plugins
> (lambda _
> (substitute* "meson_options.txt"
> (("'auto'") "'disabled'")))))))))))
> ```
>
> but that still gives me the "bad syntax in form quote" message. I can
> keep thinking about it, but if someone else knows the solution, I'd
> be happy to learn from you :)
I swear this used to work before the c-u-f merge. There might be a
problem mixing this with gexps or something I didn't account for back
then.
next prev parent reply other threads:[~2021-12-24 7:57 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-22 3:34 [bug#52730] [PATCH] gnu: gst-plugins/selection: Make #:configure-flags optional Jack Hill
2021-12-24 0:44 ` Liliana Marie Prikler
2021-12-24 5:17 ` Jack Hill
2021-12-24 6:37 ` Jack Hill
2021-12-24 7:56 ` Liliana Marie Prikler [this message]
2022-08-16 19:46 ` Liliana Marie Prikler
2024-01-22 16:36 ` Maxim Cournoyer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a4d48c487a9d1572b58bea5c0791d724d2a352a7.camel@gmail.com \
--to=liliana.prikler@gmail.com \
--cc=52730@debbugs.gnu.org \
--cc=jackhill@jackhill.us \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).