From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0 ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id UPFFD98dVmDRQwAA0tVLHw (envelope-from ) for ; Sat, 20 Mar 2021 16:07:59 +0000 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0 with LMTPS id IEknC98dVmBDWAAA1q6Kng (envelope-from ) for ; Sat, 20 Mar 2021 16:07:59 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 1FB361B4C8 for ; Sat, 20 Mar 2021 17:07:58 +0100 (CET) Received: from localhost ([::1]:51264 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lNe8q-0007Kz-SD for larch@yhetil.org; Sat, 20 Mar 2021 12:07:56 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:51202) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lNe7z-0006tJ-FX for guix-patches@gnu.org; Sat, 20 Mar 2021 12:07:03 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:41493) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lNe7y-00082u-FW for guix-patches@gnu.org; Sat, 20 Mar 2021 12:07:03 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1lNe7y-0002H5-9Z for guix-patches@gnu.org; Sat, 20 Mar 2021 12:07:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#47153] [PATCH v2] gnu: chez-scheme: Update nanopass to 1.9.2. Resent-From: Philip McGrath Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sat, 20 Mar 2021 16:07:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 47153 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Leo Prikler , 47153@debbugs.gnu.org Received: via spool by 47153-submit@debbugs.gnu.org id=B47153.16162563858575 (code B ref 47153); Sat, 20 Mar 2021 16:07:02 +0000 Received: (at 47153) by debbugs.gnu.org; 20 Mar 2021 16:06:25 +0000 Received: from localhost ([127.0.0.1]:53039 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lNe7N-0002ED-2y for submit@debbugs.gnu.org; Sat, 20 Mar 2021 12:06:25 -0400 Received: from mail-qk1-f176.google.com ([209.85.222.176]:41636) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lNe7K-0002DY-Bn for 47153@debbugs.gnu.org; Sat, 20 Mar 2021 12:06:23 -0400 Received: by mail-qk1-f176.google.com with SMTP id v70so6177339qkb.8 for <47153@debbugs.gnu.org>; Sat, 20 Mar 2021 09:06:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=philipmcgrath.com; s=google; h=from:subject:to:references:message-id:date:user-agent:mime-version :in-reply-to:content-language:content-transfer-encoding; bh=hPjTtKDCgVv1ZJB7LpThe7ZBfpNAqsxVzx3kTgRsDBM=; b=c61E/4F59gln5SnMinqg9s8DIm7rWW38DrOaHSyLLEtbEu/fXR//v6Mw6p7QxLVWw+ 8yYQV+LIiYwGLL+P0P/bvLYSQjYPh6sw2JYM66Fq2Gsa19OCmT/f1SrOsuLBsloE9AuO cZPbhjdGOKcXE7moydMiMnbKLFOPW2zDrUttbH45Nrkp8rqIFrDdKO0RY+X741Cs+BRX AvjAOcYWcTPNrEmU2tFypo8+jx3GyQKRNfK3uDP2o/ZftTQNyI62BLLiGIxTBuaoooP4 B5GUCJyDVHnxvAURmn+XR1wj6osjKYfYFVjLvQAiFON6xheI0d4vWB3MJK1ELm7IzF8D nU9Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:subject:to:references:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=hPjTtKDCgVv1ZJB7LpThe7ZBfpNAqsxVzx3kTgRsDBM=; b=gHnzpr40/q7CDPS5dYibfGYXncmcwNG4j4xjxEGR0zSnPGFrZ7b2qhvA5b66acc0Ro H+fDekSfFDHfPIWYcfcP5OyTjeTDGRMX5tGbXL13j7yJk9Fg/sFAMlWHP6oT4/mea2Uj dhaOzsLRROKMAkZJfdOHMHGQ/gjQiCaemTG8GS/8d7xoe3zC9vGvGMYRWc2P035oQiHk IJun/3FtoRlikfzQ6Y+2BVshfkprF++NvonfQ5i5Omdb7iP/KWTZW9xmEgACtKTWN758 8h7QqVyH1ozsG3Gf11LbzTzKKiiNs+nSW91SdgL9cwSqi32h5biMbC+F1MybqsO96HHF 6lag== X-Gm-Message-State: AOAM533aJoHeHgf6pavhk0ak8lLctZDW/vUsCa0/Ihz0n8CoRbQLIh3U rLeWlYwh9/EKPSpTnDj7zs/+L1YTnIybRVWlFNI= X-Google-Smtp-Source: ABdhPJwyAZ+ZAmabX6wqAtxZe/DzTMYbkrxMK/nGBRkNioJX8thFScvD1E7ZTneHUV3Q+isATPj6aw== X-Received: by 2002:a37:9bd2:: with SMTP id d201mr1803430qke.492.1616256376456; Sat, 20 Mar 2021 09:06:16 -0700 (PDT) Received: from Sapientia.local (c-73-125-89-242.hsd1.fl.comcast.net. [73.125.89.242]) by smtp.gmail.com with ESMTPSA id f9sm6738158qkk.115.2021.03.20.09.06.15 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 20 Mar 2021 09:06:16 -0700 (PDT) From: Philip McGrath References: <9581850ed011d311db0388fcda41f8fbcd479730.camel@student.tugraz.at> <20210315225302.6597-1-philip@philipmcgrath.com> <6e49888aaab2d2b2284d198eca51d0b9944be613.camel@student.tugraz.at> <5a4d612f-445a-e3f0-a3ff-7abd4b021f16@philipmcgrath.com> <5c833412d1ef4c9130c7f769a7d2c6d4270d7d36.camel@student.tugraz.at> Message-ID: Date: Sat, 20 Mar 2021 12:06:14 -0400 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.14; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 MIME-Version: 1.0 In-Reply-To: <5c833412d1ef4c9130c7f769a7d2c6d4270d7d36.camel@student.tugraz.at> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1616256479; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=hPjTtKDCgVv1ZJB7LpThe7ZBfpNAqsxVzx3kTgRsDBM=; b=V+LrIdJVqlVO0LgH5MfgddF69NBsNcvReRc3MZXu3BnhNXJhmbTmMXZk87S0HiTMt9emr5 DtdSqtIsPR183oKXSLm0VPQvXmdusowagKjFs9fbSAnWenhy1zMduzmdu+tt8U0h5n3ZI/ 0G5zv3Oi9wY7xVq6HKs7iatE6oYwr++TSdZZAPu6QDHisqGUl7Z0Cz3CzFzMxlR/VNH7gq cRVaZlDvYHjx2pxSalPzbPsVNhlG7EnfTJbwmRYNBu0V7S+Gj9eVB8MFHySIM1L/u6XId7 Q4pss3xYSy1WQWvfno0FrdAnNRkkzw9GKOuoUu0R6aEKKQJLKJTKiCkw0LWHZg== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1616256479; a=rsa-sha256; cv=none; b=Tc17UpUOHJQzOEfb17v1RDt8USRKg0+nUIWFJmVQow6HLR6tRNPQ89IyunB5RMc9TJyeFj z0T4QKTzvLAefhxhNWWzVbij4I5xIW0LF6KxkyYLXtBzKIM4ru+QNTFQrplXehTbs8SnOk CdepwsHO5NfWLDXpCuk097EbqfP2e8+yyhl1TwhUaIJrwwI3RSBE1WbZZOiOTqwJg0LzJQ buKQTWB4HK8BXL1cERZoL5jW8LAgCT2ovLwx3JT41DktGUsnc5NHHXFtUuJGTcn3dfxBVr hzEvlYjad2bHBDI8DcOOUN+SKSrU6/7gc/VJt72VyhpG27iqzVzNNQvfEE/ohg== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=philipmcgrath.com header.s=google header.b="c61E/4F5"; dmarc=none; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Spam-Score: -1.41 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=philipmcgrath.com header.s=google header.b="c61E/4F5"; dmarc=none; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Queue-Id: 1FB361B4C8 X-Spam-Score: -1.41 X-Migadu-Scanner: scn0.migadu.com X-TUID: /B3i4+SYnz3U Hi, On 3/16/21 5:09 PM, Leo Prikler wrote: > Am Dienstag, den 16.03.2021, 16:19 -0400 schrieb Philip McGrath: >> On 3/16/21 3:37 AM, Leo Prikler wrote: >>> Am Montag, den 15.03.2021, 18:53 -0400 schrieb Philip McGrath: >>>> - (sha256 (base32 >>>> "1synadgaycca39jfx525975ss9y0lkl516sdrc62wrrllamm8n21")) >>>> + (sha256 >>>> "16vjsik9rrzbabbhbxbaha51ppi3f9n8rk59pc6zdyffs0vziy4i") >>> You're inadvertently stripping away base32. >> >> I thought I'd read that explicitly calling base32 was redundant and I think I'd conflated multiple things in my memory. I see that the expansion of `package` applies the same special handling of the `sha256` field for a literal string as one wrapped with `base32` (recognized with `free-identifier=?`), including checking and conversion to a bytevector at compile time. >>>> + ;; When there's a new tagged release, >>>> + ;; go back to using (string-append "v" version) >>>> + (commit >>>> "54051494434a197772bf6ca5b4e6cf6be55f39a5"))) >>> Could we then not cherry-pick this commit as a patch? Or is there >>> more >>> needed? >> >> We could, but the upstream history is simply v1.2.2 -> my patch -> >> Kent >> Dybvig's merge commit accepting it. I thought doing it this way >> clarified that it's not a Guix-specific patch that should stay >> around >> indefinitely. Is there a reason to prefer cherry-picking it as a >> patch? > You'll probably hear differing opinions about that, and that's fine, > but my personal reason to prefer cherry-picking would be, that it makes > it very obvious, what changed from the base – that being the patch > modulo offset changes – and doesn't invite people to go out saying > "aha, but I found this commit and I like that more, let's take it". In > other words, this is very subjective, but I believe we should stick as > close to releases as is reasonable. I can understand that perspective. From my point of view, I'm inclined to see the release plus one upstream commit (the first commit since 2017) as closer to the release than a free-floating patch file: with a patch, I can see what has changed, but I need to evaluate why it was changed, if the change is still necessary, and so forth, rather than relying on the upstream maintainers' judgement. > I don't think we can necessarily trust the boot files in this > configuration. "They are bit-for-bit identical" can also mean, that > the login() hack was successfully applied for all you know. Yes, the "trusting trust" issues are especially striking if you consider that Chez Scheme was non-free software from 1984 to 2016, and the first libre release likewise needed the bootfiles of its ancestors. My point here was just to save space, from the perspective that these are build artifacts which can be easily recreated by anyone on a GNU/Linux system. But I don't think it's especially important, so I'm keeping them. I hope it might turn out to be possible eventually to bootstrap via Racket, maybe even by just picking an older version of the bootstrap code before the Racket fork's #!base-rtd gained a vector of ancestors rather than a parent and a few such things, but I think there's more to be done around Racket packaging before investigating that. -Philip