From: swedebugia <swedebugia@riseup.net>
To: Christopher Baines <mail@cbaines.net>, 34217@debbugs.gnu.org
Subject: [bug#34217] [PATCH 11/11] gnu: Add ruby-cucumber and ruby-aruba.
Date: Tue, 29 Jan 2019 22:44:55 +0100 [thread overview]
Message-ID: <a4192d92-44ba-2e56-bb19-ef972d444adc@riseup.net> (raw)
In-Reply-To: <20190127114956.26570-11-mail@cbaines.net>
[-- Attachment #1: Type: text/plain, Size: 2767 bytes --]
On 2019-01-27 12:49, Christopher Baines wrote:
> These packages are mutually dependant, so I've put them in one commit.
>
> * gnu/packages/ruby.scm (ruby-aruba, ruby-cucumber): New variables.
> ---
> gnu/packages/ruby.scm | 136 ++++++++++++++++++++++++++++++++++++++++++
> 1 file changed, 136 insertions(+)
>
> diff --git a/gnu/packages/ruby.scm b/gnu/packages/ruby.scm
> index e507c816c8..59895240f8 100644
> --- a/gnu/packages/ruby.scm
> +++ b/gnu/packages/ruby.scm
> @@ -32,6 +32,7 @@
> #:use-module ((guix licenses) #:prefix license:)
> #:use-module (gnu packages)
> #:use-module (gnu packages base)
> + #:use-module (gnu packages check)
> #:use-module (gnu packages compression)
> #:use-module (gnu packages databases)
> #:use-module (gnu packages dbm)
> @@ -3795,6 +3796,141 @@ It is intended be used by all Cucumber implementations to parse
> (home-page "https://github.com/cucumber-attic/gherkin")
> (license license:expat)))
>
> +(define-public ruby-aruba
> + (package
> + (name "ruby-aruba")
> + (version "0.14.7")
> + (source
> + (origin
> + (method url-fetch)
> + (uri (rubygems-uri "aruba" version))
> + (sha256
> + (base32
> + "0x27352n15dsyf5ak246znfawbrm502q15r4msjw3cis17jlcy1l"))))
> + (build-system ruby-build-system)
> + (arguments
> + '(;; TODO: There are a few test failures
> + ;; 357 examples, 7 failures
I investigated this and found:
Failed examples:
rspec ./spec/aruba/api_spec.rb:389 # Aruba::Api files #touch when
directory when exist and the mtim\
e should be set statically
rspec ./spec/aruba/api_spec.rb:388 # Aruba::Api files #touch when
directory when exist and the mtim\
e should be set statically behaves like an existing directory
rspec ./spec/aruba/api_spec.rb:362 # Aruba::Api files #touch when file
when does not exist and the \
mtime should be set statically
rspec ./spec/aruba/api_spec.rb:361 # Aruba::Api files #touch when file
when does not exist and the \
mtime should be set statically behaves like an existing file
rspec ./spec/aruba/matchers/command_spec.rb:165 # Command Matchers
#to_have_output_on_stderr when h\
ave output hello world on stderr
ave output hello world on stderr
rspec ./spec/aruba/matchers/command_spec.rb:128 # Command Matchers
#to_have_output_on_stdout when h\
ave output hello world on stderr
rspec ./spec/aruba/matchers/command_spec.rb:91 # Command Matchers
#to_have_output when have output \
hello world on stderr
The offending lines are in spec/aruba/api_spec.rb
beginning on line: 321, ending on 393
I tried creating a patch with diff for this file. I don't know if this
is the way others here usually create patches.
If not please enlighten me! :)
--
Cheers
Swedebugia
[-- Attachment #2: failed-test-ruby-aruba-api-spec.patch --]
[-- Type: text/x-patch, Size: 5388 bytes --]
321,393c321,393
< describe 'files' do
< describe '#touch' do
< let(:name) { @file_name }
< let(:path) { @file_path }
< let(:options) { {} }
<
< before :each do
< @aruba.set_environment_variable 'HOME', File.expand_path(@aruba.aruba.current_directory)
< end
<
< context 'when file' do
< before :each do
< @aruba.touch(name, options)
< end
<
< context 'when does not exist' do
< context 'and should be created in existing directory' do
< it { expect(File.size(path)).to eq 0 }
< it_behaves_like 'an existing file'
< end
<
< context 'and should be created in non-existing directory' do
< let(:name) { 'directory/test' }
< let(:path) { File.join(@aruba.aruba.current_directory, 'directory/test') }
<
< it_behaves_like 'an existing file'
< end
<
< context 'and path includes ~' do
< let(:string) { random_string }
< let(:name) { File.join('~', string) }
< let(:path) { File.join(@aruba.aruba.current_directory, string) }
<
< it_behaves_like 'an existing file'
< end
<
< context 'and the mtime should be set statically' do
< let(:time) { Time.parse('2014-01-01 10:00:00') }
< let(:options) { { :mtime => Time.parse('2014-01-01 10:00:00') } }
<
< it_behaves_like 'an existing file'
< it { expect(File.mtime(path)).to eq time }
< end
<
< context 'and multiple file names are given' do
< let(:name) { %w(file1 file2 file3) }
< let(:path) { %w(file1 file2 file3).map { |p| File.join(@aruba.aruba.current_directory, p) } }
< it_behaves_like 'an existing file'
< end
< end
< end
<
< context 'when directory' do
< let(:name) { %w(directory1) }
< let(:path) { Array(name).map { |p| File.join(@aruba.aruba.current_directory, p) } }
<
< context 'when exist' do
< before(:each) { Array(path).each { |p| Aruba.platform.mkdir p } }
<
< before :each do
< @aruba.touch(name, options)
< end
<
< context 'and the mtime should be set statically' do
< let(:time) { Time.parse('2014-01-01 10:00:00') }
< let(:options) { { :mtime => Time.parse('2014-01-01 10:00:00') } }
<
< it_behaves_like 'an existing directory'
< it { Array(path).each { |p| expect(File.mtime(p)).to eq time } }
< end
< end
< end
< end
---
> # describe 'files' do
> # describe '#touch' do
> # let(:name) { @file_name }
> # let(:path) { @file_path }
> # let(:options) { {} }
>
> # before :each do
> # @aruba.set_environment_variable 'HOME', File.expand_path(@aruba.aruba.current_directory)
> # end
>
> # context 'when file' do
> # before :each do
> # @aruba.touch(name, options)
> # end
>
> # context 'when does not exist' do
> # context 'and should be created in existing directory' do
> # it { expect(File.size(path)).to eq 0 }
> # it_behaves_like 'an existing file'
> # end
>
> # context 'and should be created in non-existing directory' do
> # let(:name) { 'directory/test' }
> # let(:path) { File.join(@aruba.aruba.current_directory, 'directory/test') }
>
> # it_behaves_like 'an existing file'
> # end
>
> # context 'and path includes ~' do
> # let(:string) { random_string }
> # let(:name) { File.join('~', string) }
> # let(:path) { File.join(@aruba.aruba.current_directory, string) }
>
> # it_behaves_like 'an existing file'
> # end
>
> # context 'and the mtime should be set statically' do
> # let(:time) { Time.parse('2014-01-01 10:00:00') }
> # let(:options) { { :mtime => Time.parse('2014-01-01 10:00:00') } }
>
> # it_behaves_like 'an existing file'
> # it { expect(File.mtime(path)).to eq time }
> # end
>
> # context 'and multiple file names are given' do
> # let(:name) { %w(file1 file2 file3) }
> # let(:path) { %w(file1 file2 file3).map { |p| File.join(@aruba.aruba.current_directory, p) } }
> # it_behaves_like 'an existing file'
> # end
> # end
> # end
>
> # context 'when directory' do
> # let(:name) { %w(directory1) }
> # let(:path) { Array(name).map { |p| File.join(@aruba.aruba.current_directory, p) } }
>
> # context 'when exist' do
> # before(:each) { Array(path).each { |p| Aruba.platform.mkdir p } }
>
> # before :each do
> # @aruba.touch(name, options)
> # end
>
> # context 'and the mtime should be set statically' do
> # let(:time) { Time.parse('2014-01-01 10:00:00') }
> # let(:options) { { :mtime => Time.parse('2014-01-01 10:00:00') } }
>
> # it_behaves_like 'an existing directory'
> # it { Array(path).each { |p| expect(File.mtime(p)).to eq time } }
> # end
> # end
> # end
> # end
next prev parent reply other threads:[~2019-01-29 21:46 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-27 11:06 [bug#34217] [PATCH 00/11] Add ruby-cucumber along with dependencies and a couple of updates Christopher Baines
2019-01-27 11:49 ` [bug#34217] [PATCH 01/11] gnu: Add ruby-cucumber-wire Christopher Baines
2019-01-27 11:49 ` [bug#34217] [PATCH 02/11] gnu: Add ruby-contracts Christopher Baines
2019-01-27 11:49 ` [bug#34217] [PATCH 03/11] gnu: Add ruby-ruby-progressbar Christopher Baines
2019-02-03 21:40 ` Björn Höfling
2019-02-08 18:58 ` Christopher Baines
2019-01-27 11:49 ` [bug#34217] [PATCH 04/11] gnu: Add ruby-fuubar Christopher Baines
2019-01-27 11:49 ` [bug#34217] [PATCH 05/11] gnu: Add ruby-cucumber-expressions Christopher Baines
2019-01-27 11:49 ` [bug#34217] [PATCH 06/11] gnu: Add ruby-mspec Christopher Baines
2019-01-27 11:49 ` [bug#34217] [PATCH 07/11] gnu: Add ruby-backports Christopher Baines
2019-01-31 8:53 ` swedebugia
2019-02-01 15:41 ` swedebugia
2019-02-08 19:10 ` Christopher Baines
2019-01-27 11:49 ` [bug#34217] [PATCH 08/11] gnu: Add ruby-cucumber-tag-expressions Christopher Baines
2019-01-27 11:49 ` [bug#34217] [PATCH 09/11] gnu: ruby-cucumber-core: Update to 3.2.1 Christopher Baines
2019-02-03 22:20 ` Björn Höfling
2019-02-08 18:48 ` Christopher Baines
2019-01-27 11:49 ` [bug#34217] [PATCH 10/11] gnu: ruby-gherkin: Update to 5.1.0 Christopher Baines
2019-01-27 11:49 ` [bug#34217] [PATCH 11/11] gnu: Add ruby-cucumber and ruby-aruba Christopher Baines
2019-01-29 21:44 ` swedebugia [this message]
2019-01-30 12:56 ` Ricardo Wurmus
2019-01-30 16:11 ` swedebugia
2019-01-30 16:22 ` swedebugia
2019-01-31 8:43 ` swedebugia
2019-02-08 18:46 ` Christopher Baines
2019-02-03 22:18 ` Björn Höfling
2019-02-03 23:26 ` Ricardo Wurmus
2019-02-08 17:19 ` Christopher Baines
2019-02-08 17:19 ` Christopher Baines
2019-02-08 19:02 ` Björn Höfling
2019-02-03 21:03 ` [bug#34217] [PATCH 01/11] gnu: Add ruby-cucumber-wire Björn Höfling
2019-02-08 19:05 ` Christopher Baines
2019-01-28 5:52 ` [bug#34217] [PATCH 00/11] Add ruby-cucumber along with dependencies and a couple of updates swedebugia
2019-02-03 22:21 ` Björn Höfling
2019-02-14 21:57 ` bug#34217: Ruby on Rails Christopher Baines
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a4192d92-44ba-2e56-bb19-ef972d444adc@riseup.net \
--to=swedebugia@riseup.net \
--cc=34217@debbugs.gnu.org \
--cc=mail@cbaines.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).