From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2 ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id AJlsCXNKu2BK4QAAgWs5BA (envelope-from ) for ; Sat, 05 Jun 2021 11:57:07 +0200 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2 with LMTPS id UL7OBHNKu2DDDQAAB5/wlQ (envelope-from ) for ; Sat, 05 Jun 2021 09:57:07 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id CD54429BBB for ; Sat, 5 Jun 2021 11:57:06 +0200 (CEST) Received: from localhost ([::1]:41562 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lpT3B-0008H0-Ds for larch@yhetil.org; Sat, 05 Jun 2021 05:57:05 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:50382) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lpT38-0008Gr-Bs for guix-patches@gnu.org; Sat, 05 Jun 2021 05:57:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:36792) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lpT38-0005ic-58 for guix-patches@gnu.org; Sat, 05 Jun 2021 05:57:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1lpT38-0004sm-35 for guix-patches@gnu.org; Sat, 05 Jun 2021 05:57:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#48319] [PATCH] Check if #:tests? is unconditionally #t; not acceptable when cross-compiling Resent-From: Maxime Devos Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sat, 05 Jun 2021 09:57:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 48319 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Mathieu Othacehe Cc: 48319@debbugs.gnu.org Received: via spool by 48319-submit@debbugs.gnu.org id=B48319.162288699618734 (code B ref 48319); Sat, 05 Jun 2021 09:57:02 +0000 Received: (at 48319) by debbugs.gnu.org; 5 Jun 2021 09:56:36 +0000 Received: from localhost ([127.0.0.1]:48338 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lpT2e-0004s2-PO for submit@debbugs.gnu.org; Sat, 05 Jun 2021 05:56:36 -0400 Received: from baptiste.telenet-ops.be ([195.130.132.51]:37298) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lpT2a-0004rp-37 for 48319@debbugs.gnu.org; Sat, 05 Jun 2021 05:56:32 -0400 Received: from ptr-bvsjgyjmffd7q9timvx.18120a2.ip6.access.telenet.be ([IPv6:2a02:1811:8c09:9d00:aaf1:9810:a0b8:a55d]) by baptiste.telenet-ops.be with bizsmtp id DMwS250040mfAB401MwS2L; Sat, 05 Jun 2021 11:56:26 +0200 Message-ID: From: Maxime Devos Date: Sat, 05 Jun 2021 11:56:25 +0200 In-Reply-To: <878s3peqtu.fsf@gnu.org> References: <878s3peqtu.fsf@gnu.org> Content-Type: multipart/signed; micalg="pgp-sha512"; protocol="application/pgp-signature"; boundary="=-ACjyrP8ZwYSxyvAW+oZK" User-Agent: Evolution 3.34.2 MIME-Version: 1.0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=telenet.be; s=r21; t=1622886986; bh=2VCfCYh2wCpFfY+6qE6fc1nxZ236tUCLtq8W+JtRlH8=; h=Subject:From:To:Cc:Date:In-Reply-To:References; b=HkzFZOIx3L8R7zjo9jpDgLvZu2OVup+ThPYX75TrKoNl2XjI8dnMwlcHqnYjmIvV2 nnEPUAM2KYzDtNxX40A5Kzf0xA/2FHmrHvtHpKxCV0V/Li+syZIOjqHW45SV1AF5DI /8I8X0G962odzXbB0ASwefTRdAMmkpCR0PN5xs3CAEBcTMXvrhUFZE3VqSR4JFkptO eR77GaUfWzFVE0THXxIs8BKfZyA4ReNwQk3ijLijL4jjH9KS5pJmQnafQQih5IRq8X huuvwoD2tzBvr39/glG3n7F1MEDkkO2fvcT0MsQQFxd3QwSW+DxPIZouXNQ9Lmq9PU B/nTnJyB/JvNQ== X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1622887026; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post: dkim-signature; bh=2VCfCYh2wCpFfY+6qE6fc1nxZ236tUCLtq8W+JtRlH8=; b=uVGYPq7hed8KQw/6tXneKK0o+o8XulBF5kRNQ5dji2lH7Z2s7jwR3Cz7BdkzhKl6Z4FeTq uchD741Vwaf9OU5D7yoSKHPIASwiDKnuLw/iWY9w7JMFyy8kVoDgtbAAvaNeTAL+X0sMYv xRV24jnCRtlyXOPEpys3FX3xTa6nwQPrD2IUKvxqGND9qjNUKqTn2zKwoFILRI2Yz1GBfq ZhDbAKPEUPh0M/lsAsmmxC0w/Tky8+093KQs7Ik73MDlvN0MZylp27fe323Gze9oyBapYm ceXrVsjKrzodhiHg/4eYWKrlU3gE81iUd5JcYq74JHCIhmOnOSausNGapkdJKw== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1622887026; a=rsa-sha256; cv=none; b=f8NLpdfu5D6rjJRiAXfF6sA6sTp7tDn75WFV+E1eNuQvijDeeYUbLmuf4XhhwzINNit8bI qTUCSlDy61X99m1IlafYVznQ0VUN5KknGJQCCdNBIu3IGbhxtAKaUgSxotPVFIp32hMNeH dYLNaf+gGZthZZXnH+ok6DWf/UNFDYEx89t1xxTHCtT9NLYmC6XhSPWhGNcjrCzKs3uc+k JKNrVfjvX+NTmLtVambCLOgDxJN7PmvElgubHu5NI+5gSodU+QHhc0N97KB2ppvvmeuNtr JJ20Hp9HlbTBDffmXf8Fi9wemoKC7bZJY1AwIwTpj1MoHOt0plP0LIg43Rgfew== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=telenet.be header.s=r21 header.b=HkzFZOIx; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Spam-Score: -3.43 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=telenet.be header.s=r21 header.b=HkzFZOIx; dmarc=fail reason="SPF not aligned (relaxed)" header.from=telenet.be (policy=none); spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Queue-Id: CD54429BBB X-Spam-Score: -3.43 X-Migadu-Scanner: scn0.migadu.com X-TUID: dYdX/2RkSO5T --=-ACjyrP8ZwYSxyvAW+oZK Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Mathieu Othacehe schreef op vr 04-06-2021 om 14:50 [+0200]: > Hello Maxime, >=20 > > + ;; TRANSLATORS: #:tests? and #t are Scheme c= onstants > > + ;; and must not be translated. > > + (G_ "#:tests? does not need to be explicitly= set to #t") > > + #:field 'arguments)) >=20 > This patch looks fine, and I remember fixing multiple packages failing > to cross-compile because #:tests was hard-coded to #t. >=20 > I'm not sure about the warning message though. What about: >=20 > "#:tests? must not be explicitly set to #t" >=20 > as "does not need" implies it could be sometimes correct, whereas it is > always a mistake. The new warning message "#:tests? must not be explicitly set to #t" seems reasonable to me. I'm currently working on other things though (guix and other things), so don't expect a revised patch soon. Greetings, Maxime. --=-ACjyrP8ZwYSxyvAW+oZK Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- iI0EABYKADUWIQTB8z7iDFKP233XAR9J4+4iGRcl7gUCYLtKSRccbWF4aW1lZGV2 b3NAdGVsZW5ldC5iZQAKCRBJ4+4iGRcl7mQmAQDrjya7FeZ4pZWYgEPrS02/i8/1 B0zOse6Wpg8WOX2XTwD/ZnotLo4DHuKauAD1qmOTq48oJt6kmKuM3Yc7Ifs+CQE= =tj3W -----END PGP SIGNATURE----- --=-ACjyrP8ZwYSxyvAW+oZK--