unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: Vasile Dumitrascu <va511e@yahoo.com>
To: Alex Kost <alezost@gmail.com>, Kei Kebreau <kei@openmailbox.org>
Cc: 26549@debbugs.gnu.org
Subject: bug#26549: [PATCH] gnu: Add emacs-google-maps.
Date: Sun, 23 Apr 2017 17:08:00 +0000	[thread overview]
Message-ID: <a26c4ddc-ea6d-22aa-3bf2-2865275747b0@yahoo.com> (raw)
In-Reply-To: <87zif89ssv.fsf@gmail.com>

[-- Attachment #1: Type: text/plain, Size: 1976 bytes --]

  Hi

You were correct. Please find attached the updated patch. Thank you,

  Vasile

Alex Kost:
> Kei Kebreau (2017-04-20 14:00 -0400) wrote:
> 
>> Vasile Dumitrascu <va511e@yahoo.com> writes:
>>
>>> * gnu/packages/emacs.scm (emacs-google-maps): New variable.
>>> ---
>>>  gnu/packages/emacs.scm | 19 +++++++++++++++++++
>>>  1 file changed, 19 insertions(+)
>>>
>>> diff --git a/gnu/packages/emacs.scm b/gnu/packages/emacs.scm
>>> index 673bbdf89..95298a0fa 100644
>>> --- a/gnu/packages/emacs.scm
>>> +++ b/gnu/packages/emacs.scm
>>> @@ -1229,6 +1229,25 @@ or XEmacs.")
>>>  the Emacs buffer.")
>>>      (license license:gpl3+)))
>>>  
>>> +(define-public emacs-google-maps
>>> +  (package
>>> +    (name "emacs-google-maps")
>>> +    (version "1.0.0")
>>> +    (source (origin
>>> +              (method url-fetch)
>>> +              (uri (string-append "https://github.com/jd/google-maps.el/"
>>> +                                  "archive/" version ".tar.gz"))
>>> +              (file-name (string-append name "-" version ".tar.gz"))
>>> +              (sha256
>>> +               (base32
>>> +                "014bxapm4d8vjxbzrfjdpsavxyfx981mlcb10aq5rmigr6il8ybs"))))
>>> +    (build-system emacs-build-system)
>>> +    (home-page "https://github.com/jd/google-maps.el")
>>> +    (synopsis "Access Google Maps from Emacs")
>>> +    (description "The @code{google-maps} package allows to display Google
>>> +Maps directly inside Emacs.")
>>> +    (license license:gpl1+)))
>>
>> I can't seem to find this license mentioned anywhere, but maybe I'm just
>> missing it. Where can I find it mentioned?
> 
> I think it should be gpl3+, as GPL3 or later is mentioned in the *.el files.
> 
>>> +
>>>  (define-public emacs-mmm-mode
>>>    (package
>>>      (name "emacs-mmm-mode")
>>
>> Other than finding the license, this patch looks fine.
> 
> I agree.  Vasile, could you resend this patch please, I can't apply it
> to the current master, not sure what the problem is.
> 

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-gnu-Add-emacs-google-maps.patch --]
[-- Type: text/x-patch; name="0001-gnu-Add-emacs-google-maps.patch", Size: 1488 bytes --]

From 2c30acfe9f2cfbe53bbf5d98b174a61ad6490e0f Mon Sep 17 00:00:00 2001
From: Vasile Dumitrascu <va511e@yahoo.com>
Date: Sun, 23 Apr 2017 18:53:57 +0200
Subject: [PATCH] gnu: Add emacs-google-maps.

* gnu/packages/emacs.scm (emacs-google-maps): New variable.
---
 gnu/packages/emacs.scm | 19 +++++++++++++++++++
 1 file changed, 19 insertions(+)

diff --git a/gnu/packages/emacs.scm b/gnu/packages/emacs.scm
index 47ea8d43a..14d851184 100644
--- a/gnu/packages/emacs.scm
+++ b/gnu/packages/emacs.scm
@@ -1230,6 +1230,25 @@ or XEmacs.")
 the Emacs buffer.")
     (license license:gpl3+)))
 
+(define-public emacs-google-maps
+  (package
+    (name "emacs-google-maps")
+    (version "1.0.0")
+    (source (origin
+              (method url-fetch)
+              (uri (string-append "https://github.com/jd/google-maps.el/"
+                                  "archive/" version ".tar.gz"))
+              (file-name (string-append name "-" version ".tar.gz"))
+              (sha256
+               (base32
+                "014bxapm4d8vjxbzrfjdpsavxyfx981mlcb10aq5rmigr6il8ybs"))))
+    (build-system emacs-build-system)
+    (home-page "https://github.com/jd/google-maps.el")
+    (synopsis "Access Google Maps from Emacs")
+    (description "The @code{google-maps} package allows to display Google
+Maps directly inside Emacs.")
+    (license license:gpl3+)))
+
 (define-public emacs-mmm-mode
   (package
     (name "emacs-mmm-mode")
-- 
2.11.0


  reply	other threads:[~2017-04-23 17:09 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-04-17 23:09 bug#26549: [PATCH] gnu: Add emacs-google-maps Vasile Dumitrascu
2017-04-20 18:00 ` Kei Kebreau
2017-04-22 18:54   ` Alex Kost
2017-04-23 17:08     ` Vasile Dumitrascu [this message]
2017-04-23 23:25       ` Kei Kebreau

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=a26c4ddc-ea6d-22aa-3bf2-2865275747b0@yahoo.com \
    --to=va511e@yahoo.com \
    --cc=26549@debbugs.gnu.org \
    --cc=alezost@gmail.com \
    --cc=kei@openmailbox.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).