unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: Liliana Marie Prikler <liliana.prikler@gmail.com>
To: Maxim Cournoyer <maxim.cournoyer@gmail.com>,
	Vivien Kraus <vivien@planete-kraus.eu>
Cc: rg@raghavgururajan.name, 69669@debbugs.gnu.org
Subject: [bug#69669] [PATCH gnome-team v2 0/3] Update girara (better)
Date: Sat, 09 Mar 2024 19:40:16 +0100	[thread overview]
Message-ID: <a255f6624762ebe84caba284457271700b044af5.camel@gmail.com> (raw)
In-Reply-To: <87frwzfftc.fsf@gmail.com>

Am Samstag, dem 09.03.2024 um 12:58 -0500 schrieb Maxim Cournoyer:
> Hello,
> 
> Vivien Kraus <vivien@planete-kraus.eu> writes:
> 
> > Dear guix,
> > 
> > I split the cosmetic changes, and also split the non-cosmetic
> > change in 2.
> > json-glib is an optional dependency, so girara can exist with and
> > without it.
> > 
> > You were right, pango is already propagated from gtk+.
> > 
> > I also reordered the fields, but it does not look very intuitive,
> > because it looks like I moved the arguments field up and the
> > native-inputs field down instead of moving native-inputs and
> > propagated-inputs down (thanks git).
> > Should I also split the style update?
> > 
> > Best regards,
> > 
> > Vivien
> > 
> > Vivien Kraus (3):
> >   gnu: girara: Update style.
> >   gnu: girara: Update to 0.4.3.
> >   gnu: girara: Build with json-glib.
> > 
> 
> Reviewed-by: Maxim Cournoyer <maxim.cournoyer@gmail>
Hi, I've went ahead and pushed 1 and 2.  For 3, I'd like you to clarify
whether we ought to use propagated-inputs now or how else to handle
this.

Cheers





      reply	other threads:[~2024-03-09 18:41 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-03-09  7:38 [bug#69669] [PATCH gnome-team 0/1] Update girara to 0.4.3 Vivien Kraus via Guix-patches via
2024-03-09  7:33 ` [bug#69669] [PATCH gnome-team 1/1] gnu: girara: Update " Vivien Kraus via Guix-patches via
2024-03-09  8:24   ` Liliana Marie Prikler
2024-03-09  8:58 ` [bug#69669] [PATCH gnome-team v3] gnu: girara: Build with json-glib Vivien Kraus via Guix-patches via
2024-03-12 13:28   ` Maxim Cournoyer
2024-03-16 11:05     ` Christopher Baines
2024-03-09  9:00 ` [bug#69669] [PATCH gnome-team v2 0/3] Update girara (better) Vivien Kraus via Guix-patches via
2024-03-09  7:33   ` [bug#69669] [PATCH gnome-team v2 2/3] gnu: girara: Update to 0.4.3 Vivien Kraus via Guix-patches via
2024-03-09  8:54   ` [bug#69669] [PATCH gnome-team v2 1/3] gnu: girara: Update style Vivien Kraus via Guix-patches via
2024-03-09  8:58   ` [bug#69669] [PATCH gnome-team v2 3/3] gnu: girara: Build with json-glib Vivien Kraus via Guix-patches via
2024-03-09 17:55     ` Maxim Cournoyer
2024-03-09 18:22       ` Vivien Kraus via Guix-patches via
2024-03-12  3:47         ` Maxim Cournoyer
2024-03-09  9:24   ` [bug#69669] [PATCH gnome-team v2 0/3] Update girara (better) Liliana Marie Prikler
2024-03-09 12:33     ` Vivien Kraus via Guix-patches via
2024-03-09 17:58   ` Maxim Cournoyer
2024-03-09 18:40     ` Liliana Marie Prikler [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=a255f6624762ebe84caba284457271700b044af5.camel@gmail.com \
    --to=liliana.prikler@gmail.com \
    --cc=69669@debbugs.gnu.org \
    --cc=maxim.cournoyer@gmail.com \
    --cc=rg@raghavgururajan.name \
    --cc=vivien@planete-kraus.eu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).