From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0.migadu.com ([2001:41d0:303:e16b::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms13.migadu.com with LMTPS id QGRbI2DJY2eScQEAqHPOHw:P1 (envelope-from ) for ; Thu, 19 Dec 2024 07:21:04 +0000 Received: from aspmx1.migadu.com ([2001:41d0:303:e16b::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0.migadu.com with LMTPS id QGRbI2DJY2eScQEAqHPOHw (envelope-from ) for ; Thu, 19 Dec 2024 08:21:04 +0100 X-Envelope-To: larch@yhetil.org Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=debbugs.gnu.org header.s=debbugs-gnu-org header.b=Rqph1Xpn; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20230601 header.b=TukM3iDu; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=gmail.com (policy=none) ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1734592863; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=g27M3iObPvhbrCTv91lyWvzbV6VPtZa19dTQmpnInAs=; b=F2c1qtyuJi8S4+y1bIMN7MdMXmfR+zWxK9H7jjxtGcteV5t0Y79BVbdx0k6wD0tF2LzRVt dfAKedTA/j2DLLd2sz0GzuFGuDZRP4mDMGCa+39pTwlqogdvASdsiiOdOU4RBsBfVEb0ky CZfxu9TqTyHpxY9WVYAfpXsPOaqsEUA4tyNGsF9kQQKXBrJXOr3Rswo6wX03vXe0aLl8PR rL8g/vdjzF0nVaxFM820sNC7T3FTDAUgyK3hCx838+BsyyYwtWrY57jfdWZGSFWECfEUT+ DWUqKDO3wyjbustYsnx6E0wNbr1dijj8l7oiwfZBLrGr8W0ZmduKkEzF+dienQ== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=pass header.d=debbugs.gnu.org header.s=debbugs-gnu-org header.b=Rqph1Xpn; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20230601 header.b=TukM3iDu; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=gmail.com (policy=none) ARC-Seal: i=1; s=key1; d=yhetil.org; t=1734592863; a=rsa-sha256; cv=none; b=IJTlDvMjMDwWJURUKFS1yl7XCFoK8c+2KM5OhnQAKYKOcQdIH4j+w5QYP9LQyR+2Q+HOKd ukfslZk1HZoazTMLBTuXD7r0xzv3u/yidHe3Lh16B22aCwZuiNc+jnrHLV3/86cluiqkNZ xza7u1o3vMGF+w6kwtHs7XY6ZKS1PRa+61ApTFRr+yBnZ29w6A+5zvf9Z9IKYKN32hP4Gg m7WP7zGepMaFdsCBd9QQdJiJunHh/zE8MLsX4nwrSFh+46FsWYdwXFYqq79S+0uBw13hDx qcZ4TdDbWvcgtsz2aC9GxVzRiCE3CNkwvzJP+JQ7CkDNEuffFb0KBqvCu3kdgw== Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 91363199F for ; Thu, 19 Dec 2024 08:21:03 +0100 (CET) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1tOApM-0004ad-6m; Thu, 19 Dec 2024 02:20:08 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tOApK-0004YF-9c for guix-patches@gnu.org; Thu, 19 Dec 2024 02:20:06 -0500 Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1tOApJ-00021g-Rv; Thu, 19 Dec 2024 02:20:05 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=MIME-Version:References:In-Reply-To:Date:From:To:Subject; bh=g27M3iObPvhbrCTv91lyWvzbV6VPtZa19dTQmpnInAs=; b=Rqph1Xpn1eI5oW09Xlr5ruZ5ydFkYmdOfsJF5O1zOiz37r9iTCmZDXmUlkx0DjphOFQKgtB9cTvIMyc5YBVT8W/EKkHpSwOBOdTaKqVFA+rnlus7NJMmkiVQRSJ0XJElOdbMNktpycj03X4UWIEyphA5h9aa1asnp8t/1448n3V+8yTafMAXoqyxX0MBc5aZITdl9fkAbxFs5tdfueCnWYtOnJ7fWE1AX7ZSvN5r3XzuQdp4IwPf2oPmnSiErWEaXrVl8IFt/7GT09bDbdvR5TwwB72HGga4SFL38u4rPfYLaVsKGxnK74zVc3YO9MIzo7LCYpLyOQ7vUraAnShpCg==; Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1tOApJ-0006tv-IS; Thu, 19 Dec 2024 02:20:05 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#74962] [PATCH 2/3] etc/guix-install.sh: Explicit shebang to use /usr/bin/env. Resent-From: Maxim Cournoyer Original-Sender: "Debbugs-submit" Resent-CC: janneke@gnu.org, dev@jpoiret.xyz, ludo@gnu.org, othacehe@gnu.org, guix-patches@gnu.org Resent-Date: Thu, 19 Dec 2024 07:20:05 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 74962 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 74962@debbugs.gnu.org Cc: Maxim Cournoyer , Janneke Nieuwenhuizen , Josselin Poiret , Ludovic =?UTF-8?Q?Court=C3=A8s?= , Mathieu Othacehe X-Debbugs-Original-Xcc: Janneke Nieuwenhuizen , Josselin Poiret , Ludovic =?UTF-8?Q?Court=C3=A8s?= , Mathieu Othacehe Received: via spool by 74962-submit@debbugs.gnu.org id=B74962.173459278426418 (code B ref 74962); Thu, 19 Dec 2024 07:20:05 +0000 Received: (at 74962) by debbugs.gnu.org; 19 Dec 2024 07:19:44 +0000 Received: from localhost ([127.0.0.1]:37220 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tOAoy-0006rw-BI for submit@debbugs.gnu.org; Thu, 19 Dec 2024 02:19:44 -0500 Received: from mail-pj1-f42.google.com ([209.85.216.42]:52271) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tOAow-0006rc-Fe for 74962@debbugs.gnu.org; Thu, 19 Dec 2024 02:19:43 -0500 Received: by mail-pj1-f42.google.com with SMTP id 98e67ed59e1d1-2efded08c79so333040a91.0 for <74962@debbugs.gnu.org>; Wed, 18 Dec 2024 23:19:42 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1734592716; x=1735197516; darn=debbugs.gnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=g27M3iObPvhbrCTv91lyWvzbV6VPtZa19dTQmpnInAs=; b=TukM3iDu77iUTIZMyyXpnmH7j/uAItgKW24nouq37sStnTbJ5E3UVd1guMxpItREN1 2t1rgj8ljuxUiZ/OgOzOSO6xDbUWutyCNMfD2LsdBfCU8ZKPvOBcvi44cNwaibTTTOcq Chyf1E12P/FyEFV/emnngy7Givr3tjy4+EYAkvgrRIOkQcl10M3THz7RdLWqe65x6coG 1rlvo419U6w+q0cQZpgiLc7kZ4vSMYpOfN+5l8ZGDnaPqHMsuNGWNdDCrKqqp1C6u98t IxFhyEd1E+m4ctzLjSK0Hup0zefgvsruEs80+FuX1jOt7vakrQ1TQg7SxNFqa6PKY1f2 0J4g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1734592716; x=1735197516; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=g27M3iObPvhbrCTv91lyWvzbV6VPtZa19dTQmpnInAs=; b=fyY/z4Q8eoVeb8bjWPobbQ1HfF0lsmba0eizqNzTiUKJ7xOWedk9CqnTLQIevcTFix dmuprvX3WIyLeZK+YkT3r2wtLToFExNese9MCZ6vU7kLv4kpp91j+S8uAW0FtwSKpV+C N0eWePqqovg4hitye8lgC59xMV2wBJdo6bE9Vu7NlnELMU97SHrQBCJbRvqJ8T7LTlpp /SF7uwR9T21A3k0CpQ7CRCuaLSX+BPEXwiyouVYFKGDynPkaWYsWeFgYAME1/nO4WnSh XN5FC8YP9qFaGZmGw3dUhoAwjRaFZkAltlXmk1PWpI56yj9TBGwk+un8DGljO2Vplx5m 458A== X-Gm-Message-State: AOJu0Yx1T+WkWd0yIrXe28aUKGvOl+r1KCdnFdqAHc6XzgRZ5eSHpJs9 aT9TkOBLnr3S+zWT9hd9sn3ZuJs7DpYfGCwiq+R9fAcPOs0ED6tw9xdeF3wKJdA= X-Gm-Gg: ASbGncu3hu8vCucjfhzQJlBmdLVvsNdK+JiS1ANYdEg9QP8DL3SWn5oMVhkbozmCG/y XHsADGqKLNn5dWcM6fTeey9YoGlkZRfPQNrD8kMplyicS3QCdqnpcSn4YOAXZzc3qe8dtOunB+I r0hujA2hwzHdmsvG774gD2/25JWm5rw9jRetaKCM54gd2yzP9GSITy8WhIpRwJDfX1OzSgpt2Oy iVvgbqNes9MScL5p8uLNxBGzxnRipI1IfIOl9iYBpcd9NVU45BO27i7f0h0PXmYYhgpDAOWklE= X-Google-Smtp-Source: AGHT+IGIhOeGzGe4R70NRiimOBfbgieRxj7Fq4SiE3p1SIPxmJz9XRiVjQklpsGR5KZuNLbr2rZbUg== X-Received: by 2002:a17:90b:2d43:b0:2ee:b8ac:73b4 with SMTP id 98e67ed59e1d1-2f443d5725cmr3051609a91.36.1734592716381; Wed, 18 Dec 2024 23:18:36 -0800 (PST) Received: from localhost.localdomain ([2405:6586:be0:0:c8ff:1707:9b9:af89]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-2f2ed8304absm2833241a91.24.2024.12.18.23.18.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 18 Dec 2024 23:18:35 -0800 (PST) From: Maxim Cournoyer Date: Thu, 19 Dec 2024 16:17:51 +0900 Message-ID: X-Mailer: git-send-email 2.46.0 In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Country: US X-Migadu-Flow: FLOW_IN X-Migadu-Scanner: mx13.migadu.com X-Migadu-Spam-Score: 0.97 X-Spam-Score: 0.97 X-Migadu-Queue-Id: 91363199F X-TUID: Tx8F+ULDAWcM Having an explicit shebang tells something useful: we depend on Bash. Tools such as shellcheck make use of it. The original technical reason for avoiding /usr/bin/env is no more (Guix System lacking it). * etc/guix-install.sh: Adjust shebang. Remove conditional 'exec bash' further block below. Change-Id: I3c92a9e58fe11610dfbf74dbbd4b1ac8852abcf0 --- etc/guix-install.sh | 15 ++++----------- 1 file changed, 4 insertions(+), 11 deletions(-) diff --git a/etc/guix-install.sh b/etc/guix-install.sh index f07b2741bb..481eb6f12a 100755 --- a/etc/guix-install.sh +++ b/etc/guix-install.sh @@ -1,4 +1,4 @@ -#!/bin/sh +#!/usr/bin/env bash # GNU Guix --- Functional package management for GNU # Copyright © 2017 sharlatan # Copyright © 2018 Ricardo Wurmus @@ -9,7 +9,7 @@ # Copyright © 2020 Daniel Brooks # Copyright © 2021 Jakub Kądziołka # Copyright © 2021 Chris Marusich -# Copyright © 2021, 2022, 2023 Maxim Cournoyer +# Copyright © 2021, 2022, 2023, 2024 Maxim Cournoyer # Copyright © 2022 Prafulla Giri # Copyright © 2023 Andrew Tropin # Copyright © 2020 David A. Redick @@ -31,10 +31,8 @@ # # You should have received a copy of the GNU General Public License # along with GNU Guix. If not, see . - -# We require Bash but for portability we'd rather not use /bin/bash or -# /usr/bin/env in the shebang, hence this hack. - +# +# # Environment variables # # GUIX_BINARY_FILE_NAME @@ -50,11 +48,6 @@ # installation required the user to extract Guix packs under /gnu to # satisfy its dependencies. -if [ "x$BASH_VERSION" = "x" ] -then - exec bash "$0" "$@" -fi - set -eo pipefail [ "$UID" -eq 0 ] || { echo "This script must be run as root."; exit 1; } -- 2.46.0