From: Maxim Cournoyer <maxim.cournoyer@gmail.com>
To: 65444@debbugs.gnu.org, maxim.cournoyer@gmail.com
Cc: "Christopher Baines" <guix@cbaines.net>,
"Josselin Poiret" <dev@jpoiret.xyz>,
"Ludovic Courtès" <ludo@gnu.org>,
"Mathieu Othacehe" <othacehe@gnu.org>,
"Ricardo Wurmus" <rekado@elephly.net>,
"Simon Tournier" <zimon.toutoune@gmail.com>,
"Tobias Geerinckx-Rice" <me@tobias.gr>
Subject: [bug#65444] [PATCH] gnu-maintenance: Improve check for disabled host names.
Date: Mon, 21 Aug 2023 16:56:21 -0400 [thread overview]
Message-ID: <a20a2de8e964dbc07cde94f7cadc2c923c6ec3b6.1692651381.git.maxim.cournoyer@gmail.com> (raw)
Found while investigating <https://issues.guix.gnu.org/65304>.
* guix/gnu-maintenance.scm (html-updatable-package?): Tighten predicate.
---
guix/gnu-maintenance.scm | 6 +++++-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/guix/gnu-maintenance.scm b/guix/gnu-maintenance.scm
index 32712f7218..5c16a7617d 100644
--- a/guix/gnu-maintenance.scm
+++ b/guix/gnu-maintenance.scm
@@ -846,7 +846,11 @@ (define html-updatable-package?
(let ((scheme (uri-scheme uri))
(host (uri-host uri)))
(and (memq scheme '(http https))
- (not (member host hosting-sites)))))))))
+ ;; HOST may contain prefixes,
+ ;; e.g. "profanity-im.github.io", hence the
+ ;; suffix-based test below.
+ (not (any (cut string-suffix? <> host)
+ hosting-sites)))))))))
(lambda (package)
(or (assoc-ref (package-properties package) 'release-monitoring-url)
base-commit: 4c7627dfec88350f9a1705e9527c38dd41506f8b
--
2.41.0
next reply other threads:[~2023-08-21 20:58 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-21 20:56 Maxim Cournoyer [this message]
2023-08-22 16:28 ` [bug#65444] [PATCH] gnu-maintenance: Improve check for disabled host names Ludovic Courtès
2023-08-25 14:08 ` bug#65444: " Maxim Cournoyer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a20a2de8e964dbc07cde94f7cadc2c923c6ec3b6.1692651381.git.maxim.cournoyer@gmail.com \
--to=maxim.cournoyer@gmail.com \
--cc=65444@debbugs.gnu.org \
--cc=dev@jpoiret.xyz \
--cc=guix@cbaines.net \
--cc=ludo@gnu.org \
--cc=me@tobias.gr \
--cc=othacehe@gnu.org \
--cc=rekado@elephly.net \
--cc=zimon.toutoune@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).