From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp12.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id oNpiLADxKWIA7gAAgWs5BA (envelope-from ) for ; Thu, 10 Mar 2022 13:37:20 +0100 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp12.migadu.com with LMTPS id MHOxKADxKWIOeQEAauVa8A (envelope-from ) for ; Thu, 10 Mar 2022 13:37:20 +0100 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 580F74339A for ; Thu, 10 Mar 2022 13:37:20 +0100 (CET) Received: from localhost ([::1]:39840 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nSI2g-0001n8-Kd for larch@yhetil.org; Thu, 10 Mar 2022 07:37:18 -0500 Received: from eggs.gnu.org ([209.51.188.92]:38558) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nSI2Q-0001l3-Az for guix-patches@gnu.org; Thu, 10 Mar 2022 07:37:02 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:39651) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nSI2Q-0003UI-1y for guix-patches@gnu.org; Thu, 10 Mar 2022 07:37:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1nSI2P-0001VX-Ob for guix-patches@gnu.org; Thu, 10 Mar 2022 07:37:01 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#49946] [WIP PATCH v3 00/26] gnu: Add tree-sitter for emacs (and neovim as well?). Resent-From: Maxime Devos Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Thu, 10 Mar 2022 12:37:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 49946 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Pierre Langlois Cc: Luis Henrique Gomes Higino , 49946@debbugs.gnu.org Received: via spool by 49946-submit@debbugs.gnu.org id=B49946.16469158055771 (code B ref 49946); Thu, 10 Mar 2022 12:37:01 +0000 Received: (at 49946) by debbugs.gnu.org; 10 Mar 2022 12:36:45 +0000 Received: from localhost ([127.0.0.1]:33548 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nSI29-0001V1-8T for submit@debbugs.gnu.org; Thu, 10 Mar 2022 07:36:45 -0500 Received: from michel.telenet-ops.be ([195.130.137.88]:52956) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nSI27-0001Uq-1H for 49946@debbugs.gnu.org; Thu, 10 Mar 2022 07:36:44 -0500 Received: from ptr-bvsjgyhxw7psv60dyze.18120a2.ip6.access.telenet.be ([IPv6:2a02:1811:8c09:9d00:3c5f:2eff:feb0:ba5a]) by michel.telenet-ops.be with bizsmtp id 4cch270034UW6Th06cchu0; Thu, 10 Mar 2022 13:36:41 +0100 Message-ID: From: Maxime Devos Date: Thu, 10 Mar 2022 13:36:35 +0100 In-Reply-To: <87zglykpmf.fsf@gmx.com> References: <87h7fztt60.fsf@gmx.com> <20210808233354.6745-1-pierre.langlois@gmx.com> <20210808233354.6745-7-pierre.langlois@gmx.com> <87czpwzg9e.fsf@gmx.com> <87leyinxly.fsf@gmx.com> <87lexl1goc.fsf@gmail.com> <87sfrrnpme.fsf@gmx.com> <24f64e912876f56fe40fbaeaec02ddd5e8ef2c4b.camel@telenet.be> <87zglykpmf.fsf@gmx.com> Content-Type: multipart/signed; micalg="pgp-sha512"; protocol="application/pgp-signature"; boundary="=-bz0xcgenH2MBAWxhK7xa" User-Agent: Evolution 3.38.3-1 MIME-Version: 1.0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=telenet.be; s=r22; t=1646915801; bh=MoFDw7KS0lqWEZ+LPc2hmzrch1N/hdHFC3HVk7F3HHQ=; h=Subject:From:To:Cc:Date:In-Reply-To:References; b=epN0naJw4N4AzQhsKZN3uSJpA9eCNxuIHv7aIHfPlw2Lhmtlhc+RJ7Q1fSNvYDSzF ItGlyhFToCUp6wqMEWWa414n60WLD7TskuWT1LAUkcEdx2rxx+rPfZTCsQhUjUXdiC ICvGicmDqVXwrh5cYaIZXMLKRvH82w3tbvlQdNMNn/FdvQEpK9YtMyDcKuGNVD3y9v Z9PpL+qpEcO0bY+FZvTBrBOPTTdPWB+YSWF0uf0w95yZfOjtDN9nJzrXmmc3CwyUs5 IILnOoKir7DqIhNwtHBsF22VuknvZlJG19BrLYtO+jFFrGhGd/4vcgS6z/awJgO4uo mwxTsTmGvl6Pw== X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1646915840; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post: dkim-signature; bh=MoFDw7KS0lqWEZ+LPc2hmzrch1N/hdHFC3HVk7F3HHQ=; b=DHDeZKDuTWmKACf9LurA7qq72oaSxsDbGA3grDHqF0VrHVZCfYQWMot0pjSF+3boMCJYcP RlNWmCipO1LOSjvkuU9dHHbW6DDeXoVjPYf2P4mIrPvuisTl91u/nNSEs3rKOFZnUiFRl8 BgLWZurz2cgQDwacfKW1n/qgMmpQBte5YDyB0sPt8CkuBlpYIONtUDdIMMFo0Y6yCXZ/0Z APNFCQmcoXu3R9rm9y/czu0qtL1DUsQho98RHqR2HLI//MzkjqrPnaUlwyqTDTkB+U/mbs qtkr3q6vFfq96rhvsZlbK8jYiXQsIIYK2rWmCd93Yl8ViRijnnoLGmT2yG7iPQ== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1646915840; a=rsa-sha256; cv=none; b=UFPjSMi7CGovk+g7YNDsTxPNnacxCdlDHVLqcL/iRWl7pP+bwbaA1H22TcxD6kO9HXWPIT 7/qy9weW142OnIVH3uCRT2b4R8zxqpI8dIhwef49lDmbYP7GlrzdsHRMqqUsdXKBhBW8On rEzhmgnYnT91O6E/XDXog8v3Z7/MDmPjZ+3Op3Bfx5WCYKF1RxkjXIwyFC7DvgQIqzrt0i DrCuz8P3JG+gYJW73VAWDzxZyocOhtejCDqe41FOfTXtphoMdW7LcSUFlwWbdiZSXl9MDC HEgkWm1dp5XUT1vopB1ORGeP8MjnJ1StuTX4S3lK5woUpSQaV1rcL3ibFv1Q9g== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=telenet.be header.s=r22 header.b=epN0naJw; dmarc=fail reason="SPF not aligned (relaxed)" header.from=telenet.be (policy=none); spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: 3.20 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=telenet.be header.s=r22 header.b=epN0naJw; dmarc=fail reason="SPF not aligned (relaxed)" header.from=telenet.be (policy=none); spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: 580F74339A X-Spam-Score: 3.20 X-Migadu-Scanner: scn0.migadu.com X-TUID: rjxOwRJJr7nF --=-bz0xcgenH2MBAWxhK7xa Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Pierre Langlois schreef op do 10-03-2022 om 11:17 [+0000]: > Before continuing to work on this build-system though, do you have > any > opinions about adding it to begin with?=C2=A0 As opposed to the current > approach of defining a base grammar package (see tree-sitter-c) and > have > the other grammar packages inherit from it.=C2=A0 I'm wondering if it's > worth > adding the build-system, when I don't think we should expect the > number > of grammars we would package to grow too much.=C2=A0 But then again, the > package definitions do look quite a bit nicer with the build-system, > so > I'm a bit on the fence about this :-). Build systems=C2=A0only cost a module or two, there are quite a few tree sitter packages (19 or so?) and the tree sitter packages have a lot in common (custom test phases, install phases), so I wouldn't hesitate to define a custom build system for tree-sitter stuff. Even better would be to unify things a bit more, e.g. it looks like tree-sitter-ocaml needs a custom 'install', 'build' and 'check' phase, but they looks almost the same as the other phases for other treesitter packages, so maybe 'tree-sitter-build-system' can be taught to mostly automatically determine the exact invocation? =20 Also, 'use-modules' only really works on the top-level, I recommend #:modules instead, there are some problems with using it in expression context (I don't think they are documented anywhere though). Greetings, Maxime --=-bz0xcgenH2MBAWxhK7xa Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- iI0EABYKADUWIQTB8z7iDFKP233XAR9J4+4iGRcl7gUCYinw0xccbWF4aW1lZGV2 b3NAdGVsZW5ldC5iZQAKCRBJ4+4iGRcl7p3ZAQDHSWusjpMwlDcrWyExpSyvUDj4 0uy5lRCgLpkHcC5KWgEAs/8hWfEvdUyqdi3XJFBEGxp523SHWM7oXAOjXbevNgU= =hmgu -----END PGP SIGNATURE----- --=-bz0xcgenH2MBAWxhK7xa--