From: julien lepiller <julien@lepiller.eu>
To: 30096@debbugs.gnu.org
Subject: [bug#30096] [PATCH 2/6] gnu: Add ocaml-integers.
Date: Fri, 19 Jan 2018 09:09:29 +0100 [thread overview]
Message-ID: <a18ec3ca004bce953ecab88ebdb5d57a@lepiller.eu> (raw)
In-Reply-To: <87a7xaifb3.fsf@gmail.com>
Le 2018-01-19 06:32, Peter Kreye a écrit :
> Julien,
>
> Thank you for all of the feedback, it is much appreciated.
>
> Julien Lepiller writes:
>
>> Actually, I forgot to ask, why disable tests?
>>
>> That's the same question for the rest of your patches too.
>
> This package doesn't have any tests, which seems to be causing the
> 'check
> phase to fail. Would it be better to use "#:tests? #f" or to delete the
> 'check phase?
I think it's better to use #:tests? #f and leave a comment to explain
the reason, so:
#:tests? #f; no test suite
Since you disable tests in all your patches, could you leave a comment
in each of them
to explain why it is disabled?
>
>> You don't need to replace the 'build phase. ocaml-build-system can
>> find
>> pkg/pkg.ml. You just need to use #:build-flags (list "build") to add
>> arguments.
>>
>> That applies also to the rest of your patches.
>
> Thank you for this info. I'll make sure to do this from now on.
>
>> It's probably better to use "#:findlib ,ocaml-findlib-1.7.3" in the
>> arguments list.
>
> Same.
>
> --
Thank you, I'll push your patches as soon as you send a new version.
next prev parent reply other threads:[~2018-01-19 8:10 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-13 11:05 [bug#30096] Update ocaml-findlib; Add ocaml-tsdl and dependencies Peter Kreye
2018-01-13 11:14 ` [bug#30096] [PATCH 1/6] gnu: ocaml-findlib-1.7.3: Fix install Peter Kreye
2018-01-13 11:14 ` [bug#30096] [PATCH 2/6] gnu: Add ocaml-integers Peter Kreye
2018-01-13 12:57 ` Julien Lepiller
2018-01-13 13:08 ` Julien Lepiller
2018-01-19 5:32 ` Peter Kreye
2018-01-19 8:09 ` julien lepiller [this message]
2018-01-13 11:24 ` [bug#30096] [PATCH 3/6] gnu: Add ocaml-ctypes Peter Kreye
2018-01-13 12:59 ` Julien Lepiller
2018-01-19 5:52 ` Peter Kreye
2018-01-28 22:35 ` Ludovic Courtès
2018-01-13 11:25 ` [bug#30096] [PATCH 4/6] gnu: Add ocaml-ocb-stubblr Peter Kreye
2018-01-13 13:10 ` Julien Lepiller
2018-01-13 11:26 ` [bug#30096] [PATCH 5/6] gnu: Add ocaml-tsdl Peter Kreye
2018-01-13 13:16 ` Julien Lepiller
2018-01-13 11:27 ` [bug#30096] [PATCH 6/6] gnu: ocaml-findlib: Update to 1.7.3 Peter Kreye
2018-01-13 13:18 ` Julien Lepiller
2018-01-13 18:10 ` Leo Famulari
2018-01-16 14:30 ` Ludovic Courtès
2018-02-01 22:12 ` bug#30096: Update ocaml-findlib; Add ocaml-tsdl and dependencies Julien Lepiller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a18ec3ca004bce953ecab88ebdb5d57a@lepiller.eu \
--to=julien@lepiller.eu \
--cc=30096@debbugs.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).