From: Maxime Devos <maximedevos@telenet.be>
To: public@yoctocell.xyz, 48923@debbugs.gnu.org
Subject: [bug#48923] [PATCH] build: utils: Add ‘call-with-outp
Date: Tue, 08 Jun 2021 18:04:40 +0200 [thread overview]
Message-ID: <a0972b8b687b465ceb341454a6a01a16bf4a444a.camel@telenet.be> (raw)
In-Reply-To: <23ac66d29119c5395fee0e993ea0fe811beefd91.1623166798.git.public@yoctocell.xyz>
[-- Attachment #1: Type: text/plain, Size: 695 bytes --]
Xinglu Chen schreef op di 08-06-2021 om 17:40 [+0200]:
> Using ‘call-with-output-file*’ instead of ‘call-with-output-file’ and ‘chmod’
> will prevent secrets from being leaked. See
> <https://issues.guix.gnu.org/48872>;.
This procedure LGTM (but I didn't test).
However,
> diff --git a/guix/build/utils.scm b/guix/build/utils.scm
> index 419c10195b..df960eee84 100644
> --- a/guix/build/utils.scm
> +++ b/guix/build/utils.scm
> @@ -5,6 +5,7 @@
Modifying (guix build utils) entails a world-rebuild, as
(guix build utils) is used by the build code of practically
every package. I would suggest placing it in (gnu build activation)
instead.
Greetings,
Maxime.
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 260 bytes --]
next prev parent reply other threads:[~2021-06-08 16:05 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-08 15:40 [bug#48923] [PATCH] build: utils: Add ‘call-with-outp Xinglu Chen
2021-06-08 16:04 ` Maxime Devos [this message]
2021-06-08 17:36 ` Xinglu Chen
2021-06-08 17:45 ` Maxime Devos
2021-06-08 18:04 ` Xinglu Chen
2021-06-08 18:30 ` [bug#48923] [PATCH v2] activation: Add ‘call-with-output-file*’ procedure Xinglu Chen
2021-08-04 8:25 ` Xinglu Chen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a0972b8b687b465ceb341454a6a01a16bf4a444a.camel@telenet.be \
--to=maximedevos@telenet.be \
--cc=48923@debbugs.gnu.org \
--cc=public@yoctocell.xyz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).