unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: Steve George <steve@futurile.net>
To: 72666@debbugs.gnu.org
Subject: [bug#72666] Add firely-synth package to Guix
Date: Thu, 31 Oct 2024 10:54:33 +0000	[thread overview]
Message-ID: <ZyNh6Y2KXm_Zrj15@dragon2> (raw)
In-Reply-To: <O4PmCjA--B-9@tuta.io>

Hi,

You sent a patch to add firefly-synth, a couple of things:

1. Looks like there's a new release, can you update the patch?
  https://github.com/sjoerdvankreel/firefly-synth/releases/tag/v1.9.6

2. You added it to the end of music.scm please don't put it there as it makes
diffs more difficult. See if there's an alphabetical location in the file if at all possible.

3. Please send patches 'in-line' so that the automated QA system can pick them up.
I think the manual now has an updated section on how to use git send-email which might help.

https://guix.gnu.org/manual/devel/en/html_node/Sending-a-Patch-Series.html#Single-Patches-1

Thanks,

Futurile




      reply	other threads:[~2024-10-31 10:58 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-08-16 10:43 [bug#72666] [PATCH] Add firefly-synth package Apoorv via Guix-patches via
2024-10-31 10:54 ` Steve George [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZyNh6Y2KXm_Zrj15@dragon2 \
    --to=steve@futurile.net \
    --cc=72666@debbugs.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).