From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1.migadu.com ([2001:41d0:303:e16b::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms13.migadu.com with LMTPS id KBZRIDJbH2ciawEA62LTzQ:P1 (envelope-from ) for ; Mon, 28 Oct 2024 09:36:50 +0000 Received: from aspmx1.migadu.com ([2001:41d0:303:e16b::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1.migadu.com with LMTPS id KBZRIDJbH2ciawEA62LTzQ (envelope-from ) for ; Mon, 28 Oct 2024 10:36:50 +0100 X-Envelope-To: larch@yhetil.org Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=debbugs.gnu.org header.s=debbugs-gnu-org header.b=XzaVlji+; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1730108210; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post: dkim-signature; bh=vCpMFzm0k3NMg6ra77LFdHZMl/OXcJycs8sO+jf3o5E=; b=ZMHCAPyvafGqcaIXX+XlMH5z1InS+GNNBikfjdh04fL6jCXnpLg4uVxTLugerTGH24IKDk FgKi+ENye3dsGIMFBjqzyYFd6D41MS1RX2smKp1cXk+FJE6qNhBh78+ZcMsQxPlGCOwIV0 XGDJ5bIP48oB7lCn0KqqbCMAbxKCW3AikOt+W/Vn1KWAn2xIWpoc/WvoeFsT5j6sg3N75r E7QRMGOm0hG7tP1PZ+RwPsVWnzzs7Xdv9zNs3Xlk8VRF58fSYJPIsWKIUD2T7ZVbDdSXvm gl8QPysbdfAGMuyYOnMp1oRQdHLhsgUysIcJMj76YGsBsS8tFJdwJK9kqOZyNQ== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1730108210; a=rsa-sha256; cv=none; b=rOsEZ3KKmo8O3OHE/adzksSr1AK7W+xYplmH9B8vsdQC/dSu5EHOXhD+H/wbo2Wx1WbXFT PCzXp4xdh4jqT1rXLA3u/k64eZVby7s33W7E37BaP+X1Nn/n23zsCUkR5BSusuzBBR/EZ6 Bki5sDBU9qOjAVYlNchazcUJky2cWI7rOqY9M0SIFlSiHOFGeNz4GAriyp/t1Oza22PcxS s2qKT6j+F33nd22yzPyvPeqiDc7NIPovLWARADYou1kYp+p2HjSufpJW2C4A0Goa9CWDsl 6QnR1cFFwXLPJ8rkSS9bWNhhDgR/ChI9kHflU0qZKOVjDwDtCXvsCkvawh/vDQ== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=pass header.d=debbugs.gnu.org header.s=debbugs-gnu-org header.b=XzaVlji+; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=none Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 5FEA1520D4 for ; Mon, 28 Oct 2024 10:36:50 +0100 (CET) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1t5MAp-0002P6-52; Mon, 28 Oct 2024 05:36:32 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1t5MAk-0002OZ-QK for guix-patches@gnu.org; Mon, 28 Oct 2024 05:36:27 -0400 Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1t5MAk-0000pj-ED for guix-patches@gnu.org; Mon, 28 Oct 2024 05:36:26 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=MIME-Version:From:Date:To:In-Reply-To:References:Subject; bh=vCpMFzm0k3NMg6ra77LFdHZMl/OXcJycs8sO+jf3o5E=; b=XzaVlji+IuJBrPVCrKmS9IZlqLrJBAJkQibaOcMvfpcaxLqNu7jyTMH2KmJui/Gk4Lgeo7fCdk6f1PwSR09/TdaNRJcKy41XaIbzmObn1+aWD1f2j9CQTxuEcs7P/qBQbP3sWuLWqFKWGHVSLPY1R6/R6GBsOcguzytNiXCk4MVEO4Nn7uKZaIgUD2/NYfnvz38dTdQTUAYeEJApRX+JpKExJcTR67t2HvZHNi7REKz26ZQnS3l3ohTG04badcdPnBv5PdNChejV2QBfijWQhYz4arC1tF/G8wzTojBoiV7kBXhYcRrvEtQyJC69Bm7Oh9q4TS21yntscg8kFGFCjQ==; Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1t5MBJ-0006Fr-W3 for guix-patches@gnu.org; Mon, 28 Oct 2024 05:37:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#74039] Comments References: In-Reply-To: Resent-From: Andreas Enge Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Mon, 28 Oct 2024 09:37:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 74039 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: To: 74039@debbugs.gnu.org Received: via spool by 74039-submit@debbugs.gnu.org id=B74039.173010817423981 (code B ref 74039); Mon, 28 Oct 2024 09:37:01 +0000 Received: (at 74039) by debbugs.gnu.org; 28 Oct 2024 09:36:14 +0000 Received: from localhost ([127.0.0.1]:52546 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1t5MAY-0006Ej-0z for submit@debbugs.gnu.org; Mon, 28 Oct 2024 05:36:14 -0400 Received: from hera.aquilenet.fr ([185.233.100.1]:59560) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1t5MAU-0006ES-LR for 74039@debbugs.gnu.org; Mon, 28 Oct 2024 05:36:12 -0400 Received: from localhost (localhost [127.0.0.1]) by hera.aquilenet.fr (Postfix) with ESMTP id 9711A1A8B; Mon, 28 Oct 2024 10:35:28 +0100 (CET) X-Virus-Scanned: Debian amavisd-new at hera.aquilenet.fr Received: from hera.aquilenet.fr ([127.0.0.1]) by localhost (hera.aquilenet.fr [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id cwh3GEE3Le0X; Mon, 28 Oct 2024 10:35:28 +0100 (CET) Received: from jurong (unknown [IPv6:2001:861:c4:f2f0::c64]) by hera.aquilenet.fr (Postfix) with ESMTPSA id 164FD375; Mon, 28 Oct 2024 10:35:28 +0100 (CET) Date: Mon, 28 Oct 2024 10:35:26 +0100 From: Andreas Enge Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US X-Migadu-Spam-Score: -4.19 X-Spam-Score: -4.19 X-Migadu-Queue-Id: 5FEA1520D4 X-Migadu-Scanner: mx13.migadu.com X-TUID: 7RAJODPb9/A4 Hello Jesse, thanks for your contribution, which passes QA and looks mainly good! QA runs "guix lint": https://qa.guix.gnu.org/issue/74039 which complains about the following: "the source file name should contain the package name" Maybe you could run "guix lint" on your different packages and see to which one it applies? Probably python-bip32 with its source taken from git. Maybe you could use pypi there as well? When trying a "guix import pypi bip32" I get a version 4.0 instead of 3.2; would this work as well? Otherwise, there are examples in the Guix source of how to force a descriptive name for the git checkout. The description should consist of complete sentences and be a bit longer and more descriptive, maybe a short paragraph. Often it can be taken from the project website, after stripping out the marketing speech. Please also adapt the commit messages to the Guix style. Running "./etc/committer.scm" (instead of "git commit") could be an option, it usually works well for adding new packages. Looking forward to a v3, Andreas