unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: Efraim Flashner <efraim@flashner.co.il>
To: Suhail Singh <suhailsingh247@gmail.com>
Cc: "Josselin Poiret" <dev@jpoiret.xyz>,
	"Simon Tournier" <zimon.toutoune@gmail.com>,
	73434@debbugs.gnu.org, "Mathieu Othacehe" <othacehe@gnu.org>,
	"Ludovic Courtès" <ludo@gnu.org>,
	"Tobias Geerinckx-Rice" <me@tobias.gr>,
	"Christopher Baines" <guix@cbaines.net>
Subject: [bug#73434] [PATCH] lint: Check for minimal variants.
Date: Tue, 24 Sep 2024 10:16:37 +0300	[thread overview]
Message-ID: <ZvJnVdpJRmLiD5me@3900XT> (raw)
In-Reply-To: <87h6a6ihqh.fsf@gmail.com>

[-- Attachment #1: Type: text/plain, Size: 740 bytes --]

On Mon, Sep 23, 2024 at 10:09:58AM -0400, Suhail Singh wrote:
> Efraim Flashner <efraim@flashner.co.il> writes:
> 
> > +(define (check-inputs-should-use-a-minimal-variant package)
> > +  ;; Emit a warning if some inputs of PACKAGE should likely be replaced
> > +  ;; with their minimal variant.
> 
> Should this have been a docstring instead?

I copied the procedure immediately above it and then made changes.
Looking at the other procedures, yes, it looks like it should be a
docstring.  I've changed it locally.

-- 
Efraim Flashner   <efraim@flashner.co.il>   רנשלפ םירפא
GPG key = A28B F40C 3E55 1372 662D  14F7 41AA E7DC CA3D 8351
Confidentiality cannot be guaranteed on emails sent or received unencrypted

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

  reply	other threads:[~2024-09-24  7:18 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-09-23  7:56 [bug#73434] [PATCH] lint: Check for minimal variants Efraim Flashner
2024-09-23 14:09 ` Suhail Singh
2024-09-24  7:16   ` Efraim Flashner [this message]
     [not found] ` <handler.73434.B.172707834516907.ack@debbugs.gnu.org>
2024-09-29 16:11   ` bug#73434: Acknowledgement ([PATCH] lint: Check for minimal variants.) Efraim Flashner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZvJnVdpJRmLiD5me@3900XT \
    --to=efraim@flashner.co.il \
    --cc=73434@debbugs.gnu.org \
    --cc=dev@jpoiret.xyz \
    --cc=guix@cbaines.net \
    --cc=ludo@gnu.org \
    --cc=me@tobias.gr \
    --cc=othacehe@gnu.org \
    --cc=suhailsingh247@gmail.com \
    --cc=zimon.toutoune@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).