* [bug#72957] [PATCH] gnu: Add bin-graph.
@ 2024-09-02 9:57 Artyom V. Poptsov
2024-09-04 2:43 ` Zheng Junjie
` (3 more replies)
0 siblings, 4 replies; 6+ messages in thread
From: Artyom V. Poptsov @ 2024-09-02 9:57 UTC (permalink / raw)
To: 72957; +Cc: Artyom V. Poptsov, Leo Famulari, Wilko Meyer
* gnu/packages/linux.scm (bin-graph): New variable.
Change-Id: I7405cbc00e038d024d035fb100473352c9a7b59d
---
gnu/packages/linux.scm | 37 +++++++++++++++++++++++++++++++++++++
1 file changed, 37 insertions(+)
diff --git a/gnu/packages/linux.scm b/gnu/packages/linux.scm
index 318c6ccf13..38f3d6fc2f 100644
--- a/gnu/packages/linux.scm
+++ b/gnu/packages/linux.scm
@@ -1776,6 +1776,43 @@ (define-public bbswitch-module
graphics card on Optimus laptops.")
(license license:gpl2))))
+(define-public bin-graph
+ ;; XXX: The upstream does not have tags yet.
+ (let ((commit "1dd42e3e8e123e993d6c287967502c8d4b36f9ba")
+ (revision "0"))
+ (package
+ (name "bin-graph")
+ (version (git-version "0.0.0" revision commit))
+ (source
+ (origin
+ (method git-fetch)
+ (uri (git-reference
+ (url "https://github.com/8dcc/bin-graph")
+ (commit commit)))
+ (file-name (git-file-name name version))
+ (sha256
+ (base32 "1wjkl789r7iys3nnyk813gsdxwwy2ryxgxirx5xw02lzk790dywl"))))
+ (arguments
+ (list #:tests? #f ; no tests
+ #:make-flags
+ #~(list (string-append "CC=" #$(cc-for-target))
+ (string-append "PREFIX=" #$output))
+ #:phases
+ #~(modify-phases %standard-phases
+ (delete 'configure)
+ (replace 'install
+ (lambda _
+ (install-file "bin-graph"
+ (string-append #$output "/bin")))))))
+ (build-system gnu-build-system)
+ (inputs (list libpng))
+ (home-page "https://github.com/8dcc/bin-graph")
+ (synopsis "Visualize binary files")
+ (description
+ "@code{bin-graph} provides a simple way of visualizing the different regions
+of a binary file.")
+ (license license:gpl3))))
+
(define-public ddcci-driver-linux
(package
(name "ddcci-driver-linux")
base-commit: a977900d76b7585c401222a3ce8bbb82e5f6da45
--
2.45.2
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [bug#72957] [PATCH] gnu: Add bin-graph.
2024-09-02 9:57 [bug#72957] [PATCH] gnu: Add bin-graph Artyom V. Poptsov
@ 2024-09-04 2:43 ` Zheng Junjie
2024-09-04 7:46 ` Artyom V. Poptsov
2024-09-04 7:40 ` [bug#72957] [PATCH v2] " Artyom V. Poptsov
` (2 subsequent siblings)
3 siblings, 1 reply; 6+ messages in thread
From: Zheng Junjie @ 2024-09-04 2:43 UTC (permalink / raw)
To: Artyom V. Poptsov; +Cc: Wilko Meyer, 72957, Leo Famulari
[-- Attachment #1: Type: text/plain, Size: 2583 bytes --]
"Artyom V. Poptsov" <poptsov.artyom@gmail.com> writes:
maybe gnu/packages/graph.scm better here
> * gnu/packages/linux.scm (bin-graph): New variable.
>
> Change-Id: I7405cbc00e038d024d035fb100473352c9a7b59d
> ---
> gnu/packages/linux.scm | 37 +++++++++++++++++++++++++++++++++++++
> 1 file changed, 37 insertions(+)
>
> diff --git a/gnu/packages/linux.scm b/gnu/packages/linux.scm
> index 318c6ccf13..38f3d6fc2f 100644
> --- a/gnu/packages/linux.scm
> +++ b/gnu/packages/linux.scm
> @@ -1776,6 +1776,43 @@ (define-public bbswitch-module
> graphics card on Optimus laptops.")
> (license license:gpl2))))
>
> +(define-public bin-graph
> + ;; XXX: The upstream does not have tags yet.
> + (let ((commit "1dd42e3e8e123e993d6c287967502c8d4b36f9ba")
> + (revision "0"))
> + (package
> + (name "bin-graph")
> + (version (git-version "0.0.0" revision commit))
> + (source
> + (origin
> + (method git-fetch)
> + (uri (git-reference
> + (url "https://github.com/8dcc/bin-graph")
> + (commit commit)))
> + (file-name (git-file-name name version))
> + (sha256
> + (base32 "1wjkl789r7iys3nnyk813gsdxwwy2ryxgxirx5xw02lzk790dywl"))))
> + (arguments
> + (list #:tests? #f ; no tests
> + #:make-flags
> + #~(list (string-append "CC=" #$(cc-for-target))
> + (string-append "PREFIX=" #$output))
see https://github.com/8dcc/bin-graph/blob/f5c53c427248d3fe10c1c921ea134f4592fbe8b7/Makefile#L10C1-L10C12
when use (string-append "INSTALL_DIR=" #$output "/bin") , not need to
replace install phase.
> + #:phases
> + #~(modify-phases %standard-phases
> + (delete 'configure)
please add a comment, ; no configure script
> + (replace 'install
> + (lambda _
> + (install-file "bin-graph"
> + (string-append #$output "/bin")))))))
> + (build-system gnu-build-system)
> + (inputs (list libpng))
> + (home-page "https://github.com/8dcc/bin-graph")
> + (synopsis "Visualize binary files")
> + (description
> + "@code{bin-graph} provides a simple way of visualizing the different regions
> +of a binary file.")
> + (license license:gpl3))))
> +
> (define-public ddcci-driver-linux
> (package
> (name "ddcci-driver-linux")
>
> base-commit: a977900d76b7585c401222a3ce8bbb82e5f6da45
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 832 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
* [bug#72957] [PATCH v2] gnu: Add bin-graph.
2024-09-02 9:57 [bug#72957] [PATCH] gnu: Add bin-graph Artyom V. Poptsov
2024-09-04 2:43 ` Zheng Junjie
@ 2024-09-04 7:40 ` Artyom V. Poptsov
2024-09-18 8:53 ` [bug#72957] Looks good Andreas Enge
2024-10-13 10:17 ` [bug#72957] [PATCH] gnu: Add bin-graph Artyom V. Poptsov
3 siblings, 0 replies; 6+ messages in thread
From: Artyom V. Poptsov @ 2024-09-04 7:40 UTC (permalink / raw)
To: 72957; +Cc: Artyom V. Poptsov, Leo Famulari, Wilko Meyer
* gnu/packages/linux.scm (bin-graph): New variable.
Change-Id: I7405cbc00e038d024d035fb100473352c9a7b59d
---
gnu/packages/linux.scm | 34 ++++++++++++++++++++++++++++++++++
1 file changed, 34 insertions(+)
diff --git a/gnu/packages/linux.scm b/gnu/packages/linux.scm
index a3b63a6f62..76de4be816 100644
--- a/gnu/packages/linux.scm
+++ b/gnu/packages/linux.scm
@@ -1776,6 +1776,40 @@ (define-public bbswitch-module
graphics card on Optimus laptops.")
(license license:gpl2))))
+(define-public bin-graph
+ ;; XXX: The upstream does not have tags yet.
+ (let ((commit "1dd42e3e8e123e993d6c287967502c8d4b36f9ba")
+ (revision "0"))
+ (package
+ (name "bin-graph")
+ (version (git-version "0.0.0" revision commit))
+ (source
+ (origin
+ (method git-fetch)
+ (uri (git-reference
+ (url "https://github.com/8dcc/bin-graph")
+ (commit commit)))
+ (file-name (git-file-name name version))
+ (sha256
+ (base32 "1wjkl789r7iys3nnyk813gsdxwwy2ryxgxirx5xw02lzk790dywl"))))
+ (arguments
+ (list #:tests? #f ; no tests
+ #:make-flags
+ #~(list (string-append "CC=" #$(cc-for-target))
+ (string-append "PREFIX=" #$output)
+ (string-append "INSTALL_DIR=" #$output "/bin"))
+ #:phases
+ #~(modify-phases %standard-phases
+ (delete 'configure)))) ; no configure script
+ (build-system gnu-build-system)
+ (inputs (list libpng))
+ (home-page "https://github.com/8dcc/bin-graph")
+ (synopsis "Visualize binary files")
+ (description
+ "@code{bin-graph} provides a simple way of visualizing the different regions
+of a binary file.")
+ (license license:gpl3))))
+
(define-public ddcci-driver-linux
(package
(name "ddcci-driver-linux")
base-commit: 7fa9df431e9423e2b79c8c520de1d0ef7aed910d
--
2.45.2
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [bug#72957] [PATCH] gnu: Add bin-graph.
2024-09-04 2:43 ` Zheng Junjie
@ 2024-09-04 7:46 ` Artyom V. Poptsov
0 siblings, 0 replies; 6+ messages in thread
From: Artyom V. Poptsov @ 2024-09-04 7:46 UTC (permalink / raw)
To: Zheng Junjie; +Cc: Wilko Meyer, 72957, Leo Famulari
[-- Attachment #1: Type: text/plain, Size: 624 bytes --]
Hello, Zheng Junjie!
Thank you for the patch review! I fixed most of the issues that you
mentioned.
> maybe gnu/packages/graph.scm better here
I don't think that "graph.scm" is a good place for "bin-graph" as this
is not a tool for working with images only but more like a tool for
visualizing the insides of binaries. It's closer to reverse-engineering
realm than to image processing realm.
- avp
--
Artyom "avp" Poptsov <poptsov.artyom@gmail.com>
Home page: https://memory-heap.org/~avp/
CADR Hackerspace co-founder: https://cadrspace.ru/
GPG: D0C2 EAC1 3310 822D 98DE B57C E9C5 A2D9 0898 A02F
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 869 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
* [bug#72957] Looks good
2024-09-02 9:57 [bug#72957] [PATCH] gnu: Add bin-graph Artyom V. Poptsov
2024-09-04 2:43 ` Zheng Junjie
2024-09-04 7:40 ` [bug#72957] [PATCH v2] " Artyom V. Poptsov
@ 2024-09-18 8:53 ` Andreas Enge
2024-10-13 10:17 ` [bug#72957] [PATCH] gnu: Add bin-graph Artyom V. Poptsov
3 siblings, 0 replies; 6+ messages in thread
From: Andreas Enge @ 2024-09-18 8:53 UTC (permalink / raw)
To: 72957
Hello Artyom,
it looks good and passes QA.
I think you have commit rights now and can push it yourself and close
the issue? If not, please come back to me.
Andreas
^ permalink raw reply [flat|nested] 6+ messages in thread
* [bug#72957] [PATCH] gnu: Add bin-graph.
2024-09-02 9:57 [bug#72957] [PATCH] gnu: Add bin-graph Artyom V. Poptsov
` (2 preceding siblings ...)
2024-09-18 8:53 ` [bug#72957] Looks good Andreas Enge
@ 2024-10-13 10:17 ` Artyom V. Poptsov
3 siblings, 0 replies; 6+ messages in thread
From: Artyom V. Poptsov @ 2024-10-13 10:17 UTC (permalink / raw)
To: 72957-done; +Cc: andreas, zhengjunjie, 72957
[-- Attachment #1: Type: text/plain, Size: 285 bytes --]
Pushed to the "master" as e4f5eb6c01727ef143e533019e74830e00d6f5d2.
- avp
--
Artyom "avp" Poptsov <poptsov.artyom@gmail.com>
Home page: https://memory-heap.org/~avp/
CADR Hackerspace co-founder: https://cadrspace.ru/
GPG: D0C2 EAC1 3310 822D 98DE B57C E9C5 A2D9 0898 A02F
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 869 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2024-10-13 10:18 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-09-02 9:57 [bug#72957] [PATCH] gnu: Add bin-graph Artyom V. Poptsov
2024-09-04 2:43 ` Zheng Junjie
2024-09-04 7:46 ` Artyom V. Poptsov
2024-09-04 7:40 ` [bug#72957] [PATCH v2] " Artyom V. Poptsov
2024-09-18 8:53 ` [bug#72957] Looks good Andreas Enge
2024-10-13 10:17 ` [bug#72957] [PATCH] gnu: Add bin-graph Artyom V. Poptsov
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).