From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0.migadu.com ([2001:41d0:303:e224::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms13.migadu.com with LMTPS id wMi5NTBz3GZGrwAAqHPOHw:P1 (envelope-from ) for ; Sat, 07 Sep 2024 15:37:21 +0000 Received: from aspmx1.migadu.com ([2001:41d0:303:e224::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0.migadu.com with LMTPS id wMi5NTBz3GZGrwAAqHPOHw (envelope-from ) for ; Sat, 07 Sep 2024 17:37:20 +0200 X-Envelope-To: larch@yhetil.org Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=debbugs.gnu.org header.s=debbugs-gnu-org header.b=lXQF9rnA; dkim=fail ("headers rsa verify failed") header.d=riseup.net header.s=squak header.b=qU+3G3Wh; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=riseup.net (policy=none); spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1725723440; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=oyyZF6gFuto71ZauQhwbAS8SU0Dz2TTW83Z85qrfa7U=; b=kY0g+o1meYP6BgNxkPLd8g9CAxH39ZYUGgEJLGBeHFpRpNLNUsSW7P1hygjbaMsqB5yvMN ZfyEllVf1tHtnlDZ2nGvC5AUxYGAtgsVJvg0liVarB5Z3BFO7ajoRnw+uS/8k15yEamOO0 HDO8PefvWA5ml1O8LK0U+FKm3oeah4Laza/LT7HuVuGZdZNaZ82nFcgaFvAvuF0lUjkB4I 80PiM89OwfYYcIZOLgK4yZvqJ626lN1fOQrDmcLGg3cJcrMdDr5hYrP6rkvNrL0gN+WoEg 4wk3o6SVQQifQJy2BGG3VpQJpGPHtCyTd56g6gLLArm3QUCzj3IYA1Ei3jCJTw== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1725723440; a=rsa-sha256; cv=none; b=KPehoRADPeOS8PpIJq02N+gQmDqvvzN7+R94cHO+NrA+Ua8di5TIMaYHsffS78B40Xtlvc EwPMyueyKMxBnxzrWdaG/tg8viVeAXSnit2jS7XfazYLfVUZ3PKtSrK8TWUR8Ry5yHh0I2 BkGod2c9FT28ZsCIC+aMOx2B2ck83Xzu7zjMYEFWtjecL7c1W7yCkg3LSPb+jro+MrqN6F Cw5/bKv4VDlupLAaPP5HNyhWGlNrPoa81kofMRwzMof9souZ50MjXUDVsxbBoaReTrv+0G m5MDpOaMjSmu322tKE4HYmGuoVZVROYCKdkCtHQ6ez4PPeq2jj18/syyOX/Obw== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=pass header.d=debbugs.gnu.org header.s=debbugs-gnu-org header.b=lXQF9rnA; dkim=fail ("headers rsa verify failed") header.d=riseup.net header.s=squak header.b=qU+3G3Wh; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=riseup.net (policy=none); spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id D93197F39B for ; Sat, 7 Sep 2024 17:37:19 +0200 (CEST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1smxUl-00038A-Nf; Sat, 07 Sep 2024 11:37:03 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1smxUj-00037u-IA for guix-patches@gnu.org; Sat, 07 Sep 2024 11:37:01 -0400 Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1smxUj-0000p0-92 for guix-patches@gnu.org; Sat, 07 Sep 2024 11:37:01 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=In-Reply-To:MIME-Version:References:From:Date:To:Subject; bh=oyyZF6gFuto71ZauQhwbAS8SU0Dz2TTW83Z85qrfa7U=; b=lXQF9rnAa+zGTUV84HAzq6gEUY8gG3hvEu3CGkVvDe7WWgXLFKKmnzH7Bez1zfrrYui/WasjYbrNaYTZ0ROrnwB3Ys4ZuU5h0LgCZ8blLCDlkIVZnM8ut4hDwgMhAWJafN6ooWvEC5Zmv5ri5c940DEiB02xTBFMnU1apoSPFp/Mclpy6SJMcw2X9rHQQes5vKnP+HZ7WaLCLg2vsrEdDeBgN31XG/PUSMQlONOB/dzNM8Pmzxe1MRajDt0GOyJcgzEOFEAxIbK2LAHqiztgC7TCQjtHrTHpNK4xB5HKci55iCGHzOnsP6mmTb0n+RER2CEvloSIdlNDyiHgJ8GKxA==; Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1smxUk-0003R1-57 for guix-patches@gnu.org; Sat, 07 Sep 2024 11:37:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#71782] [PATCH v5 3/4] gnu: torbrowser: Update to 13.5.3 [security fixes]. Resent-From: =?UTF-8?Q?Andr=C3=A9?= Batista Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sat, 07 Sep 2024 15:37:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 71782 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Ian Eure Cc: mhw@netris.org, jonathan.brielmaier@web.de, 71782@debbugs.gnu.org Received: via spool by 71782-submit@debbugs.gnu.org id=B71782.172572340113174 (code B ref 71782); Sat, 07 Sep 2024 15:37:02 +0000 Received: (at 71782) by debbugs.gnu.org; 7 Sep 2024 15:36:41 +0000 Received: from localhost ([127.0.0.1]:57238 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1smxUP-0003QQ-6N for submit@debbugs.gnu.org; Sat, 07 Sep 2024 11:36:41 -0400 Received: from mx1.riseup.net ([198.252.153.129]:41892) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1smxUM-0003QC-Bm for 71782@debbugs.gnu.org; Sat, 07 Sep 2024 11:36:40 -0400 Received: from fews02-sea.riseup.net (fews02-sea-pn.riseup.net [10.0.1.112]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx1.riseup.net (Postfix) with ESMTPS id 4X1HJH0tYBzDqLh; Sat, 7 Sep 2024 15:36:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=riseup.net; s=squak; t=1725723391; bh=b7UEURLwu76WkRA7ZaDLRuhvEv3JvRMDcwMr2X54wtA=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=qU+3G3WhJ+h+572lWwXrVGpyIPKlkZ/+r0tKx07/uUr3WRpI4gJol0EkoTJyXMVTA 9l2YfGJ1Q716XK64O0IF3t0cgPkwD0d83PpTkL1Ol6Yn842Tyu82+4i6VSC+V+xVWi 7LHbIicVRTbD/QcvAzqfn7UpoxOgw8zRUYlLCztY= X-Riseup-User-ID: C6C77B5056FC4A3EAFE65A5F29FA78B39C9EF947C7DFAC15B81E2BCAE41B582D Received: from [127.0.0.1] (localhost [127.0.0.1]) by fews02-sea.riseup.net (Postfix) with ESMTPSA id 4X1HJF59DHzFsDL; Sat, 7 Sep 2024 15:36:29 +0000 (UTC) Date: Sat, 7 Sep 2024 12:36:21 -0300 From: =?UTF-8?Q?Andr=C3=A9?= Batista Message-ID: References: <20240905230801.5772-1-nandre@riseup.net> <20240905231807.5950-1-nandre@riseup.net> <878qw424vb.fsf@meson> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <878qw424vb.fsf@meson> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US X-Migadu-Queue-Id: D93197F39B X-Migadu-Scanner: mx12.migadu.com X-Migadu-Spam-Score: -10.02 X-Spam-Score: -10.02 X-TUID: nn+EokNCppLz Hi Ian, sex 06 set 2024 às 08:05:28 (1725620728), ian@retrospec.tv enviou: > > This all looks good to me. I built and ran both browsers and they seem to > be working how I’d expect. Great, thanks! > My only question is around the locale handling -- (gnu packages gnuzilla) > has a setup for these which I was able to reuse for LibreWolf. Is that > possible for mullvad and torbrowser? It would be nice to have a unified way > of handling this, instead of each browser implementing its own strategy. > I'm not sure I understand why you think this to be desirable, could you elaborate? I'm also not sure if this is possible (without incuring in glitches) and in my opinion this is not desirable for both torbrowser and mullvad because: I. Both these browsers have modified pristine firefox in a number of non-trivial ways. Eg.: if you go to about:preferences you will see that there are various user settings which are specific to this browsers or even when you first launch torbrowser the connection settings page is unknown to firefox. I believe that's the reason why these browsers do not support 'all-mozilla-locales', but just a subset which has been worked upon by the torproject. II. In order to avoid guix users having a different fingerprint, we try to be as close as possible to what upstream does. I'm not sure if locale version could be somehow infered from the network, but I guess using the same version is the safest bet; III. Currently on guix master, these browsers are using code copied from gnuzilla.scm, but with a subset of locales and different changesets that are based on torproject settings. However, torproject has moved from mercurial to the unified github firefox locales[1] which has immensily simplified the work required to update the changesets (now actually commits) and all locales supported on those browsers now have only one commit, instead of various changesets on single locale repos; IV. Moreover, I believe mozilla itself is on the way of deprecating mercurial l10n-central in favor of firefox-locales git repo, since this is where all work has been happening[2], while l10n-central has stopped at 2024-07-10[2]. So probably in a not so distant future gnuzilla will have to move on to that as well. So I stand by the changes proposed on this patch series, at least as things stand. Thanks! 1. https://gitlab.torproject.org/tpo/applications/tor-browser/-/commit/55ad6ca216c086fb297af456ed0606ab88c1acdc 2. https://github.com/mozilla-l10n/firefox-l10n 3. https://hg.mozilla.org/l10n-central/