unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: Andreas Enge <andreas@enge.fr>
To: 72968-done@debbugs.gnu.org, 72943@debbugs.gnu.org
Subject: [bug#72943] Patches applied
Date: Thu, 5 Sep 2024 22:41:56 +0200	[thread overview]
Message-ID: <ZtoXlEjn2BP-uDLu@jurong> (raw)
In-Reply-To: <20240901191119.29870-1-rutherther@protonmail.com>

Hello,

I have applied Carlos's second patch of
   https://issues.guix.gnu.org/72943
which gives an explanation why we skip the tests,
and Noé's patch of
   https://issues.guix.gnu.org/72968
adding the missing inputs.

As php currently does not build after the core-updates merge and this issue
has been turning up regularly over the past few days, I have taken the
liberty to push the commits directly without going through QA; I have
tested that the package builds and works with one of my local php projects.

I am closing the second issue, which is thus handled.
And I am leaving the first issue open; while the immediate php problem is
(hopefully) solved, it remains to be discussed whether we should propagate
the gd inputs in the longer term.

My understanding is that given the pkg-config file, we normally would
propagate the inputs. On the other hand, propagated inputs tend to create
problems (for instance, when two different packages propagate two different
versions of the same input library); and I do not quite understand why
with over 5000 packages depending on gd, most of them do not seem to be
affected. Maybe these do not use pkg-config to check for gd?
So it may be a better option to only patch the affected packages (if any
are left) and leave gd as it is.

Andreas





      parent reply	other threads:[~2024-09-05 20:43 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-09-01 19:11 [bug#72943] [PATCH] gnu: gd: Requires.private to propagated inputs Rutherther via Guix-patches via
2024-09-01 23:33 ` Carlo Zancanaro
2024-09-02 17:23 ` Rutherther via Guix-patches via
2024-09-03  0:19   ` Carlo Zancanaro
2024-09-03  1:54     ` [bug#72943] [PATCH 1/2] " Carlo Zancanaro
2024-09-03  1:54     ` [bug#72943] [PATCH 2/2] gnu: php: Disable tests relating to BICUBIC interpolation Carlo Zancanaro
2024-09-04  6:50       ` [bug#72962] php-8.3.10 build failure guix-patches--- via
2024-09-04  6:50         ` [bug#72943] bug#72962: " guix-patches--- via
2024-09-04  7:27         ` Carlo Zancanaro
2024-09-04  7:43           ` [bug#72962] " guix-patches--- via
2024-09-04  7:59           ` guix-patches--- via
2024-09-04 10:32           ` guix-patches--- via
2024-09-05 20:41 ` Andreas Enge [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZtoXlEjn2BP-uDLu@jurong \
    --to=andreas@enge.fr \
    --cc=72943@debbugs.gnu.org \
    --cc=72968-done@debbugs.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).