unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: Andreas Enge <andreas@enge.fr>
To: 72057@debbugs.gnu.org
Subject: [bug#72057] Small changes required
Date: Thu, 11 Jul 2024 22:36:50 +0200	[thread overview]
Message-ID: <ZpBCYrt3LqreyITW@jurong> (raw)
In-Reply-To: <20240711092149.12396-3-ikbenrickhuyzer@gmail.com>

Hello,

thanks for the patch! It builds, but has a few minor problems,
notably with white space and other formatting issues, see here:
   https://qa.guix.gnu.org/issue/72057
These can also be found by running
   ./pre-inst-env guix lint python-sacn
locally.

Could you prepare a new version and send it following the
instructions at
   https://guix.gnu.org/de/manual/devel/en/html_node/Sending-a-Patch-Series.html#Single-Patches-1
(paragraph starting with: "If you need to send a revised patch...")?

Adding a copyright line is good practice when adding a new package.

Thanks!

Andreas





  reply	other threads:[~2024-07-11 20:37 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-07-11  9:20 [bug#72057] [PATCH] Add python-sacn Rick Huijzer
2024-07-11 20:36 ` Andreas Enge [this message]
2024-07-11 20:52   ` bug#72057: " jgart via Guix-patches via

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZpBCYrt3LqreyITW@jurong \
    --to=andreas@enge.fr \
    --cc=72057@debbugs.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).