From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0.migadu.com ([2001:41d0:303:e224::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms13.migadu.com with LMTPS id qD8pCGYpgWYP7gAAqHPOHw:P1 (envelope-from ) for ; Sun, 30 Jun 2024 09:46:14 +0000 Received: from aspmx1.migadu.com ([2001:41d0:303:e224::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0.migadu.com with LMTPS id qD8pCGYpgWYP7gAAqHPOHw (envelope-from ) for ; Sun, 30 Jun 2024 11:46:14 +0200 X-Envelope-To: larch@yhetil.org Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1719740774; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type:resent-to:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post; bh=Es2ShEng9X4XhanUHb1oJBigcImxt1p5XqacavVo9S4=; b=eauoEq3COJJwmsr7KRww+u2KEaokRGWVHh7Babjptp8s0YFJFQa4ca+dgJ3fiqvw6y0i2H f2lHsRNHrQiHqRvXPukx4GLV5eruALDhqrYCC1eCPgOFYaOCvY9WD3WbHjBLzBWk9PXnQ4 3Bm0ss3ee2cPdYyaHbeGQHtD9Sm2Prm7CUyv2dFAT3b8NgF4gZQ1RCqDFLzFg6tgU7gj8r NYh7NGdxdCPdQR5PlR+Dz5vl5y0JiVawrzJNQiGNeQHZWI0PxANL06GjfhvriJa5FwozLO gFu04irwJiDUOWrTjWTgmRIAWzkl6SQVYPmlYv2lEvORHovU+sx+i22beF8DfQ== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1719740774; a=rsa-sha256; cv=none; b=aY8VxmnrNDGhew8XPkD5cMqlXmQm/0ghAIaDENBAkyGVyN3QNrxhVpMWvAqrp268UYgtJo ueOjI4qjIrtICKu2Cj6rkQ/2GD66C9RYiB4dPfM08DVPcyrVfXgtbRplbJgqvglqcGM0CP 7UdXxi2r3MMe5RcoheUIf9vru8ppjlyF9kh3sJ5DvJEgpvyIsQ+reWOQTZU8rpLa6R14/h uXB3rd7Ae5z948tvSdyuO6sr2yz7In8kxrLgAYNRIFgR1OVAfWjsac/0svmBmIEoCjVGDk kjLcHWKHp6x1spA1UoVp6PGJyO0jf9EUJouu6mIwTkmjcThfW9EPHCTncl1cKA== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id ED34432D62 for ; Sun, 30 Jun 2024 11:46:13 +0200 (CEST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sNr8J-0007g3-7K; Sun, 30 Jun 2024 05:46:07 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sNr8E-0007fO-Rv for guix-patches@gnu.org; Sun, 30 Jun 2024 05:46:02 -0400 Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1sNr8E-0007kQ-Je for guix-patches@gnu.org; Sun, 30 Jun 2024 05:46:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1sNr8E-0005mn-CE for guix-patches@gnu.org; Sun, 30 Jun 2024 05:46:02 -0400 Subject: bug#71587: Close References: In-Reply-To: Resent-From: Andreas Enge Original-Sender: "Debbugs-submit" Resent-To: guix-patches@gnu.org Resent-Date: Sun, 30 Jun 2024 09:46:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: cc-closed 71587 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 71587-done@debbugs.gnu.org Mail-Followup-To: 71587@debbugs.gnu.org, andreas@enge.fr, sergiodj@sergiodj.net Received: via spool by 71587-done@debbugs.gnu.org id=D71587.171974072722196 (code D ref 71587); Sun, 30 Jun 2024 09:46:02 +0000 Received: (at 71587-done) by debbugs.gnu.org; 30 Jun 2024 09:45:27 +0000 Received: from localhost ([127.0.0.1]:55132 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sNr7e-0005lw-MW for submit@debbugs.gnu.org; Sun, 30 Jun 2024 05:45:26 -0400 Received: from hera.aquilenet.fr ([185.233.100.1]:58296) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sNr7c-0005li-KQ for 71587-done@debbugs.gnu.org; Sun, 30 Jun 2024 05:45:25 -0400 Received: from localhost (localhost [127.0.0.1]) by hera.aquilenet.fr (Postfix) with ESMTP id 768E21E6; Sun, 30 Jun 2024 11:44:48 +0200 (CEST) X-Virus-Scanned: Debian amavisd-new at hera.aquilenet.fr Received: from hera.aquilenet.fr ([127.0.0.1]) by localhost (hera.aquilenet.fr [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 5hv_a1ytuugi; Sun, 30 Jun 2024 11:44:48 +0200 (CEST) Received: from jurong (unknown [IPv6:2001:861:c4:f2f0::c64]) by hera.aquilenet.fr (Postfix) with ESMTPSA id DF73C1C7; Sun, 30 Jun 2024 11:44:47 +0200 (CEST) Date: Sun, 30 Jun 2024 11:44:46 +0200 From: Andreas Enge Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US X-Migadu-Queue-Id: ED34432D62 X-Migadu-Scanner: mx12.migadu.com X-Migadu-Spam-Score: -5.88 X-Spam-Score: -5.88 X-TUID: 5I2+8nDHG612 Hello, thanks for the patches! I think renaming is a good idea; details are of course of the order of bikeshedding. Since I like fediverse better, I kept your patch. Concerning snac2, I have decided to call it snac instead. This is how it is called on the author's github page (the largest heading), and it is also the name of the binary. I have modernised the patch using gexps, removed the #t return value of a phase, and added a comment why tests are disabled. There is no need to sign off your own patches, since you are already the author. Something strange happened with the change ids, there were two of them in each commit; I have kept one every time. Andreas