[bug#71793] [PATCH] ui: Write down the unwritten rule.

[bug#71793] [PATCH] ui: Write down the unwritten rule.

[Tomas Volf]

Quote from Ludovic:

> [..] there’s the unwritten rule that non-UI modules should not load (guix
> ui) [..]

This commit turns it into a written rule.

* guix/ui.scm: Document the import policy.

Change-Id: Iedd48f5622b2b17b9e2eec817cf27f0c3a938ff2
---
 guix/ui.scm | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/guix/ui.scm b/guix/ui.scm
index d82fa533cc..d24886d156 100644
--- a/guix/ui.scm
+++ b/guix/ui.scm
@@ -35,6 +35,10 @@
 ;;; You should have received a copy of the GNU General Public License
 ;;; along with GNU Guix.  If not, see <http://www.gnu.org/licenses/>.
 
+;;; !!!!
+;;; !!!! This module shall not be imported from non-UI modules.
+;;; !!!!
+
 (define-module (guix ui)
   #:use-module (guix i18n)
   #:use-module (guix colors)
-- 
2.45.1

[bug#71793] [PATCH] ui: Write down the unwritten rule.

[jgart via Guix-patches via]

> Quote from Ludovic:
> 

Hi Tomas,

Can you link me to the places where you are quoting that from? Thanks!

all best,

jgart

[bug#71793] [PATCH] ui: Write down the unwritten rule.

[Tomas Volf]

[-- Attachment #1: Type: text/plain, Size: 464 bytes --]

On 2024-06-29 01:47:52 -0500, jgart wrote:
>
> > Quote from Ludovic:
> >
>
> Hi Tomas,
>
> Can you link me to the places where you are quoting that from? Thanks!

Yes sure, it was given as a reason to not merge patch #2 in 70839:
  https://issues.guix.gnu.org/70839#4-lineno17

It is always possible I just misunderstood.

Have a nice day,
Tomas Volf

--
There are only two hard things in Computer Science:
cache invalidation, naming things and off-by-one errors.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

bug#71793: [PATCH] ui: Write down the unwritten rule.

[Ludovic Courtès]

Hi,

Tomas Volf <~@wolfsden.cz> skribis:

> Quote from Ludovic:
>
>> [..] there’s the unwritten rule that non-UI modules should not load (guix
>> ui) [..]
>
> This commit turns it into a written rule.
>
> * guix/ui.scm: Document the import policy.
>
> Change-Id: Iedd48f5622b2b17b9e2eec817cf27f0c3a938ff2

I committed a variant of this patch, thanks.

Ludo’.