unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: Tomas Volf <~@wolfsden.cz>
To: "Ludovic Courtès" <ludo@gnu.org>
Cc: 70839@debbugs.gnu.org
Subject: [bug#70839] [PATCH 0/3] Minor changes to `channels' field and related doc.
Date: Thu, 27 Jun 2024 13:54:07 +0200	[thread overview]
Message-ID: <Zn1S34xuw9eTFd7h@ws> (raw)
In-Reply-To: <87sewz9yai.fsf@gnu.org>

[-- Attachment #1: Type: text/plain, Size: 1415 bytes --]

On 2024-06-26 23:41:57 +0200, Ludovic Courtès wrote:
> > Tomas Volf (3):
> >   doc: Warn about extra-special-file usage in /etc.
> >   channels: Add `read-channels-file' procedure.
> >   services: guix: Default `channels' field to #f.
>
> Finally got around to it: I applied patches #1 and #3.

Thanks :)

> For patch #2, there’s the unwritten rule that non-UI modules should not
> load (guix ui), so I’m reluctant to applying it in its current form.

https://issues.guix.gnu.org/71793

> Now, the current situation is not great either.  For instance, partly
> due to that rule, there are 3 copies of ‘load-manifest’—not the end of
> the world since it’s just 3 lines, but still.
>
> I don’t have a good idea on how to address this, but we can talk.  :-)

Well, in my case I am interested only in `load*' and `make-user-module'.  So
maybe I could move them into (guix utils).  (guix ui) could just #:re-export
them in order to limit the size of the diff, but in (guix channels) I could just
import (guix utils) and use the `load*' from there.

Fundamentally I guess the same could be done with `load-manifest' procedure you
mentioned.

Thoughts?

> Thanks, and apologies for the delay!

No worries and thank you for merging at least parts,

Tomas

--
There are only two hard things in Computer Science:
cache invalidation, naming things and off-by-one errors.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

      reply	other threads:[~2024-06-27 11:55 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-05-08 22:59 [bug#70839] [PATCH 0/3] Minor changes to `channels' field and related doc Tomas Volf
2024-05-08 23:13 ` [bug#70839] [PATCH 1/3] doc: Warn about extra-special-file usage in /etc Tomas Volf
2024-05-08 23:13 ` [bug#70839] [PATCH 2/3] channels: Add `read-channels-file' procedure Tomas Volf
2024-05-08 23:13 ` [bug#70839] [PATCH 3/3] services: guix: Default `channels' field to #f Tomas Volf
2024-06-26 21:41 ` bug#70839: [PATCH 0/3] Minor changes to `channels' field and related doc Ludovic Courtès
2024-06-27 11:54   ` Tomas Volf [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Zn1S34xuw9eTFd7h@ws \
    --to=~@wolfsden.cz \
    --cc=70839@debbugs.gnu.org \
    --cc=ludo@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).