From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1.migadu.com ([2001:41d0:303:e16b::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms13.migadu.com with LMTPS id 8GuDLw3UZmYzPQAA62LTzQ:P1 (envelope-from ) for ; Mon, 10 Jun 2024 10:23:09 +0000 Received: from aspmx1.migadu.com ([2001:41d0:303:e16b::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1.migadu.com with LMTPS id 8GuDLw3UZmYzPQAA62LTzQ (envelope-from ) for ; Mon, 10 Jun 2024 12:23:09 +0200 X-Envelope-To: larch@yhetil.org Authentication-Results: aspmx1.migadu.com; dkim=none; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1718014988; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post; bh=UJZ0yMELdM43J6USKs851bHclfffW5LZgEm0yw04bH0=; b=T+N0gj58h2Db+IRpCOaXRsJxnmh0MgjAzTAqP30UM4A1SFWX9QgOg6059DK5VoAmp+XT7j 9GNWbUWcp7xkhzl0CHwMm3A/moLMzc8PD4s5MMLpghlhDPQJLbax3GTBl2Inwp3WH4Orta rJY92+qz+XVwmOcyBVcJ5LY0h3/1CtAtTya9OqGw/3AvFdrSVYILBUEMqE17puVumOSyV6 bgPxz3OP4Xsx8FjziQJpS60+Ahcmdqd4y5BZS27zvsE6gKS2+lDV5N78dhqeQPgmbDTtsv By8FRTc8RUhhuHWvdcMPxp0icCfXzo+cb/k3fCAtvMnwOIzlst3wbNiUh+VQ1A== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=none; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=none ARC-Seal: i=1; s=key1; d=yhetil.org; t=1718014988; a=rsa-sha256; cv=none; b=rgDuREGhfqoy+YVCPqkog12hUCbb2xPGhB2ZHGwwPBwqmH0TmJLQ9JKRnS2Lhl3PN6Pejn azh5L8qFAzCinPW/I81lc1y/fIXCfGRb3nrZ81+Yx57qjd4JsQg9qzYhjYE1RJyWo2qSda XkXlRAmmwcoTFzn7D8I26Y5z3SUp6UGHcu4bAvpbT88eEyPYVWuVQqEn+tPTF+5YMNG5HC Ds1CJfb1A3MknB59D3Mqq+YnacYB9a65qduFPRzUx1PiBUUIMtO42BfzbYk5LEoiVtGhRq jUstsDJ4S82YHw0SP6RIj3q8NwKwCq8gZhHMg7huOnWzF/wiECYMLlXvDntpJQ== Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id B5216570E3 for ; Mon, 10 Jun 2024 12:23:08 +0200 (CEST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sGcAp-0004es-K6; Mon, 10 Jun 2024 06:22:47 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sGcAo-0004ec-6K for guix-patches@gnu.org; Mon, 10 Jun 2024 06:22:46 -0400 Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1sGcAn-0005Pn-P9 for guix-patches@gnu.org; Mon, 10 Jun 2024 06:22:45 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1sGcB4-0000cB-Hd for guix-patches@gnu.org; Mon, 10 Jun 2024 06:23:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#71396] Close Resent-From: Andreas Enge Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Mon, 10 Jun 2024 10:23:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 71396 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Christopher Baines Cc: gemmaro.dev@gmail.com, 71396@debbugs.gnu.org Received: via spool by 71396-submit@debbugs.gnu.org id=B71396.17180149282193 (code B ref 71396); Mon, 10 Jun 2024 10:23:02 +0000 Received: (at 71396) by debbugs.gnu.org; 10 Jun 2024 10:22:08 +0000 Received: from localhost ([127.0.0.1]:52411 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sGcAB-0000ZI-It for submit@debbugs.gnu.org; Mon, 10 Jun 2024 06:22:07 -0400 Received: from hera.aquilenet.fr ([185.233.100.1]:40778) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sGcA9-0000YW-Ox for 71396@debbugs.gnu.org; Mon, 10 Jun 2024 06:22:06 -0400 Received: from localhost (localhost [127.0.0.1]) by hera.aquilenet.fr (Postfix) with ESMTP id 49DEF2B6; Mon, 10 Jun 2024 12:21:13 +0200 (CEST) X-Virus-Scanned: Debian amavisd-new at hera.aquilenet.fr Received: from hera.aquilenet.fr ([127.0.0.1]) by localhost (hera.aquilenet.fr [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 9M4-0XCchwWl; Mon, 10 Jun 2024 12:21:12 +0200 (CEST) Received: from jurong (unknown [IPv6:2001:861:c4:f2f0::c64]) by hera.aquilenet.fr (Postfix) with ESMTPSA id 9E5512D2; Mon, 10 Jun 2024 12:21:12 +0200 (CEST) Date: Mon, 10 Jun 2024 12:21:11 +0200 From: Andreas Enge Message-ID: References: <87wmmxyuuo.fsf@cbaines.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <87wmmxyuuo.fsf@cbaines.net> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US X-Migadu-Spam-Score: -5.84 X-Spam-Score: -5.84 X-Migadu-Queue-Id: B5216570E3 X-Migadu-Scanner: mx13.migadu.com X-TUID: 0qejQLRFfKIp Am Mon, Jun 10, 2024 at 11:07:11AM +0100 schrieb Christopher Baines: > Note that quoting vs gexps matters for package inheritance, so even > though there's no ungexp'ing happening in this pacakge, the phases could > be ungexp'ed by a package that inherits from solaar. > For this reason, I think it's important to move to using gexp's for all > phases, even the trivial ones, so that there are less issues when it > comes to package inheritance and modifying phases. Good point, although most packages do not lead to inheritance; but when they do, this issue becomes difficult to debug. Feel free to push the second patch if you want to. Andreas