From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0.migadu.com ([2001:41d0:303:e16b::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms1.migadu.com with LMTPS id AAgbHudLXGY0VAAAqHPOHw:P1 (envelope-from ) for ; Sun, 02 Jun 2024 12:39:35 +0200 Received: from aspmx1.migadu.com ([2001:41d0:303:e16b::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0.migadu.com with LMTPS id AAgbHudLXGY0VAAAqHPOHw (envelope-from ) for ; Sun, 02 Jun 2024 12:39:35 +0200 X-Envelope-To: larch@yhetil.org Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20230601 header.b=dKE2GSyu; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1717324775; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post: dkim-signature; bh=GHKCdNTeg8zMcyYz2B/fZ/e0qFWAmKybb4dwMhhi+r4=; b=nxXB3NibpynyDZoT57PVlqg0K3HO07Je2XNVQ1WLZEzQTsDPA8LovprhfAi2kxIn37IZru JlHjoM4e3Y0afuHWoAPfuXmQK7/gNYA/O6iXqBLzFwFO36NPBMcObjbf0d/64UguOg7zJh cnWlnVoDqKrWC815moEMN31PqSsgkgsPi/MNl67g9qlQ/sXPdi4VmU3jGPrU3WLGnMmFh3 fqZakWrQOU2OD2Re+B7ykXMk8H1XaStguQL+7L+WxLqD3l8gn+VSPpdpQN1h8RleNvoNnv G4dHV72iSHoMjEHcUtr5bIRmm43iOB1bSI+aG0qa5/PRJRvcKQrbHWOFopsouA== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20230601 header.b=dKE2GSyu; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=none ARC-Seal: i=1; s=key1; d=yhetil.org; t=1717324775; a=rsa-sha256; cv=none; b=cEJTRKY3bPCX7Qjz3Cgtw/f783lRRjXGbUdRA7yLaFYBar7LgHCivIdbsL34u12hMYiLdN 2L22zDoDyimkR8qCXZrYwmPJV4TPlwOnf3pGWRUfDe0WZiCXMndXM5iEkuoj6sQKKR/TL6 W4dtf/9Ap74hA8Y5bkpVxIvrSqgGDLsUlEPBkiPiLw9sTQFko9raFMDvITk/hNYPg4iLWP EQlJy7rPmJOf2XuAxJxBsXs3elHDhUIXr5oYsOyHTMjSjUsNsvb9UtcyR761890bInhLH1 nlGfT1dWUMcdQE5r2uK/DWUFddbKnI5N4zkdif4TSB23w1PKMARYEoSPrspXRg== Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 1565867621 for ; Sun, 2 Jun 2024 12:39:35 +0200 (CEST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sDic2-0006HR-8R; Sun, 02 Jun 2024 06:38:54 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sDibz-0006Gg-Dl for guix-patches@gnu.org; Sun, 02 Jun 2024 06:38:51 -0400 Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1sDibz-0007Cd-5d for guix-patches@gnu.org; Sun, 02 Jun 2024 06:38:51 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1sDicB-0002YK-98 for guix-patches@gnu.org; Sun, 02 Jun 2024 06:39:03 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#71111] [PATCH 0/1] services: home: Use pairs instead of lists. Resent-From: Efraim Flashner Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sun, 02 Jun 2024 10:39:03 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 71111 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Ludovic =?UTF-8?Q?Court=C3=A8s?= Cc: 71111@debbugs.gnu.org, Maxim Cournoyer , Richard Sent , Florian Pelz , Andrew Tropin , Matthew Trzcinski Received: via spool by 71111-submit@debbugs.gnu.org id=B71111.17173247379753 (code B ref 71111); Sun, 02 Jun 2024 10:39:03 +0000 Received: (at 71111) by debbugs.gnu.org; 2 Jun 2024 10:38:57 +0000 Received: from localhost ([127.0.0.1]:57927 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sDic4-0002XE-WF for submit@debbugs.gnu.org; Sun, 02 Jun 2024 06:38:57 -0400 Received: from mail-wr1-f51.google.com ([209.85.221.51]:50289) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sDic2-0002X0-Fx for 71111@debbugs.gnu.org; Sun, 02 Jun 2024 06:38:55 -0400 Received: by mail-wr1-f51.google.com with SMTP id ffacd0b85a97d-354cd8da8b9so3278432f8f.0 for <71111@debbugs.gnu.org>; Sun, 02 Jun 2024 03:38:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1717324656; x=1717929456; darn=debbugs.gnu.org; h=in-reply-to:content-disposition:mime-version:references :mail-followup-to:message-id:subject:cc:to:from:date:sender:from:to :cc:subject:date:message-id:reply-to; bh=GHKCdNTeg8zMcyYz2B/fZ/e0qFWAmKybb4dwMhhi+r4=; b=dKE2GSyu7pGKLLWKbz3RB5AZCpUvlFfQhXa59m/il1y70nL/n9E60zDYna7KFVXiPd 0cHlEEOGcIUb2jtf/cRuuB/tGv794B/fo7miyau6EpWjdmSAIxolqDWPfJHCM6O3EFAb 9uVm534zVFSachJdEaD3JsQKnRjMhKMYMTfqJ3W0ZN+CSd03nDqEY0slWqJWdlkR1HDu mGhucJxnzQeVsBYdF2D4+VzM0qnaeKeOw77pSwoLEtU2OllZ3OUgYWQyNcxQgWb9Ikd8 w20UI+9ilVlCzL5PM+dKyOxv4PCkiiNCMm+qzyhArjNiNLR6daODznFkCgxZZioSIKyu J+6w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1717324656; x=1717929456; h=in-reply-to:content-disposition:mime-version:references :mail-followup-to:message-id:subject:cc:to:from:date:sender :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=GHKCdNTeg8zMcyYz2B/fZ/e0qFWAmKybb4dwMhhi+r4=; b=N6iuaDDTFyYo/OIBZHwDWjN/hH+E4gNTqwU6gHjyZ1U5OSSy2aZmpitZm/MTOt6RcM ENFIXtjH3gkbH1mXz38zLu3AMvT5trB78AZjuRcoAZ7IhxxyzWCCoRk2O61JE3Wn2g5l V5qN9/JjoJn+fICG7wE6kQIlfha1XvR1ju/2oB7qDITFK0B2Jg4nG+hVYFZUi7ud/GHV o738v0zFs6IsGjpUAw5RBE164dl7IUHTLDae0bRzb4XNLNFDFmXUmixkRUyuL1WWQZfL iykgVEBMBmSQNhEGy4ohkNphTE+PUP3l4Bm29Qm7I4kcFOz3iktd1C3wpz+zkhm47voU 8fBQ== X-Forwarded-Encrypted: i=1; AJvYcCX4b1NRW5ycc/Xj8byib1o8wQVCd3k7fQpYtw+u1+p888z/zxOH29ac5YIvVETbF6OxegGIDi+TcLo/KaUKHoGeC/QAvz0= X-Gm-Message-State: AOJu0YxmbWZX+7Hi+9pKwHppDRVq1CIyJAWYl4fhqAcUMFwHk/A4UpoM psbvPHPJRr3q3KFnyH44pSxzEmbatopLk4x3GudPXluJiWICmami X-Google-Smtp-Source: AGHT+IGrkIHoRA9NBZJbja84sj5narg2madPO5fZxsjAKORacX3eerAEpfBwmsAS6epSpkuSHOO/bg== X-Received: by 2002:adf:ed43:0:b0:351:d338:d9e9 with SMTP id ffacd0b85a97d-35e0f30b2c7mr4736404f8f.48.1717324656118; Sun, 02 Jun 2024 03:37:36 -0700 (PDT) Received: from localhost ([141.226.15.89]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-35dd04c0f1fsm5836505f8f.15.2024.06.02.03.37.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 02 Jun 2024 03:37:35 -0700 (PDT) Date: Sun, 2 Jun 2024 13:37:34 +0300 From: Efraim Flashner Message-ID: Mail-Followup-To: Efraim Flashner , Ludovic =?UTF-8?Q?Court=C3=A8s?= , Andrew Tropin , Richard Sent , 71111@debbugs.gnu.org, Matthew Trzcinski , Maxim Cournoyer , Florian Pelz References: <87ttib1xmz.fsf@trop.in> <87ikyrlkgd.fsf@gnu.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="Ku3u4cXKen+4nqzD" Content-Disposition: inline In-Reply-To: <87ikyrlkgd.fsf@gnu.org> X-PGP-Key-ID: 0x41AAE7DCCA3D8351 X-PGP-Key: https://flashner.co.il/~efraim/efraim_flashner.asc X-PGP-Fingerprint: A28B F40C 3E55 1372 662D 14F7 41AA E7DC CA3D 8351 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US X-Migadu-Spam-Score: -0.94 X-Spam-Score: -0.94 X-Migadu-Queue-Id: 1565867621 X-Migadu-Scanner: mx13.migadu.com X-TUID: +2fYFtyCR/og --Ku3u4cXKen+4nqzD Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sun, Jun 02, 2024 at 12:15:14PM +0200, Ludovic Court=C3=A8s wrote: > Hi Andrew, >=20 > Andrew Tropin skribis: >=20 > > On 2024-05-22 14:02, Andrew Tropin via Guix-patches via wrote: > > > >> After rewriting from car/cdr to match-lambda in v2 of this patch: > >> https://yhetil.org/guix-patches/3394b0b51f6a5a608ebcfb7a63fdc34e52fe92= 8e.1711046203.git.richard@freakingpenguin.com/ > >> > >> the format changed from pairs to lists, I didn't noticed this nuance > >> during review because the documentation still says that service should > >> be configured and extended with pairs. Also, pairs are more > >> apropriate data type here. And this match-lambda rewrite will break > >> downstream RDE user's setups after migrating to upstreamed version of > >> service. > >> > >> That's why I propose to go back to pairs. > >> > >> Andrew Tropin (1): > >> services: home: Use pairs instead of lists. > >> > >> doc/guix.texi | 4 ++-- > >> gnu/services/guix.scm | 2 +- > >> gnu/tests/guix.scm | 2 +- > >> 3 files changed, 4 insertions(+), 4 deletions(-) > >> > >> > >> base-commit: b06a460bf5236a9d52f936f2023451051b3e622a > > > > Merged v2 with updated API and additional type checks. >=20 > Perhaps I wasn=E2=80=99t clear enough when asking for clarifications=C2= =B9, but I > think this change shouldn=E2=80=99t happen: first because it=E2=80=99s an= incompatible > change that will break user configs, and second because it=E2=80=99s > inconsistent with other similar interfaces (such as =E2=80=98authorized-k= eys=E2=80=99 > and ). >=20 > For these reasons, I=E2=80=99m in favor of reverting this change. >=20 > What do others think? This patch also added home-environment? without adding an import of (gnu home). It's unfortunate that the wording for the manual says 'pair' when it's a list, but IMO that's more of a typo in the manual than a mistake in the code. With a quick look I didn't see in any of my OS configs configurations with pair notations, even with simple-service or extra-special-file, where it would have been most likely. I think it would be best to roll this back. > Aside, it=E2=80=99s unfortunate that you weren=E2=80=99t around to review= this patch > initially, despite being one of the recipients: > . I think it=E2=80=99s important to n= ot give > the impression that you chime in just when an rde incompatibility comes > up. >=20 > Thanks, > Ludo=E2=80=99. >=20 > =C2=B9 https://issues.guix.gnu.org/71111#8 >=20 >=20 >=20 --=20 Efraim Flashner =D7=A8=D7=A0=D7=A9=D7=9C=D7=A4 = =D7=9D=D7=99=D7=A8=D7=A4=D7=90 GPG key =3D A28B F40C 3E55 1372 662D 14F7 41AA E7DC CA3D 8351 Confidentiality cannot be guaranteed on emails sent or received unencrypted --Ku3u4cXKen+4nqzD Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEEoov0DD5VE3JmLRT3Qarn3Mo9g1EFAmZcS2oACgkQQarn3Mo9 g1EJYg//R5YFdIHEINWk6msWDDNBxoGnC+mLmTPxkYYmM2mfEh2z1cFsTLVnmHny O4FBC4A8qVTa1f2M/9HLzdn3EEzQEueLwQlo39ZrJpraJcpgr5IE5Cbyr45+cMiP 5ekfNesdxe4epdNJisJlFJ8YCt++bodKDxQh5XiQpN7LXz+lVxZAkRAfxUqrwF7O OR3GS+XXN4NcRLsfwnP3IpogybklzulN+nkb8AyFpIvkqNME9hiLHJZ8dyC5yd3T UZI73xFGlzhyQsN0oHj6NscLhzUD2RUQRTlfcoVbeYTUhZgs/L2cH7cZnaUFZf8Z 3wdRR/uegSe1il7iaYoWumL1U3n83lV7o4qIWC0pyvlrY1w8lQ5g8d6PucvRf8Wa LlKf78415FEDsO7Ym6r/jmG0Llz/zqRBBdKEn0kVsxVTOVy3/yy1c2L4xkk6Pimv 9NQfX+IiTq4N6SQGKTFM6vMTvPbMlGr3/ZJBVOVwpMWsQh33XhfGjw6iXBXWi99o phBbeJXFKId/7XK1hQVw1EahaoWqdT+T7iueYeABJGnER17OMwhrvdc9gS7ysDQW idOtx9JuGHZYh/QQIqHFIi5MeZKYvMCDBqruB04l4bLJku4bip/bC38pdChj/5s2 1KIvDPwMQl3JGUVLeHqjUfMHa+dtroNKcEBspyh1Hi/PvU3Zuh8= =ERny -----END PGP SIGNATURE----- --Ku3u4cXKen+4nqzD--