unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: Tomas Volf <~@wolfsden.cz>
To: Arun Isaac <arunisaac@systemreboot.net>
Cc: 68289@debbugs.gnu.org, "Ludovic Courtès" <ludo@gnu.org>,
	"Fabio Natali" <me@fabionatali.com>
Subject: [bug#68289] [PATCH] services: xorg: Add xorg-start-command-xinit procedure.
Date: Thu, 30 May 2024 20:27:10 +0200	[thread overview]
Message-ID: <ZljE_o8uho-qeUqb@ws> (raw)
In-Reply-To: <87r0djkxw0.fsf@systemreboot.net>

[-- Attachment #1: Type: text/plain, Size: 1237 bytes --]

Hello,

On 2024-05-30 18:33:35 +0100, Arun Isaac wrote:
>
> Hi all,
>
> Thanks, Tomas for the patchset! And, thanks, Fabio and Ludo for
> reviewing it!
>
> I have pushed patch 1 with a few minor improvements.

Thank you for taking the time to merge this, all your changes look good :)

> Could you please add some documentation to the manual in patches 2 and 3 for
> the services added therein? Thanks! Once that's done, please send me an
> updated patchset and I'll push.

I have sent v3 containing just the two later patches.  I sent it to this issue
and also took the liberty of CC-ing you directly per the text above.  Hope it is
what you have imagined.

Uff, only now I realize I forgot to update the commit messages :/.  I will sent
v4.

>
> The changes I made to patch 1 are as follows:
> - I tweaked capture-stdout a little to use zero? and print out the
>   failing command.
> - In the documentation, I removed the part about the convenience
>   link. Since we will have dedicated system and home services for this,
>   it would be better to refer to those instead.
>
> Regards,
> Arun

Have a nice day,
Tomas Volf

--
There are only two hard things in Computer Science:
cache invalidation, naming things and off-by-one errors.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

  reply	other threads:[~2024-05-30 18:28 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-01-06 15:07 [bug#68289] [PATCH] services: xorg: Add xorg-start-command-xinit procedure Tomas Volf
2024-04-16 18:29 ` Fabio Natali via Guix-patches via
2024-04-17  9:30   ` Fabio Natali via Guix-patches via
2024-04-18 18:43     ` Fabio Natali via Guix-patches via
2024-04-18 21:17       ` Tomas Volf
2024-04-18 21:09     ` Tomas Volf
2024-04-19 12:25       ` Fabio Natali via Guix-patches via
2024-04-24 11:59         ` Fabio Natali via Guix-patches via
2024-04-24 17:43           ` Tomas Volf
2024-05-02  9:55             ` Ludovic Courtès
2024-05-02 14:58               ` Tomas Volf
2024-05-03  9:57                 ` Ludovic Courtès
2024-05-11 13:29                   ` Tomas Volf
2024-05-11 13:26 ` [bug#68289] [PATCH v2 1/3] " Tomas Volf
2024-05-11 13:26   ` [bug#68289] [PATCH v2 2/3] services: xorg: Add startx-command-service-type Tomas Volf
2024-05-11 13:26   ` [bug#68289] [PATCH v2 3/3] home: services: Add home-startx-command-service-type Tomas Volf
2024-05-30 17:33 ` [bug#68289] [PATCH] services: xorg: Add xorg-start-command-xinit procedure Arun Isaac
2024-05-30 18:27   ` Tomas Volf [this message]
2024-05-30 18:18 ` [bug#68289] [PATCH v3 1/2] services: xorg: Add startx-command-service-type Tomas Volf
2024-05-30 18:18   ` [bug#68289] [PATCH v3 2/2] home: services: Add home-startx-command-service-type Tomas Volf
2024-05-30 18:29 ` [bug#68289] [PATCH v4 1/2] services: xorg: Add startx-command-service-type Tomas Volf
2024-05-30 18:29   ` [bug#68289] [PATCH v4 2/2] home: services: Add home-startx-command-service-type Tomas Volf
2024-05-30 21:43 ` bug#68289: [PATCH] services: xorg: Add xorg-start-command-xinit procedure Arun Isaac

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZljE_o8uho-qeUqb@ws \
    --to=~@wolfsden.cz \
    --cc=68289@debbugs.gnu.org \
    --cc=arunisaac@systemreboot.net \
    --cc=ludo@gnu.org \
    --cc=me@fabionatali.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).