unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: "André Batista" <nandre@riseup.net>
To: Nigko Yerden <nigko.yerden@gmail.com>
Cc: 70341@debbugs.gnu.org
Subject: [bug#70341] [PATCH v4] services: tor: Add support for pluggable transports.
Date: Thu, 23 May 2024 18:49:23 -0300	[thread overview]
Message-ID: <Zk-54wo32jr0oeAO@andel> (raw)
In-Reply-To: <0983e0fb3aa290e1e0796c31c174bb2b7fdb615e.1715329922.git.nigko.yerden@gmail.com>

Hi Nigko,

I'm sorry for the delay. I can confirm that this patch works as
described and the instructions are clear and provide enough
information to setup a proper configuration.

Maybe my shortcoming regarding '#:mappings' gave you room for
improvement :)

There was only one typo that I should mention:

sex 10 mai 2024 às 13:32:02 (1715358722), nigko.yerden@gmail.com enviou:
> (...)
>
> diff --git a/doc/guix.texi b/doc/guix.texi
> index 1c1e0164e7..ae9bd7e290 100644
> --- a/doc/guix.texi
> +++ b/doc/guix.texi
>
> (...)
>
> @@ -21905,6 +21913,46 @@ Networking Services
>  @end table
>  @end deftp
>  
> +@cindex pluggable transports, tor
> +@deftp {Data Type} tor-transport-plugin
> +Data type representing a Tor pluggable transport plugin in
> +@code{tor-configuration}.  Plagguble transports are programs

You've exchanged 'a' for 'u' here ^ when typing Pluggable.

Other than that, all seem good to me and I find it to be a nice
little touch to Guix.

Let's wait for a maintainer to pick it up.

Cheers!




  reply	other threads:[~2024-05-23 21:50 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-04-11 14:48 [bug#70341] [PATCH] gnu: Add support for pluggable transports to tor-service-type Nigko Yerden
2024-04-20 14:43 ` [bug#70341] [PATCH v2] services: tor: Add support for pluggable transports Nigko Yerden
2024-04-22  3:58 ` [bug#70341] [PATCH v3] " Nigko Yerden
     [not found]   ` <Zil1buljj2AfL2zL@andel>
2024-04-25  6:08     ` Nigko Yerden
2024-04-30  9:13       ` Nigko Yerden
2024-05-10  8:32 ` [bug#70341] [PATCH v4] " Nigko Yerden
2024-05-23 21:49   ` André Batista [this message]
2024-05-31  5:43 ` [bug#70341] [PATCH v5] " Nigko Yerden
2024-07-11 13:27 ` [bug#70341] [PATCH v6] " Nigko Yerden
2024-08-09  9:15 ` [bug#70341] [PATCH v7] " Nigko Yerden
2024-09-04 14:08   ` Ludovic Courtès
2024-09-17 13:11 ` [bug#70341] [PATCH v8] " Nigko Yerden
2024-10-06 17:39 ` [bug#70341] [PATCH v9] " Nigko Yerden
2024-10-14 11:41   ` bug#70341: " Ludovic Courtès
2024-10-14 16:36     ` [bug#70341] " Nigko Yerden
2024-10-15  6:26     ` Nigko Yerden
2024-10-15 15:43       ` Ludovic Courtès

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Zk-54wo32jr0oeAO@andel \
    --to=nandre@riseup.net \
    --cc=70341@debbugs.gnu.org \
    --cc=nigko.yerden@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).