From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2.migadu.com ([2001:41d0:303:e16b::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms1.migadu.com with LMTPS id 8OERHCRFKWZDHwAAe85BDQ:P1 (envelope-from ) for ; Wed, 24 Apr 2024 19:45:08 +0200 Received: from aspmx1.migadu.com ([2001:41d0:303:e16b::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2.migadu.com with LMTPS id 8OERHCRFKWZDHwAAe85BDQ (envelope-from ) for ; Wed, 24 Apr 2024 19:45:08 +0200 X-Envelope-To: larch@yhetil.org Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=wolfsden.cz header.s=mail header.b=rzV72chX; dkim=fail ("headers rsa verify failed") header.d=wolfsden.cz header.s=mail header.b=rzV72chX; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=fail reason="SPF not aligned (relaxed)" header.from=wolfsden.cz (policy=none) ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1713980708; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post: dkim-signature; bh=fAm7nQBqUeRTVtjuE1XPXF4u3pTnAlc+9088yeQaUOc=; b=Uol/g725cO1ex04qOU0ANDUkyqeLp65rzABRx3YGRZjgTef+tZHGdoTeEaCkGd5eFNA/pm DyTyGSmhsOatO8dTROIr7SSq7VRJGBN5m7RihAe6WTrdKJN5Ln51G3kcdA92zqIRMry7Wg CiRR8bvhHJzon5Is8VsBGy0D+nhRIocJihBSOi7C9eELHZ2XB1CpBglKhw/daSNLtSYV8m GyeKa3kj6A4D2W3ayEKVq2fAwBiiXpNpswH2Hj/SdBf4faEAPK2p/2TfzZlb+OXjx3kG0E 41G7zhRz0UpQq4teVB85De9buL626Gt3C0G45/DlQGkBitVd/vX1oqnlWeCLeQ== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1713980708; a=rsa-sha256; cv=none; b=bzbYG4h+W0tHXBDBTftOARzoyvd0jMCdgNRvYI/W2RRSohZcqbKkv9tfEHrgNipkYfgW/q qv11lGiqnBdYY9vYk/8Ar/HetT0sPeL3s1iZKwtrkvhs8DOdS1SHnb30zxZ0O+FUN6ObW8 kVseL6V0p2/0GrsijiiqMSyvbb0W5f2Pd6xcAAQXYkRtboO9gMT6V169PAHLfSzTtuhTJ6 R6OwmlVe8V4smMB1fS1MDwsUaGH+PU4imLCJHKKcnqhDvMKgvJjzhSossHIPWYL37TyvHR NsE5AyVdI1nJUz0rHvvUmbbU/l49OjHHKhS2CuJEeftt1MCxvxiPQN3tVOWwHQ== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=wolfsden.cz header.s=mail header.b=rzV72chX; dkim=fail ("headers rsa verify failed") header.d=wolfsden.cz header.s=mail header.b=rzV72chX; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=fail reason="SPF not aligned (relaxed)" header.from=wolfsden.cz (policy=none) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 2CDA654DE9 for ; Wed, 24 Apr 2024 19:45:08 +0200 (CEST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rzgfz-00057W-8T; Wed, 24 Apr 2024 13:44:59 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rzgfx-00056y-25 for guix-patches@gnu.org; Wed, 24 Apr 2024 13:44:57 -0400 Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rzgfw-0005L2-F6 for guix-patches@gnu.org; Wed, 24 Apr 2024 13:44:56 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1rzggD-0000wX-8P for guix-patches@gnu.org; Wed, 24 Apr 2024 13:45:13 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#68289] [PATCH] services: xorg: Add xorg-start-command-xinit procedure. Resent-From: Tomas Volf <~@wolfsden.cz> Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Wed, 24 Apr 2024 17:45:12 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 68289 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Fabio Natali Cc: 68289@debbugs.gnu.org Received: via spool by 68289-submit@debbugs.gnu.org id=B68289.17139806683101 (code B ref 68289); Wed, 24 Apr 2024 17:45:12 +0000 Received: (at 68289) by debbugs.gnu.org; 24 Apr 2024 17:44:28 +0000 Received: from localhost ([127.0.0.1]:59612 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rzgfP-0000nK-Jm for submit@debbugs.gnu.org; Wed, 24 Apr 2024 13:44:27 -0400 Received: from wolfsden.cz ([37.205.8.62]:41682) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <~@wolfsden.cz>) id 1rzgfI-0000lU-Nf for 68289@debbugs.gnu.org; Wed, 24 Apr 2024 13:44:20 -0400 Received: by wolfsden.cz (Postfix, from userid 104) id 769DD28D50E; Wed, 24 Apr 2024 17:43:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=wolfsden.cz; s=mail; t=1713980636; bh=VTR87ubBcXgp+MmSMW4bYbMtlF2uAni6wQFW3F+2A4I=; h=Date:From:To:Cc:Subject:References:In-Reply-To; b=rzV72chXrdcBBReKzj8WCYH7LIaSRjSiT+BG9M7ZcjzpBUud/zDvoHlrEeLaNFw4W Rz46koBx/tvsWoFe2i0gslhqvtmSv1TwEeO4BiuQT8wqtpgyPvV9sencDZUCzyLenm EVghwUMDx+OXI601CO1cBijjNOhUSENgnI0ps+Jvclr6WJB3ODYhhvjcHM5FgYvF0G e0uh6UQdgmSV5APdp/zMHmDTmF/QMeF/+jTmlJwE5cnM9l7JBsvX9eKzuEIMob5Yy2 +/a66yBtJstmllMLuuC5/jAP2PPG3dELGXAl5Nu0hYH60yKHgk3ERyA5+YxRkp8uKy YY83IB/ejssDMWBICNCdYiDwzlVfGcT1eaJohYPgjKOmLbaeOSN/7IeN8xuDt/YR7C qmDFXjUYPjk2UITiLl3103b0+9JrNKwsOPrCJlEFc8a9VwmNMYJfPqlPFW29DF9btp rENShhLmGkB7M1ZukVJCi1AhSCVdpTGQCj5LSDWNVE8zz2Q3GW/QrHzjJ6SXLbAWVG +4U8DZ2QN3dFt8u/LZW6c3C+admdd/UOx28PghNbJ2eh2WECvBwpPHBJbczQAyn8Co HSjAXtdOMpBBIVFEx4VPrK8s5Uj3/4lJqkilHy+oZjQVQJmzyTueuN4pOhp+EXnemx 0L8ts88/U24ZWAPWy0kONcic= Received: from localhost (unknown [193.32.127.159]) by wolfsden.cz (Postfix) with ESMTPSA id 03B5E28B4CD; Wed, 24 Apr 2024 17:43:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=wolfsden.cz; s=mail; t=1713980636; bh=VTR87ubBcXgp+MmSMW4bYbMtlF2uAni6wQFW3F+2A4I=; h=Date:From:To:Cc:Subject:References:In-Reply-To; b=rzV72chXrdcBBReKzj8WCYH7LIaSRjSiT+BG9M7ZcjzpBUud/zDvoHlrEeLaNFw4W Rz46koBx/tvsWoFe2i0gslhqvtmSv1TwEeO4BiuQT8wqtpgyPvV9sencDZUCzyLenm EVghwUMDx+OXI601CO1cBijjNOhUSENgnI0ps+Jvclr6WJB3ODYhhvjcHM5FgYvF0G e0uh6UQdgmSV5APdp/zMHmDTmF/QMeF/+jTmlJwE5cnM9l7JBsvX9eKzuEIMob5Yy2 +/a66yBtJstmllMLuuC5/jAP2PPG3dELGXAl5Nu0hYH60yKHgk3ERyA5+YxRkp8uKy YY83IB/ejssDMWBICNCdYiDwzlVfGcT1eaJohYPgjKOmLbaeOSN/7IeN8xuDt/YR7C qmDFXjUYPjk2UITiLl3103b0+9JrNKwsOPrCJlEFc8a9VwmNMYJfPqlPFW29DF9btp rENShhLmGkB7M1ZukVJCi1AhSCVdpTGQCj5LSDWNVE8zz2Q3GW/QrHzjJ6SXLbAWVG +4U8DZ2QN3dFt8u/LZW6c3C+admdd/UOx28PghNbJ2eh2WECvBwpPHBJbczQAyn8Co HSjAXtdOMpBBIVFEx4VPrK8s5Uj3/4lJqkilHy+oZjQVQJmzyTueuN4pOhp+EXnemx 0L8ts88/U24ZWAPWy0kONcic= Date: Wed, 24 Apr 2024 19:43:54 +0200 From: Tomas Volf <~@wolfsden.cz> Message-ID: References: <87o7a9upoq.fsf@fabionatali.com> <87r0f4l4kb.fsf@fabionatali.com> <87zftpedyt.fsf@fabionatali.com> <87le53nf7o.fsf@fabionatali.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="Mwp9TWOjmyi+k3x/" Content-Disposition: inline In-Reply-To: <87le53nf7o.fsf@fabionatali.com> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Country: US X-Migadu-Flow: FLOW_IN X-Migadu-Spam-Score: -6.81 X-Spam-Score: -6.81 X-Migadu-Queue-Id: 2CDA654DE9 X-Migadu-Scanner: mx13.migadu.com X-TUID: FqFt8D57QcW4 --Mwp9TWOjmyi+k3x/ Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On 2024-04-24 12:59:55 +0100, Fabio Natali wrote: > On 2024-04-19, 13:25 +0100, Fabio Natali wrote: > > On 2024-04-18, 23:09 +0200, Tomas Volf <~@wolfsden.cz> wrote: > >> first, let me thank you for the review, and apologize for somewhat > >> late response, sadly I have been busy. > > Hi Tomas, > > Sorry for the slow follow-up. After some further testing and some input > from other Guix friends, this is my humble feedback on what I'd put in a > v2 patch. > > - Use Guix's 'invoke' instead of a custom 'checked-system*' procedure. > > - Where possible, use '#$(file-append foobar "/bin/foo")' instead of > '(string-append #$foobar "/bin/foo")', so that as much computation as > possible happens at build time as opposed to run time. It's a > microscopic difference, but still worth the change I think. > > What do you think? Not urgent, but do you think this is something you > might be interested to include in a v2? No problem if you're busy, but > let me know if there's anything I can help with. All sounds reasonable, will send v2, cannot guarantee when, hopefully this = week. > > Tangentally, with regard to 'capture-stdout', I'm exploring if this is > something that could be added to '(guix build utils)'=E2=81=B0 or perhaps > addressed in Guile=C2=B9 instead of Guix. This can be left as it is in the > patch, and potentially refactored away once a similar procedure is > available from Guix or Guile. > > Thanks, best wishes, Fabio. Yes, I noticed the thread. Having the option of doing basically (with-output-to-string (=CE=BB _ (invoke "date"))) would be amazing. I hope someone will take it up and implement. :) Have a nice day, Tomas -- There are only two hard things in Computer Science: cache invalidation, naming things and off-by-one errors. --Mwp9TWOjmyi+k3x/ Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCgAdFiEEt4NJs4wUfTYpiGikL7/ufbZ/wakFAmYpRNoACgkQL7/ufbZ/ wamScxAAlLzGrqwG2XhGk7eORqJQXYEkrGLxgFeP3IcJ5c6hPTEwIxeFeZ0OedlU tkANrlbBB10rAX1z+STeBkpq0ISuJzIoR/GSTWp4XIg4D0oYijH+n1DpIyIPz9s2 gAXcHkbVgTTbF1uJhhWllb+TLbpN9eFSiT/+v3jNYS4CdOOt0iwcLSV/aTOnY3yM U4hRIrC5/Xcx8VpCU7sID1VYHYjcaX9rhJGYl4rOcPCrrPBurEEoQENQIPCtkU7s CZ4GBeEs8zLXXv+atynCaH7szKOOtvNOcWhlSqw3FLHvDQdTfemF9IO8eXhvYhAH qz/WElkKESd9WrynEcdh2TXESlRGsGM58mFUpgdUFCes1gUtJdcFoCId9EpHEhPQ 07Xxi4VAVKDT975GW/rw76EfV+BHq3eyOFNHluoXXgWxbrh4hWrQEXAQiJUWpazt 2ppK/GKAJ2ZFodDP0JcG85jRbvTRZDjPTupil36gv/ge7OgBGwx/FfE87g83jag1 VrcWG2bT4ESbnNw1rp7pZiK9MIPf7I4SKhiuDWtdlfXAp6PVFlE9l10lXODZuVYs 7CLNo57Wn7LOTE9JxkNgc59HsuJspdSOdA55OFw7K+WAwX34ijGOIma0MclsvdMr OEGqIlwPcznUjOVyP7LINj2L8Bu92kqUZpr27iqoZMZlcZBgaNA= =Z5k3 -----END PGP SIGNATURE----- --Mwp9TWOjmyi+k3x/--