[bug#57111] [PATCH 00/56] gnu: crates-io: Allow build of various rust packages.

[bug#57111] [PATCH 00/56] gnu: crates-io: Allow build of various rust packages.

[Jean Pierre De Jesus DIAZ via Guix-patches via]

This patch series allows cargo-build-system to fully build and test
some of these packages. These are small rust packages though.

Probably were added without verifying if the crate could get built or
not. So these patches are mostly one liners removing `#:skip-build? #t'.

I did a quick pass over the crates to find the simpler ones, there are
more for sure but don't want to send hundreds of patches. I'll tackle
these easy ones first and then I'll proceed with most complex ones
on further patches that require adding new packages and modifying
existing ones.

I've tested all of these crates on x86_64 and they build without
problems.

Maxime I've CCed you as this could relate to antioxidant (as it
requires crates to build, am I right?).

—
Jean-Pierre De Jesus DIAZ

[bug#57111] [PATCH 01/56] gnu: rust-ab-glyph-rasterizer-0.1: Allow build.

[Jean-Pierre De Jesus DIAZ via Guix-patches via]

* gnu/packages/crates-io.scm (rust-ab-glyph-rasterizer-0.1)[arguments]:
  Remove `#:skip-build? #t'.
---
 gnu/packages/crates-io.scm | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/gnu/packages/crates-io.scm b/gnu/packages/crates-io.scm
index cfafce9aa3..8d46c5d9db 100644
--- a/gnu/packages/crates-io.scm
+++ b/gnu/packages/crates-io.scm
@@ -109,8 +109,7 @@ (define-public rust-ab-glyph-rasterizer-0.1
         (base32 "1zzz78231w849xslz9s0pwjj6gp02wfbbxdpysqhwwq1vqr5xznr"))))
     (build-system cargo-build-system)
     (arguments
-     `(#:skip-build? #t
-       #:cargo-inputs
+     `(#:cargo-inputs
        (("rust-libm" ,rust-libm-0.2))))
     (home-page "https://github.com/alexheretic/ab-glyph")
     (synopsis "Coverage rasterization for lines, quadratic & cubic beziers")
--
2.34.1

[bug#57111] [PATCH 02/56] gnu: rust-adaptive-barrier-0.1: Allow build.

[Jean-Pierre De Jesus DIAZ via Guix-patches via]

* gnu/packages/crates-io.scm (rust-adaptive-barrier-0.1)
  [arguments]: Remove `#:skip-build? #t'.
---
 gnu/packages/crates-io.scm | 1 -
 1 file changed, 1 deletion(-)

diff --git a/gnu/packages/crates-io.scm b/gnu/packages/crates-io.scm
index 8d46c5d9db..9f3475ba40 100644
--- a/gnu/packages/crates-io.scm
+++ b/gnu/packages/crates-io.scm
@@ -1631,7 +1631,6 @@ (define-public rust-adaptive-barrier-0.1
        (sha256
         (base32 "003ygsiqsd85v0p846q1ym23dbp4iagn89p7k6yrvbg9di1mbjqc"))))
     (build-system cargo-build-system)
-    (arguments `(#:skip-build? #t))
     (home-page "https://github.com/vorner/adaptive-barrier")
     (synopsis "Barrier with adaptable number of thread subsciptions")
     (description
--
2.34.1

[bug#57111] [PATCH 03/56] gnu: rust-aead-0.2: Allow build.

[Jean-Pierre De Jesus DIAZ via Guix-patches via]

* gnu/packages/crates-io.scm (rust-aead-0.2)[arguments]: Remove
  `#:skip-build? #t'.
---
 gnu/packages/crates-io.scm | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/gnu/packages/crates-io.scm b/gnu/packages/crates-io.scm
index 9f3475ba40..ab59c9452b 100644
--- a/gnu/packages/crates-io.scm
+++ b/gnu/packages/crates-io.scm
@@ -1949,8 +1949,7 @@ (define-public rust-aead-0.2
        (sha256
         (base32 "1r3ijikx9h117q0xgkc56yb0501kifjr3gsfp5bvnrz7asdipw2c"))))
     (arguments
-     `(#:skip-build? #t
-       #:cargo-inputs
+     `(#:cargo-inputs
        (("rust-generic-array" ,rust-generic-array-0.12)
         ("rust-heapless" ,rust-heapless-0.5))))))

--
2.34.1

[bug#57111] [PATCH 04/56] gnu: rust-aes-0.3: Allow build.

[Jean-Pierre De Jesus DIAZ via Guix-patches via]

* gnu/packages/crates-io.scm (rust-aes-0.3)[arguments]: Remove
  `#:skip-build? #t'.
---
 gnu/packages/crates-io.scm | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/gnu/packages/crates-io.scm b/gnu/packages/crates-io.scm
index ab59c9452b..dbe6298b8a 100644
--- a/gnu/packages/crates-io.scm
+++ b/gnu/packages/crates-io.scm
@@ -2033,8 +2033,7 @@ (define-public rust-aes-0.3
        (sha256
         (base32 "1j90iwpax0y1dqq14i8y9xgpcnnlgnljwkxg3mhzrralwf7ivssl"))))
     (arguments
-     `(#:skip-build? #t
-       #:cargo-inputs
+     `(#:cargo-inputs
        (("rust-aes-soft" ,rust-aes-soft-0.3)
         ("rust-aesni" ,rust-aesni-0.6)
         ("rust-block-cipher-trait" ,rust-block-cipher-trait-0.6))))))
--
2.34.1

[bug#57111] [PATCH 05/56] gnu: rust-aliasable-deref-trait-0.2: Allow build.

[Jean-Pierre De Jesus DIAZ via Guix-patches via]

* gnu/packages/crates-io.scm (rust-aliasable-deref-trait-0.2)
  [arguments]: Remove `#:skip-build? #t'.
---
 gnu/packages/crates-io.scm | 1 -
 1 file changed, 1 deletion(-)

diff --git a/gnu/packages/crates-io.scm b/gnu/packages/crates-io.scm
index dbe6298b8a..9b83fee8a3 100644
--- a/gnu/packages/crates-io.scm
+++ b/gnu/packages/crates-io.scm
@@ -2637,7 +2637,6 @@ (define-public rust-aliasable-deref-trait-0.2
        (sha256
         (base32 "0abzqsxd09jxl01brzjnwk8zg7k8zma76gzq87385q8fqm710jxb"))))
     (build-system cargo-build-system)
-    (arguments '(#:skip-build? #t))
     (home-page "https://github.com/avitex/rust-aliasable-deref-trait")
     (synopsis "Marker trait for aliasable pointers")
     (description
--
2.34.1

[bug#57111] [PATCH 06/56] gnu: rust-aliasable-0.1: Allow build.

[Jean-Pierre De Jesus DIAZ via Guix-patches via]

* gnu/packages/crates-io.scm (rust-aliasable-0.1)[arguments]: Remove
  `#:skip-build? #t'.
---
 gnu/packages/crates-io.scm | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/gnu/packages/crates-io.scm b/gnu/packages/crates-io.scm
index 9b83fee8a3..11a6adc96e 100644
--- a/gnu/packages/crates-io.scm
+++ b/gnu/packages/crates-io.scm
@@ -2657,8 +2657,7 @@ (define-public rust-aliasable-0.1
           (base32 "1z8548zdjlm4ps1k0d7x68lfdyji02crwcc9rw3q3bb106f643r5"))))
     (build-system cargo-build-system)
     (arguments
-      `(#:skip-build? #t
-        #:cargo-inputs
+      `(#:cargo-inputs
         (("rust-aliasable-deref-trait" ,rust-aliasable-deref-trait-0.2)
          ("rust-stable-deref-trait" ,rust-stable-deref-trait-1))))
     (home-page "https://github.com/avitex/rust-aliasable")
--
2.34.1

[bug#57111] [PATCH 07/56] gnu: rust-always-assert-0.1: Allow build.

[Jean-Pierre De Jesus DIAZ via Guix-patches via]

* gnu/packages/crates-io.scm (rust-always-assert-0.1)[arguments]: Remove
  `#:skip-build? #t'.
---
 gnu/packages/crates-io.scm | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/gnu/packages/crates-io.scm b/gnu/packages/crates-io.scm
index 11a6adc96e..2ba7e073a0 100644
--- a/gnu/packages/crates-io.scm
+++ b/gnu/packages/crates-io.scm
@@ -2726,8 +2726,7 @@ (define-public rust-always-assert-0.1
          "04ad9wbh70nii1ilcd1mxv85yqx18jf9vsmh3ddps886bmi8ixpv"))))
     (build-system cargo-build-system)
     (arguments
-     `(#:skip-build? #t
-       #:cargo-inputs (("rust-log" ,rust-log-0.4))))
+     `(#:cargo-inputs (("rust-log" ,rust-log-0.4))))
     (home-page
      "https://github.com/matklad/always-assert")
     (synopsis
--
2.34.1

[bug#57111] [PATCH 08/56] gnu: rust-anymap-0.12: Allow build.

[Jean-Pierre De Jesus DIAZ via Guix-patches via]

* gnu/packages/crates-io.scm (rust-anymap-0.12)[arguments]: Remove
  `#:skip-build? #t'.
---
 gnu/packages/crates-io.scm | 1 -
 1 file changed, 1 deletion(-)

diff --git a/gnu/packages/crates-io.scm b/gnu/packages/crates-io.scm
index 2ba7e073a0..37b52df4ff 100644
--- a/gnu/packages/crates-io.scm
+++ b/gnu/packages/crates-io.scm
@@ -2916,7 +2916,6 @@ (define-public rust-anymap-0.12
         (base32
          "0i23vv38i22aazp5z2hz0a44b943b6w5121kwwnpq1brpm1l559k"))))
     (build-system cargo-build-system)
-    (arguments `(#:skip-build? #t))
     (home-page
      "https://github.com/chris-morgan/anymap")
     (synopsis
--
2.34.1

[bug#57111] [PATCH 09/56] gnu: rust-approx-0.3: Allow build.Allow build.

[Jean-Pierre De Jesus DIAZ via Guix-patches via]

* gnu/packages/crates-io.scm (rust-approx-0.3)[arguments]: Remove
  `#:skip-build? #t'.
---
 gnu/packages/crates-io.scm | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/gnu/packages/crates-io.scm b/gnu/packages/crates-io.scm
index 37b52df4ff..3b64d2a104 100644
--- a/gnu/packages/crates-io.scm
+++ b/gnu/packages/crates-io.scm
@@ -3018,8 +3018,7 @@ (define-public rust-approx-0.3
         (base32
          "1hx580xjdxl3766js9b49rnbnmr8gw8c060809l43k9f0xshprph"))))
     (arguments
-     `(#:skip-build? #t
-       #:cargo-inputs
+     `(#:cargo-inputs
        (("rust-num-complex" ,rust-num-complex-0.2)
         ("rust-num-traits" ,rust-num-traits-0.2))))))

--
2.34.1

[bug#57111] [PATCH 10/56] gnu: rust-arbitrary-1: Allow build.

[Jean-Pierre De Jesus DIAZ via Guix-patches via]

* gnu/packages/crates-io.scm (rust-arbitrary-1)[arguments]: Remove
  `#:skip-build? #t'.
---
 gnu/packages/crates-io.scm | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/gnu/packages/crates-io.scm b/gnu/packages/crates-io.scm
index 3b64d2a104..1e75d26230 100644
--- a/gnu/packages/crates-io.scm
+++ b/gnu/packages/crates-io.scm
@@ -3051,8 +3051,7 @@ (define-public rust-arbitrary-1
         (base32 "14a6r7q9b1kf1m7810p8bcl51q11mrwc5z7fjkz0lx6kdvyk0x13"))))
     (build-system cargo-build-system)
     (arguments
-     `(#:skip-build? #t
-       #:cargo-inputs
+     `(#:cargo-inputs
        (("rust-derive-arbitrary" ,rust-derive-arbitrary-1))))
     (home-page "https://github.com/rust-fuzz/arbitrary")
     (synopsis "Trait for generating structured data from unstructured data")
--
2.34.1

[bug#57111] [PATCH 11/56] gnu: rust-arbitrary-0.4: Allow build.

[Jean-Pierre De Jesus DIAZ via Guix-patches via]

* gnu/packages/crates-io.scm (rust-arbitrary-0.4)[arguments]: Remove
  `#:skip-build? #t'.
---
 gnu/packages/crates-io.scm | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/gnu/packages/crates-io.scm b/gnu/packages/crates-io.scm
index 1e75d26230..c977d601e6 100644
--- a/gnu/packages/crates-io.scm
+++ b/gnu/packages/crates-io.scm
@@ -3078,8 +3078,7 @@ (define-public rust-arbitrary-0.4
        (sha256
         (base32 "0sa55cynafwzvlhyhfpm3vmi2fydj3ipdj5yfbaif7l56cixfmfv"))))
     (arguments
-     `(#:skip-build? #t
-       #:cargo-inputs
+     `(#:cargo-inputs
        (("rust-derive-arbitrary" ,rust-derive-arbitrary-0.4))))))

 (define-public rust-arbitrary-0.2
--
2.34.1

[bug#57111] [PATCH 12/56] gnu: rust-arc-swap-1: Allow build.

[Jean-Pierre De Jesus DIAZ via Guix-patches via]

* gnu/packages/crates-io.scm (rust-arc-swap-1)[arguments]: Remove
  `#:skip-build? #t'.
---
 gnu/packages/crates-io.scm | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/gnu/packages/crates-io.scm b/gnu/packages/crates-io.scm
index c977d601e6..4c65c57f53 100644
--- a/gnu/packages/crates-io.scm
+++ b/gnu/packages/crates-io.scm
@@ -3145,8 +3145,7 @@ (define-public rust-arc-swap-1
         (base32 "0wwdvayqa07grw4ljvb6plbw0wdg78jcdg3hwnlq2yqljlrxdmyl"))))
     (build-system cargo-build-system)
     (arguments
-     `(#:skip-build? #t
-       #:cargo-inputs
+     `(#:cargo-development-inputs
        (("rust-adaptive-barrier" ,rust-adaptive-barrier-0.1)
         ("rust-criterion" ,rust-criterion-0.3)
         ("rust-crossbeam-utils" ,rust-crossbeam-utils-0.8)
--
2.34.1

[bug#57111] [PATCH 13/56] gnu: rust-argh-shared-0.1: Allow build.

[Jean-Pierre De Jesus DIAZ via Guix-patches via]

* gnu/packages/crates-io.scm (rust-argh-shared-0.1)[arguments]: Remove
  `#:skip-build? #t'.
---
 gnu/packages/crates-io.scm | 1 -
 1 file changed, 1 deletion(-)

diff --git a/gnu/packages/crates-io.scm b/gnu/packages/crates-io.scm
index 4c65c57f53..210d3cf469 100644
--- a/gnu/packages/crates-io.scm
+++ b/gnu/packages/crates-io.scm
@@ -3221,7 +3221,6 @@ (define-public rust-argh-shared-0.1
         (sha256
           (base32 "0crzkzr4mq9gyys3m0idgsfwwrwd4dk70scp7rspvb2fmgd01piq"))))
     (build-system cargo-build-system)
-    (arguments `(#:skip-build? #t))
     (home-page "https://github.com/google/argh")
     (synopsis "Derive-based argument parsing optimized for code size")
     (description "Derive-based argument parsing optimized for code size")
--
2.34.1

[bug#57111] [PATCH 14/56] gnu: rust-argh-derive-0.1: Allow build.

[Jean-Pierre De Jesus DIAZ via Guix-patches via]

* gnu/packages/crates-io.scm (rust-argh-derive-0.1)[arguments]: Remove
  `#:skip-build? #t'.
---
 gnu/packages/crates-io.scm | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/gnu/packages/crates-io.scm b/gnu/packages/crates-io.scm
index 210d3cf469..2d852df335 100644
--- a/gnu/packages/crates-io.scm
+++ b/gnu/packages/crates-io.scm
@@ -3239,9 +3239,7 @@ (define-public rust-argh-derive-0.1
           (base32 "13qz9i9frdjl1v9aqw5b2cs7wn3h34x2xkpsi9wcl1hcpjd23ba8"))))
     (build-system cargo-build-system)
     (arguments
-      `(#:skip-build?
-        #t
-        #:cargo-inputs
+      `(#:cargo-inputs
         (("rust-argh-shared" ,rust-argh-shared-0.1)
          ("rust-heck" ,rust-heck-0.3)
          ("rust-proc-macro2" ,rust-proc-macro2-1)
--
2.34.1

[bug#57111] [PATCH 15/56] gnu: rust-array-macro-1: Allow build.

[Jean-Pierre De Jesus DIAZ via Guix-patches via]

* gnu/packages/crates-io.scm (rust-array-macro-1)[arguments]: Remove
  `#:skip-build? #t'.
---
 gnu/packages/crates-io.scm | 1 -
 1 file changed, 1 deletion(-)

diff --git a/gnu/packages/crates-io.scm b/gnu/packages/crates-io.scm
index 2d852df335..c90c97d7d8 100644
--- a/gnu/packages/crates-io.scm
+++ b/gnu/packages/crates-io.scm
@@ -3316,7 +3316,6 @@ (define-public rust-array-macro-1
        (sha256
         (base32 "19mdx2xlppnqwl6rhsbzylx61a0kkp2ql8q16195b7iga977ps86"))))
     (build-system cargo-build-system)
-    (arguments `(#:skip-build? #t))
     (home-page "https://gitlab.com/KonradBorowski/array-macro")
     (synopsis "Array multiple elements constructor syntax")
     (description "This package implements constructor syntax for arrays with
--
2.34.1

[bug#57111] [PATCH 16/56] gnu: rust-arrayvec-0.7: Allow build.

[Jean-Pierre De Jesus DIAZ via Guix-patches via]

* gnu/packages/crates-io.scm (rust-arrayvec-0.7)[arguments]: Remove
  `#:skip-build? #t'.
---
 gnu/packages/crates-io.scm | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/gnu/packages/crates-io.scm b/gnu/packages/crates-io.scm
index c90c97d7d8..0a0013114e 100644
--- a/gnu/packages/crates-io.scm
+++ b/gnu/packages/crates-io.scm
@@ -3385,8 +3385,7 @@ (define-public rust-arrayvec-0.7
          "1xza6jbs8x51yhh4qnwjw1crm33bhl975r965fpq1hqhpfq5hbss"))))
     (build-system cargo-build-system)
     (arguments
-     `(#:skip-build? #t
-       #:cargo-inputs
+     `(#:cargo-inputs
        (("rust-serde" ,rust-serde-1))
        #:cargo-development-inputs
        (("rust-bencher" ,rust-bencher-0.1)
--
2.34.1

[bug#57111] [PATCH 17/56] gnu: rust-arrayvec-0.5: Allow build.

[Jean-Pierre De Jesus DIAZ via Guix-patches via]

* gnu/packages/crates-io.scm (rust-arrayvec-0.5)[arguments]: Remove
  `#:skip-build? #t'.
---
 gnu/packages/crates-io.scm | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/gnu/packages/crates-io.scm b/gnu/packages/crates-io.scm
index 0a0013114e..944172d232 100644
--- a/gnu/packages/crates-io.scm
+++ b/gnu/packages/crates-io.scm
@@ -3414,8 +3414,7 @@ (define-public rust-arrayvec-0.5
         (base32
          "12q6hn01x5435bprwlb7w9m7817dyfq55yrl4psygr78bp32zdi3"))))
     (arguments
-     `(#:skip-build? #t
-       #:cargo-inputs
+     `(#:cargo-inputs
        (("rust-serde" ,rust-serde-1))
        #:cargo-development-inputs
        (("rust-bencher" ,rust-bencher-0.1)
--
2.34.1

[bug#57111] [PATCH 18/56] gnu: rust-arrayvec-0.4: Allow build.

[Jean-Pierre De Jesus DIAZ via Guix-patches via]

* gnu/packages/crates-io.scm (rust-arrayvec-0.4)[arguments]: Remove
  `#:skip-build? #f'.
---
 gnu/packages/crates-io.scm | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/gnu/packages/crates-io.scm b/gnu/packages/crates-io.scm
index 944172d232..ec1d117c42 100644
--- a/gnu/packages/crates-io.scm
+++ b/gnu/packages/crates-io.scm
@@ -3436,8 +3436,7 @@ (define-public rust-arrayvec-0.4
         (base32
          "1fdiv5m627gh6flp4mpmi1mh647imm9x423licsr11psz97d97yd"))))
     (arguments
-     `(#:skip-build? #t
-       #:cargo-inputs
+     `(#:cargo-inputs
        (("rust-nodrop" ,rust-nodrop-0.1)
         ("rust-serde" ,rust-serde-1))
        #:cargo-development-inputs
--
2.34.1

[bug#57111] [PATCH 19/56] gnu: rust-ascii-1: Allow build.

[Jean-Pierre De Jesus DIAZ via Guix-patches via]

* gnu/packages/crates-io.scm (rust-ascii-1)[arguments]: Remove
  `#:skip-build? #t'.
---
 gnu/packages/crates-io.scm | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/gnu/packages/crates-io.scm b/gnu/packages/crates-io.scm
index ec1d117c42..42f6f402cc 100644
--- a/gnu/packages/crates-io.scm
+++ b/gnu/packages/crates-io.scm
@@ -3878,8 +3878,7 @@ (define-public rust-ascii-1
           "0281gc828q4j692gb66jfdr5k16gyszgqflylh0pp30rllv63xdv"))))
     (build-system cargo-build-system)
     (arguments
-     `(#:skip-build? #t
-       #:cargo-inputs
+     `(#:cargo-inputs
        (("rust-serde" ,rust-serde-1)
         ("rust-serde-test" ,rust-serde-test-1))))
     (home-page "https://github.com/tomprogrammer/rust-ascii")
--
2.34.1

[bug#57111] [PATCH 20/56] gnu: rust-ascii-0.8: Allow build.

[Jean-Pierre De Jesus DIAZ via Guix-patches via]

* gnu/packages/crates-io.scm (rust-ascii-0.8)[arguments]: Remove
  `#:skip-build? #t'.
---
 gnu/packages/crates-io.scm | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/gnu/packages/crates-io.scm b/gnu/packages/crates-io.scm
index 42f6f402cc..869755b29e 100644
--- a/gnu/packages/crates-io.scm
+++ b/gnu/packages/crates-io.scm
@@ -3923,8 +3923,7 @@ (define-public rust-ascii-0.8
         (base32 "051gh2bgjq90s0f0i0hd9p4z4fpg5k82b570d1223jj7rhd8kglp"))))
     (build-system cargo-build-system)
     (arguments
-     `(#:skip-build? #t
-       #:cargo-inputs
+     `(#:cargo-inputs
        (("rust-quickcheck" ,rust-quickcheck-0.4))))))

 (define-public rust-ascii-utils-0.9
--
2.34.1

[bug#57111] [PATCH 21/56] gnu: rust-ascii-utils-0.9: Allow build.

[Jean-Pierre De Jesus DIAZ via Guix-patches via]

* gnu/packages/crates-io.scm (rust-ascii-utils-0.9)[arguments]: Remove
  `#:skip-build? #t'.
---
 gnu/packages/crates-io.scm | 1 -
 1 file changed, 1 deletion(-)

diff --git a/gnu/packages/crates-io.scm b/gnu/packages/crates-io.scm
index 869755b29e..28f843fdfb 100644
--- a/gnu/packages/crates-io.scm
+++ b/gnu/packages/crates-io.scm
@@ -3938,7 +3938,6 @@ (define-public rust-ascii-utils-0.9
        (sha256
         (base32 "0jpp550pwi38msflpy7lnqm2r153kn9k19bss6k9ak9yacq8z4vi"))))
     (build-system cargo-build-system)
-    (arguments `(#:skip-build? #t))
     (home-page "https://github.com/tredoe/ascii_utils")
     (synopsis "Utilities to handle ASCII characters")
     (description
--
2.34.1

[bug#57111] [PATCH 22/56] gnu: rust-assert-0.7: Allow build.

[Jean-Pierre De Jesus DIAZ via Guix-patches via]

* gnu/packages/crates-io.scm (rust-assert-0.7)[arguments]: Remove
  `#:skip-build? #t'.
---
 gnu/packages/crates-io.scm | 1 -
 1 file changed, 1 deletion(-)

diff --git a/gnu/packages/crates-io.scm b/gnu/packages/crates-io.scm
index 28f843fdfb..39f8f41f4c 100644
--- a/gnu/packages/crates-io.scm
+++ b/gnu/packages/crates-io.scm
@@ -3956,7 +3956,6 @@ (define-public rust-assert-0.7
        (sha256
         (base32 "1hnph97yz3hpf71s4rdzcrgd492d1m7rj0k48ymxl1w5d2g8v450"))))
     (build-system cargo-build-system)
-    (arguments `(#:skip-build? #t))
     (home-page "https://github.com/stainless-steel/assert")
     (synopsis "Assertions for testing")
     (description "This package provides assertions for testing.")
--
2.34.1

[bug#57111] [PATCH 23/56] gnu: rust-assert-approx-eq-1: Allow build.

[Jean-Pierre De Jesus DIAZ via Guix-patches via]

* gnu/packages/crates-io.scm (rust-assert-approx-eq-1)[arguments]:
  Remove `#:skip-build? #t'.
---
 gnu/packages/crates-io.scm | 1 -
 1 file changed, 1 deletion(-)

diff --git a/gnu/packages/crates-io.scm b/gnu/packages/crates-io.scm
index 39f8f41f4c..2d7affba54 100644
--- a/gnu/packages/crates-io.scm
+++ b/gnu/packages/crates-io.scm
@@ -3973,7 +3973,6 @@ (define-public rust-assert-approx-eq-1
        (sha256
         (base32 "1zagfwfad5wssmr830gk3489f97ppczv6xs627jxniwm6ssdl1rw"))))
     (build-system cargo-build-system)
-    (arguments '(#:skip-build? #t))
     (home-page "https://github.com/ashleygwilliams/assert_approx_eq")
     (synopsis "Assert approximately equal")
     (description
--
2.34.1

[bug#57111] [PATCH 24/56] gnu: rust-assert-impl-0.1: Allow build.

[Jean-Pierre De Jesus DIAZ via Guix-patches via]

* gnu/packages/crates-io.scm (rust-assert-impl-0.1)[arguments]: Remove
  `#:skip-build? #t'.
---
 gnu/packages/crates-io.scm | 1 -
 1 file changed, 1 deletion(-)

diff --git a/gnu/packages/crates-io.scm b/gnu/packages/crates-io.scm
index 2d7affba54..2f5c6b83f4 100644
--- a/gnu/packages/crates-io.scm
+++ b/gnu/packages/crates-io.scm
@@ -4149,7 +4149,6 @@ (define-public rust-assert-impl-0.1
        (sha256
         (base32 "17jvig9rwdc1sf1j5q8q9k69njg3k8g7x7g6wcb711hcvq9l6in3"))))
     (build-system cargo-build-system)
-    (arguments `(#:skip-build? #t))
     (home-page "https://github.com/upsuper/assert-impl")
     (synopsis "Macro for static assert that types implement a trait or not")
     (description
--
2.34.1

[bug#57111] [PATCH 25/56] gnu: rust-async-datagram-3: Allow build.

[Jean-Pierre De Jesus DIAZ via Guix-patches via]

* gnu/packages/crates-io.scm (rust-async-datagram-3)[arguments]: Remove
  `#:skip-build? #t'.
---
 gnu/packages/crates-io.scm | 1 -
 1 file changed, 1 deletion(-)

diff --git a/gnu/packages/crates-io.scm b/gnu/packages/crates-io.scm
index 2f5c6b83f4..6a344a0cb8 100644
--- a/gnu/packages/crates-io.scm
+++ b/gnu/packages/crates-io.scm
@@ -4348,7 +4348,6 @@ (define-public rust-async-datagram-3
        (sha256
         (base32 "0k4kiy67d24ay8l7xrfjpsa4zkmhxv97ddj0f16rcv61qkky3i4f"))))
     (build-system cargo-build-system)
-    (arguments `(#:skip-build? #t))
     (home-page "https://github.com/rustasync/async-datagram")
     (synopsis "Async datagram traits")
     (description "This package provides asynchronous datagram traits.")
--
2.34.1

[bug#57111] [PATCH 26/56] gnu: rust-atomic-polyfill-0.1: Allow build.

[Jean-Pierre De Jesus DIAZ via Guix-patches via]

* gnu/packages/crates-io.scm (rust-atomic-polyfill-0.1)
  [arguments]: Remove `#:skip-build? #t'.
---
 gnu/packages/crates-io.scm | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/gnu/packages/crates-io.scm b/gnu/packages/crates-io.scm
index 6a344a0cb8..734e087a60 100644
--- a/gnu/packages/crates-io.scm
+++ b/gnu/packages/crates-io.scm
@@ -5124,8 +5124,7 @@ (define-public rust-atomic-polyfill-0.1
         (base32 "0hk08pdp6dgxqhy05l75518svrrrm7c1shfn51dk4claad4dg1p6"))))
     (build-system cargo-build-system)
     (arguments
-     `(#:skip-build? #t
-       #:cargo-inputs
+     `(#:cargo-inputs
        (("rust-critical-section" ,rust-critical-section-0.2)
         ("rust-riscv-target" ,rust-riscv-target-0.1))))
     (home-page "https://github.com/embassy-rs/atomic-polyfill")
--
2.34.1

[bug#57111] [PATCH 27/56] gnu: rust-atty-0.2: Allow build.

[Jean-Pierre De Jesus DIAZ via Guix-patches via]

* gnu/packages/crates-io.scm (rust-atty-0.2)[arguments]: Remove
  `#:skip-build? #t'.
---
 gnu/packages/crates-io.scm | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/gnu/packages/crates-io.scm b/gnu/packages/crates-io.scm
index 734e087a60..e7d828915c 100644
--- a/gnu/packages/crates-io.scm
+++ b/gnu/packages/crates-io.scm
@@ -5168,7 +5168,7 @@ (define-public rust-atty-0.2
          "1s7yslcs6a28c5vz7jwj63lkfgyx8mx99fdirlhi9lbhhzhrpcyr"))))
     (build-system cargo-build-system)
     (arguments
-     `(#:skip-build? #t
+     `(#:tests? #f ;; tests expect a tty
        #:cargo-inputs
        (("rust-hermit-abi" ,rust-hermit-abi-0.1)
         ("rust-libc" ,rust-libc-0.2)
--
2.34.1

[bug#57111] [PATCH 28/56] gnu: rust-bare-metal-0.2: Allow build.

[Jean-Pierre De Jesus DIAZ via Guix-patches via]

* gnu/packages/crates-io.scm (rust-bare-metal-0.2)[arguments]: Remove
  `#:skip-build? #t'.
---
 gnu/packages/crates-io.scm | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/gnu/packages/crates-io.scm b/gnu/packages/crates-io.scm
index e7d828915c..e5c4b63074 100644
--- a/gnu/packages/crates-io.scm
+++ b/gnu/packages/crates-io.scm
@@ -5680,8 +5680,7 @@ (define-public rust-bare-metal-0.2
        (sha256
         (base32 "1cy5pbb92fznnri72y6drfpjxj4qdmd62f0rrlgy70dxlppn9ssx"))))
     (arguments
-     `(#:skip-build? #t
-       #:cargo-inputs
+     `(#:cargo-inputs
        (("rust-rustc-version" ,rust-rustc-version-0.2))))))

 (define-public rust-barrel-0.6
--
2.34.1

[bug#57111] [PATCH 29/56] gnu: rust-base64-0.13: Allow build.

[Jean-Pierre De Jesus DIAZ via Guix-patches via]

* gnu/packages/crates-io.scm (rust-base64-0.13)[arguments]: Remove
  `#:skip-build? #t'.
---
 gnu/packages/crates-io.scm | 19 ++++++++-----------
 1 file changed, 8 insertions(+), 11 deletions(-)

diff --git a/gnu/packages/crates-io.scm b/gnu/packages/crates-io.scm
index e5c4b63074..77896acce2 100644
--- a/gnu/packages/crates-io.scm
+++ b/gnu/packages/crates-io.scm
@@ -5758,21 +5758,18 @@ (define-public rust-base64-0.13
        (file-name
         (string-append name "-" version ".tar.gz"))
        (sha256
-        (base32 "1z82g23mbzjgijkpcrilc7nljpxpvpf7zxf6iyiapkgka2ngwkch"))))
+        (base32 "1z82g23mbzjgijkpcrilc7nljpxpvpf7zxf6iyiapkgka2ngwkch"))
+       (modules '((guix build utils)))
+       (snippet
+         ;; Relax rust-criterion-0.3 version.
+         '(substitute* "Cargo.toml"
+             (("0\\.3\\.2") "0.3")))))
     (build-system cargo-build-system)
     (arguments
-     `(#:skip-build? #t
-       #:cargo-development-inputs
+     `(#:cargo-development-inputs
        (("rust-criterion" ,rust-criterion-0.3)
         ("rust-rand" ,rust-rand-0.6)
-        ("rust-structopt" ,rust-structopt-0.3))
-       #:phases
-        (modify-phases %standard-phases
-         (add-after 'unpack 'fix-criterion-minor-version
-          (lambda* _
-           (substitute* "Cargo.toml"
-             (("0\\.3\\.2")
-              ,(package-version rust-criterion-0.3))))))))
+        ("rust-structopt" ,rust-structopt-0.3))))
     (home-page "https://github.com/marshallpierce/rust-base64")
     (synopsis "Encodes and decodes base64 as bytes or utf8")
     (description
--
2.34.1

[bug#57111] [PATCH 30/56] gnu: rust-base-x-0.2: Allow build.

[Jean-Pierre De Jesus DIAZ via Guix-patches via]

* gnu/packages/crates-io.scm (rust-base-x-0.2)[arguments]: Remove
  `#:skip-build? #t'.
---
 gnu/packages/crates-io.scm | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/gnu/packages/crates-io.scm b/gnu/packages/crates-io.scm
index 77896acce2..7858d8f7d2 100644
--- a/gnu/packages/crates-io.scm
+++ b/gnu/packages/crates-io.scm
@@ -5929,8 +5929,7 @@ (define-public rust-base-x-0.2
          "1hfy0wv7j5ynd73yk1vyr32pqa77rp15lkrc54f8ky9c6hcbc80v"))))
     (build-system cargo-build-system)
     (arguments
-     `(#:skip-build? #t
-       #:cargo-development-inputs
+     `(#:cargo-development-inputs
        (("rust-bencher" ,rust-bencher-0.1)
         ("rust-json" ,rust-json-0.11)
         ("rust-rand" ,rust-rand-0.3))))
--
2.34.1

[bug#57111] [PATCH 31/56] gnu: rust-beef-0.5: Allow build.

[Jean-Pierre De Jesus DIAZ via Guix-patches via]

* gnu/packages/crates-io.scm (rust-beef-0.5)[arguments]: Remove
  `#:skip-build? #t'.
---
 gnu/packages/crates-io.scm | 8 +++++---
 1 file changed, 5 insertions(+), 3 deletions(-)

diff --git a/gnu/packages/crates-io.scm b/gnu/packages/crates-io.scm
index 7858d8f7d2..a4f6412a2e 100644
--- a/gnu/packages/crates-io.scm
+++ b/gnu/packages/crates-io.scm
@@ -6044,9 +6044,11 @@ (define-public rust-beef-0.5
         (base32 "02blba0j192l0374kqwn8rjsc8aifj43xi26v142ijpjim1f4dk7"))))
     (build-system cargo-build-system)
     (arguments
-     `(#:skip-build? #t
-       #:cargo-inputs
-       (("rust-serde" ,rust-serde-1))))
+     `(#:cargo-inputs
+       (("rust-serde" ,rust-serde-1))
+       #:cargo-development-inputs
+       (("rust-serde-derive" ,rust-serde-derive-1)
+        ("rust-serde-json" ,rust-serde-json-1))))
     (home-page "https://github.com/maciejhirsz/beef")
     (synopsis "Faster, more compact implementation of Cow")
     (description "This package provides faster, more compact implementation of
--
2.34.1

[bug#57111] [PATCH 32/56] gnu: rust-bigdecimal-0.3: Allow build.

[Jean-Pierre De Jesus DIAZ via Guix-patches via]

* gnu/packages/crates-io.scm (rust-bigdecimal-0.3)[arguments]: Remove
  `#:skip-build? #t'.
---
 gnu/packages/crates-io.scm | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/gnu/packages/crates-io.scm b/gnu/packages/crates-io.scm
index a4f6412a2e..33ea487069 100644
--- a/gnu/packages/crates-io.scm
+++ b/gnu/packages/crates-io.scm
@@ -6116,8 +6116,7 @@ (define-public rust-bigdecimal-0.3
         (base32 "0i1px8hk4l71n307c7h7igrdy37pzpm7dcni269gwab438ak7bva"))))
     (build-system cargo-build-system)
     (arguments
-     `(#:skip-build? #t
-       #:cargo-inputs
+     `(#:cargo-inputs
        (("rust-num-bigint" ,rust-num-bigint-0.4)
         ("rust-num-integer" ,rust-num-integer-0.1)
         ("rust-num-traits" ,rust-num-traits-0.2)
--
2.34.1

[bug#57111] [PATCH 33/56] gnu: rust-bitfield-0.13: Allow build.

[Jean-Pierre De Jesus DIAZ via Guix-patches via]

* gnu/packages/crates-io.scm (rust-bitfield-0.13)[arguments]: Remove
  `#:skip-build? #t'.
---
 gnu/packages/crates-io.scm | 1 -
 1 file changed, 1 deletion(-)

diff --git a/gnu/packages/crates-io.scm b/gnu/packages/crates-io.scm
index 33ea487069..12fd175217 100644
--- a/gnu/packages/crates-io.scm
+++ b/gnu/packages/crates-io.scm
@@ -7107,7 +7107,6 @@ (define-public rust-bitfield-0.13
        (sha256
         (base32 "06g7jb5r2b856vnhx76081fg90jvmy61kjqcfjysgmd5hclvvbs6"))))
     (build-system cargo-build-system)
-    (arguments `(#:skip-build? #t))
     (home-page "https://github.com/dzamlo/rust-bitfield")
     (synopsis "Macros to generate bitfield-like struct")
     (description
--
2.34.1

[bug#57111] [PATCH 34/56] gnu: rust-bitstream-io-1: Allow build.

[Jean-Pierre De Jesus DIAZ via Guix-patches via]

* gnu/packages/crates-io.scm (rust-bitstream-io-1)[arguments]: Remove
  `#:skip-build? #t'.
---
 gnu/packages/crates-io.scm | 1 -
 1 file changed, 1 deletion(-)

diff --git a/gnu/packages/crates-io.scm b/gnu/packages/crates-io.scm
index 12fd175217..7943c32db0 100644
--- a/gnu/packages/crates-io.scm
+++ b/gnu/packages/crates-io.scm
@@ -7317,7 +7317,6 @@ (define-public rust-bitstream-io-1
        (sha256
         (base32 "01pyk3pipwcbaghi7f0lmp3izjl902cv21yf4b1v5nipkrrrqlq3"))))
     (build-system cargo-build-system)
-    (arguments `(#:skip-build? #t))
     (home-page "https://github.com/tuffy/bitstream-io")
     (synopsis "Read/write un-aligned values from big or little-endian streams")
     (description
--
2.34.1

[bug#57111] [PATCH 35/56] gnu: rust-bitstream-io-0.8: Allow build.

[Jean-Pierre De Jesus DIAZ via Guix-patches via]

* gnu/packages/crates-io.scm (rust-bitstream-io-0.8)[arguments]: Remove
  `#:skip-build? #t'.
---
 gnu/packages/crates-io.scm | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/gnu/packages/crates-io.scm b/gnu/packages/crates-io.scm
index 7943c32db0..32f3119a71 100644
--- a/gnu/packages/crates-io.scm
+++ b/gnu/packages/crates-io.scm
@@ -7337,8 +7337,7 @@ (define-public rust-bitstream-io-0.8
         (string-append name "-" version ".tar.gz"))
        (sha256
         (base32
-         "00a6wy54s1dmadm5xz8k2cbsd7ixvm48mlc45bk0fdy0pbra6jk1"))))
-    (arguments `(#:skip-build? #t))))
+         "00a6wy54s1dmadm5xz8k2cbsd7ixvm48mlc45bk0fdy0pbra6jk1"))))))

 (define-public rust-bitvec-0.22
   (package
--
2.34.1

[bug#57111] [PATCH 36/56] gnu: rust-blobby-0.1: Allow build.

[Jean-Pierre De Jesus DIAZ via Guix-patches via]

* gnu/packages/crates-io.scm (rust-blobby-0.1)[arguments]: Remove
  `#:skip-build? #t'.
---
 gnu/packages/crates-io.scm | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/gnu/packages/crates-io.scm b/gnu/packages/crates-io.scm
index 32f3119a71..78f366e99e 100644
--- a/gnu/packages/crates-io.scm
+++ b/gnu/packages/crates-io.scm
@@ -7624,8 +7624,7 @@ (define-public rust-blobby-0.1
          "1xicpf3s2mi5xqnx8ps5mdych4ib5nh2nfsbrsg8ar8bjk1girbg"))))
     (build-system cargo-build-system)
     (arguments
-     `(#:skip-build? #t
-       #:cargo-inputs
+     `(#:cargo-inputs
        (("rust-byteorder" ,rust-byteorder-1))
        #:cargo-development-inputs
        (("rust-byteorder" ,rust-byteorder-1)
--
2.34.1

[bug#57111] [PATCH 37/56] gnu: rust-block-buffer-0.10: Allow build.

[Jean-Pierre De Jesus DIAZ via Guix-patches via]

* gnu/packages/crates-io.scm (rust-block-buffer-0.10)[arguments]: Remove
  `#:skip-build? #t'.
---
 gnu/packages/crates-io.scm | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/gnu/packages/crates-io.scm b/gnu/packages/crates-io.scm
index 78f366e99e..54e2c51563 100644
--- a/gnu/packages/crates-io.scm
+++ b/gnu/packages/crates-io.scm
@@ -7669,8 +7669,7 @@ (define-public rust-block-buffer-0.10
           "15cbh9jbcfcbbi863dlmamjka2f8l55ld915vr0b0xlf0l16mlzi"))))
     (build-system cargo-build-system)
     (arguments
-     `(#:skip-build? #t
-       #:cargo-inputs
+     `(#:cargo-inputs
        (("rust-generic-array" ,rust-generic-array-0.14))))
     (home-page "https://github.com/RustCrypto/utils")
     (synopsis "Fixed size buffer for block processing of data")
--
2.34.1

[bug#57111] [PATCH 38/56] gnu: rust-block-buffer-0.3: Allow build.

[Jean-Pierre De Jesus DIAZ via Guix-patches via]

* gnu/packages/crates-io.scm (rust-block-buffer-0.3)[arguments]: Remove
  `#:skip-build? #t'.
---
 gnu/packages/crates-io.scm | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/gnu/packages/crates-io.scm b/gnu/packages/crates-io.scm
index 54e2c51563..0181e95e89 100644
--- a/gnu/packages/crates-io.scm
+++ b/gnu/packages/crates-io.scm
@@ -7751,8 +7751,7 @@ (define-public rust-block-buffer-0.3
        (sha256
         (base32 "1axki8f4rhnxvk6hlli4i53sgmi7c15ffryrv4757nzcp6cc4xm0"))))
     (arguments
-     `(#:skip-build? #t
-       #:cargo-inputs
+     `(#:cargo-inputs
        (("rust-arrayref" ,rust-arrayref-0.3)
         ("rust-byte-tools" ,rust-byte-tools-0.2))))))

--
2.34.1

[bug#57111] [PATCH 39/56] gnu: rust-block-buffer-0.2: Allow build.

[Jean-Pierre De Jesus DIAZ via Guix-patches via]

* gnu/packages/crates-io.scm (rust-block-buffer-0.2)[arguments]: Remove
  `#:skip-build? #t'.
---
 gnu/packages/crates-io.scm | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/gnu/packages/crates-io.scm b/gnu/packages/crates-io.scm
index 0181e95e89..a445cba25f 100644
--- a/gnu/packages/crates-io.scm
+++ b/gnu/packages/crates-io.scm
@@ -7768,8 +7768,7 @@ (define-public rust-block-buffer-0.2
        (sha256
         (base32 "055q90a6vk80j85i3fixjd5ci0dznrm9lkdd6xbjk7sx5w2a2f8k"))))
     (arguments
-     `(#:skip-build? #t
-       #:cargo-inputs
+     `(#:cargo-inputs
        (("rust-byte-tools" ,rust-byte-tools-0.2)
         ("rust-generic-array" ,rust-generic-array-0.8))))))

--
2.34.1

[bug#57111] [PATCH 40/56] gnu: rust-block-cipher-trait-0.6: Allow build.

[Jean-Pierre De Jesus DIAZ via Guix-patches via]

* gnu/packages/crates-io.scm (rust-block-cipher-trait-0.6)[arguments]:
  Remove `#:skip-build? #t'.
---
 gnu/packages/crates-io.scm | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/gnu/packages/crates-io.scm b/gnu/packages/crates-io.scm
index a445cba25f..33efdfa56e 100644
--- a/gnu/packages/crates-io.scm
+++ b/gnu/packages/crates-io.scm
@@ -7808,8 +7808,7 @@ (define-public rust-block-cipher-trait-0.6
         (base32 "0x273w6fwka0i48nrv428birdrs2jz6jdnmc0dhc1rq9pm4lv4hw"))))
     (build-system cargo-build-system)
     (arguments
-     `(#:skip-build? #t
-       #:cargo-inputs
+     `(#:cargo-inputs
        (("rust-blobby" ,rust-blobby-0.1)
         ("rust-generic-array" ,rust-generic-array-0.12))))
     (home-page "https://github.com/RustCrypto/block-ciphers")
--
2.34.1

[bug#57111] [PATCH 41/56] gnu: rust-boxfnonce-0.1: Allow build.

[Jean-Pierre De Jesus DIAZ via Guix-patches via]

* gnu/packages/crates-io.scm (rust-boxfnonce-0.1)[arguments]: Remove
  `#:skip-build? #t'.
---
 gnu/packages/crates-io.scm | 1 -
 1 file changed, 1 deletion(-)

diff --git a/gnu/packages/crates-io.scm b/gnu/packages/crates-io.scm
index 33efdfa56e..79e64b315d 100644
--- a/gnu/packages/crates-io.scm
+++ b/gnu/packages/crates-io.scm
@@ -8028,7 +8028,6 @@ (define-public rust-boxfnonce-0.1
        (sha256
         (base32 "09ilf4zyx92hyhkxlsxksfyprzr9iwq5gqqb22aaqr32c8fwp22r"))))
     (build-system cargo-build-system)
-    (arguments `(#:skip-build? #t))
     (home-page "https://github.com/stbuehler/rust-boxfnonce")
     (synopsis "Safe FnOnce boxing for Rust")
     (description "This package provides a safe FnOnce boxing for Rust.")
--
2.34.1

[bug#57111] [PATCH 42/56] gnu: rust-buf-redux-0.8: Allow build.

[Jean-Pierre De Jesus DIAZ via Guix-patches via]

* gnu/packages/crates-io.scm (rust-buf-redux-0.8)[arguments]: Remove
  `#:skip-build? #t'.
---
 gnu/packages/crates-io.scm | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/gnu/packages/crates-io.scm b/gnu/packages/crates-io.scm
index 79e64b315d..92fc3bcd62 100644
--- a/gnu/packages/crates-io.scm
+++ b/gnu/packages/crates-io.scm
@@ -8384,8 +8384,7 @@ (define-public rust-buf-redux-0.8
         (base32 "0zy0p4vd2kjk7z5m4m8kdwhs5cmx1z02n7v36njhgfs8fs4aclxr"))))
     (build-system cargo-build-system)
     (arguments
-     `(#:skip-build? #t
-       #:cargo-inputs
+     `(#:cargo-inputs
        (("rust-memchr" ,rust-memchr-2)
         ("rust-safemem" ,rust-safemem-0.3)
         ("rust-slice-deque" ,rust-slice-deque-0.2))))
--
2.34.1

[bug#57111] [PATCH 43/56] gnu: rust-buffered-reader-1: Allow build.

[Jean-Pierre De Jesus DIAZ via Guix-patches via]

* gnu/packages/crates-io.scm (rust-buffered-reader-1)[arguments]: Remove
  `#:skip-build? #t'.
---
 gnu/packages/crates-io.scm | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/gnu/packages/crates-io.scm b/gnu/packages/crates-io.scm
index 92fc3bcd62..610a7ee898 100644
--- a/gnu/packages/crates-io.scm
+++ b/gnu/packages/crates-io.scm
@@ -8408,8 +8408,7 @@ (define-public rust-buffered-reader-1
         (base32 "1jf6iqxm3yllm9h3q5f90yj8y9qzr5h0a7aiw38cgk4hagh2s8d4"))))
     (build-system cargo-build-system)
     (arguments
-     `(#:skip-build? #t
-       #:cargo-inputs
+     `(#:cargo-inputs
        (("rust-bzip2" ,rust-bzip2-0.4)
         ("rust-flate2" ,rust-flate2-1)
         ("rust-libc" ,rust-libc-0.2))))
--
2.34.1

[bug#57111] [PATCH 44/56] gnu: rust-bugreport-0.4: Allow build.

[Jean-Pierre De Jesus DIAZ via Guix-patches via]

* gnu/packages/crates-io.scm (rust-bugreport-0.4)[arguments]: Remove
  `#:skip-build? #t'.
---
 gnu/packages/crates-io.scm | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/gnu/packages/crates-io.scm b/gnu/packages/crates-io.scm
index 610a7ee898..bacbe6e4de 100644
--- a/gnu/packages/crates-io.scm
+++ b/gnu/packages/crates-io.scm
@@ -8561,8 +8561,7 @@ (define-public rust-bugreport-0.4
         (base32 "0gday6f2brqgzl12a0vf7fx1hh1mim6gdjxc6dfwk9v4i19pxsd0"))))
     (build-system cargo-build-system)
     (arguments
-     `(#:skip-build? #t
-       #:cargo-inputs
+     `(#:cargo-inputs
        (("rust-git-version" ,rust-git-version-0.3)
         ("rust-shell-escape" ,rust-shell-escape-0.1)
         ("rust-sys-info" ,rust-sys-info-0.9))))
--
2.34.1

[bug#57111] [PATCH 45/56] gnu: rust-bugreport-0.3: Allow build.

[Jean-Pierre De Jesus DIAZ via Guix-patches via]

* gnu/packages/crates-io.scm (rust-bugreport-0.3)[arguments]: Remove
  `#:skip-build? #t'.
---
 gnu/packages/crates-io.scm | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/gnu/packages/crates-io.scm b/gnu/packages/crates-io.scm
index bacbe6e4de..72a0017915 100644
--- a/gnu/packages/crates-io.scm
+++ b/gnu/packages/crates-io.scm
@@ -8586,8 +8586,7 @@ (define-public rust-bugreport-0.3
        (sha256
         (base32 "1n5f1nkqbc5yf9bckjap49pwnqnvdczm6x9y23caaghpgw0n4rqi"))))
     (arguments
-     `(#:skip-build? #t
-       #:cargo-inputs
+     `(#:cargo-inputs
        (("rust-snailquote" ,rust-snailquote-0.3)
         ("rust-sys-info" ,rust-sys-info-0.7))))))

--
2.34.1

[bug#57111] [PATCH 46/56] gnu: rust-byte-tools-0.3: Allow build.

[Jean-Pierre De Jesus DIAZ via Guix-patches via]

* gnu/packages/crates-io.scm (rust-byte-tools-0.3)[arguments]: Remove
  `#:skip-build? #t'.
---
 gnu/packages/crates-io.scm | 1 -
 1 file changed, 1 deletion(-)

diff --git a/gnu/packages/crates-io.scm b/gnu/packages/crates-io.scm
index 72a0017915..65bb97a62e 100644
--- a/gnu/packages/crates-io.scm
+++ b/gnu/packages/crates-io.scm
@@ -8735,7 +8735,6 @@ (define-public rust-byte-tools-0.3
         (base32
          "1mqi29wsm8njpl51pfwr31wmpzs5ahlcb40wsjyd92l90ixcmdg3"))))
     (build-system cargo-build-system)
-    (arguments `(#:skip-build? #t))
     (home-page "https://github.com/RustCrypto/utils")
     (synopsis "Bytes related utility functions")
     (description "Bytes related utility functions.")
--
2.34.1

[bug#57111] [PATCH 47/56] gnu: rust-bytecheck-0.5: Allow build.

[Jean-Pierre De Jesus DIAZ via Guix-patches via]

* gnu/packages/crates-io.scm (rust-bytecheck-0.5)[arguments]: Remove
  `#:skip-build? #t'.
---
 gnu/packages/crates-io.scm | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/gnu/packages/crates-io.scm b/gnu/packages/crates-io.scm
index 65bb97a62e..463595b134 100644
--- a/gnu/packages/crates-io.scm
+++ b/gnu/packages/crates-io.scm
@@ -8788,8 +8788,7 @@ (define-public rust-bytecheck-0.5
         (base32 "0q11ap6nqj0rsc8ypwjh918916zlrcrzdgqm175gnpb2yn9axyh1"))))
     (build-system cargo-build-system)
     (arguments
-     `(#:skip-build? #t
-       #:cargo-inputs
+     `(#:cargo-inputs
        (("rust-bytecheck-derive" ,rust-bytecheck-derive-0.5)
         ("rust-log" ,rust-log-0.4)
         ("rust-ptr-meta" ,rust-ptr-meta-0.1)
--
2.34.1

[bug#57111] [PATCH 48/56] gnu: rust-bytemuck-derive-1: Allow build.

[Jean-Pierre De Jesus DIAZ via Guix-patches via]

* gnu/packages/crates-io.scm (rust-bytemuck-derive-1)[arguments]: Remove
  `#:skip-build? #t'.
---
 gnu/packages/crates-io.scm | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/gnu/packages/crates-io.scm b/gnu/packages/crates-io.scm
index 463595b134..d2df1de693 100644
--- a/gnu/packages/crates-io.scm
+++ b/gnu/packages/crates-io.scm
@@ -8954,8 +8954,7 @@ (define-public rust-bytemuck-derive-1
           "1k59b6g2d87nf32qwhp73vng3al0zklxg64iiwf0pkxy74xf5ni8"))))
     (build-system cargo-build-system)
     (arguments
-     `(#:skip-build? #t
-       #:cargo-inputs
+     `(#:cargo-inputs
        (("rust-proc-macro2" ,rust-proc-macro2-1)
         ("rust-quote" ,rust-quote-1)
         ("rust-syn" ,rust-syn-1))
--
2.34.1

[bug#57111] [PATCH 49/56] gnu: rust-calloop-0.6: Allow build.

[Jean-Pierre De Jesus DIAZ via Guix-patches via]

* gnu/packages/crates-io.scm (rust-calloop-0.6)[arguments]: Remove
  `#:skip-build? #t'.
---
 gnu/packages/crates-io.scm | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/gnu/packages/crates-io.scm b/gnu/packages/crates-io.scm
index d2df1de693..a38f9c0e77 100644
--- a/gnu/packages/crates-io.scm
+++ b/gnu/packages/crates-io.scm
@@ -9475,8 +9475,7 @@ (define-public rust-calloop-0.6
         (base32 "0z3jlsv3g28097dhsmi2l8nzkd3p937jhb4pg52njhb0wxkn20qb"))))
     (build-system cargo-build-system)
     (arguments
-     `(#:skip-build? #t
-       #:cargo-inputs
+     `(#:cargo-inputs
        (("rust-log" ,rust-log-0.4)
         ("rust-nix" ,rust-nix-0.18))))))

--
2.34.1

[bug#57111] [PATCH 50/56] gnu: rust-calloop-0.4: Allow build.

[Jean-Pierre De Jesus DIAZ via Guix-patches via]

* gnu/packages/crates-io.scm (rust-calloop-0.4)[arguments]: Remove
  `#:skip-build? #t'.
---
 gnu/packages/crates-io.scm | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)

diff --git a/gnu/packages/crates-io.scm b/gnu/packages/crates-io.scm
index a38f9c0e77..6a1d01be06 100644
--- a/gnu/packages/crates-io.scm
+++ b/gnu/packages/crates-io.scm
@@ -9495,10 +9495,8 @@ (define-public rust-calloop-0.4
          "0q6ic9lr0s86886mbyn4yncg68b2sykgwjf3iygdw01swmxhk8ks"))
         (modules '((guix build utils)))
         (snippet
-         '(begin
-            (substitute* "Cargo.toml"
-              (("=1.0.0") "^1.0.0"))
-            #t))))
+         '(substitute* "Cargo.toml"
+            (("=1\\.0\\.0") "1")))))
     (arguments
      `(#:cargo-inputs
        (("rust-mio" ,rust-mio-0.6)
--
2.34.1

[bug#57111] [PATCH 51/56] gnu: rust-capnpc-0.13: Allow build.

[Jean-Pierre De Jesus DIAZ via Guix-patches via]

* gnu/packages/crates-io.scm (rust-capnpc-0.13)[arguments]: Remove
  `#:skip-build? #t'.
---
 gnu/packages/crates-io.scm | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/gnu/packages/crates-io.scm b/gnu/packages/crates-io.scm
index 6a1d01be06..87062d24fd 100644
--- a/gnu/packages/crates-io.scm
+++ b/gnu/packages/crates-io.scm
@@ -9713,8 +9713,8 @@ (define-public rust-capnpc-0.13
         (base32 "1hbm5xqpam3f0ha5ds39wjmpqpzdalpbrls9wlp7m3slh3p5r1c1"))))
     (build-system cargo-build-system)
     (arguments
-     `(#:skip-build? #t
-       #:cargo-inputs (("rust-capnp" ,rust-capnp-0.13))))
+     `(#:cargo-inputs
+       (("rust-capnp" ,rust-capnp-0.13))))
     (home-page "https://github.com/capnproto/capnproto-rust")
     (synopsis "Cap'n Proto code generation")
     (description "Cap'n Proto code generation")
--
2.34.1

[bug#57111] [PATCH 52/56] gnu: rust-cassowary-0.3: Allow build.

[Jean-Pierre De Jesus DIAZ via Guix-patches via]

* gnu/packages/crates-io.scm (rust-cassowary-0.3)[arguments]: Remove
  `#:skip-build? #t'.
---
 gnu/packages/crates-io.scm | 1 -
 1 file changed, 1 deletion(-)

diff --git a/gnu/packages/crates-io.scm b/gnu/packages/crates-io.scm
index 87062d24fd..c8af1a3b39 100644
--- a/gnu/packages/crates-io.scm
+++ b/gnu/packages/crates-io.scm
@@ -10170,7 +10170,6 @@ (define-public rust-cassowary-0.3
        (sha256
         (base32 "0lvanj0gsk6pc1chqrh4k5k0vi1rfbgzmsk46dwy3nmrqyw711nz"))))
     (build-system cargo-build-system)
-    (arguments `(#:skip-build? #t))
     (home-page "https://github.com/dylanede/cassowary-rs")
     (synopsis
      "Implementation of the Cassowary linear constraint solving algorithm")
--
2.34.1

[bug#57111] [PATCH 53/56] gnu: rust-cast-0.2: Allow build.

[Jean-Pierre De Jesus DIAZ via Guix-patches via]

* gnu/packages/crates-io.scm (rust-cast-0.2)[arguments]: Remove
  `#:skip-build? #t'.
---
 gnu/packages/crates-io.scm | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/gnu/packages/crates-io.scm b/gnu/packages/crates-io.scm
index c8af1a3b39..77fb2c0cfe 100644
--- a/gnu/packages/crates-io.scm
+++ b/gnu/packages/crates-io.scm
@@ -10221,8 +10221,7 @@ (define-public rust-cast-0.2
          "1c5z7zryj0zwnhdgs6rw5dfvnlwc1vm19jzrlgx5055alnwk952b"))))
     (build-system cargo-build-system)
     (arguments
-     `(#:skip-build? #t
-       #:cargo-inputs
+     `(#:cargo-inputs
        (("rust-rustc-version" ,rust-rustc-version-0.2))
        #:cargo-development-inputs
        (("rust-quickcheck" ,rust-quickcheck-0.9))))))
--
2.34.1

[bug#57111] [PATCH 54/56] gnu: rust-cfg-aliases-0.1: Allow build.

[Jean-Pierre De Jesus DIAZ via Guix-patches via]

* gnu/packages/crates-io.scm (rust-cfg-aliases-0.1)[arguments]: Remove
  `#:skip-build? #t'.
---
 gnu/packages/crates-io.scm | 1 -
 1 file changed, 1 deletion(-)

diff --git a/gnu/packages/crates-io.scm b/gnu/packages/crates-io.scm
index 77fb2c0cfe..fe3ed7fc1a 100644
--- a/gnu/packages/crates-io.scm
+++ b/gnu/packages/crates-io.scm
@@ -10390,7 +10390,6 @@ (define-public rust-cfg-aliases-0.1
        (sha256
         (base32 "17p821nc6jm830vzl2lmwz60g3a30hcm33nk6l257i1rjdqw85px"))))
     (build-system cargo-build-system)
-    (arguments `(#:skip-build? #t))
     (home-page "https://github.com/katharostech/cfg_aliases")
     (synopsis "Utility to help you with long winded @code{#[cfg()]} checks")
     (description
--
2.34.1

[bug#57111] [PATCH 55/56] gnu: rust-chrono-humanize-0.2: Allow build.

[Jean-Pierre De Jesus DIAZ via Guix-patches via]

* gnu/packages/crates-io.scm (rust-chrono-humanize-0.2)
  [arguments]: Remove `#:skip-build? #t'.
---
 gnu/packages/crates-io.scm | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/gnu/packages/crates-io.scm b/gnu/packages/crates-io.scm
index fe3ed7fc1a..b601ac6af1 100644
--- a/gnu/packages/crates-io.scm
+++ b/gnu/packages/crates-io.scm
@@ -10857,8 +10857,7 @@ (define-public rust-chrono-humanize-0.2
         (base32 "1jvm6fcs3zvz4kcqkp9q5hjy0i2zc17194nb63ckyn0xa0cw3p9f"))))
     (build-system cargo-build-system)
     (arguments
-     `(#:skip-build? #t
-       #:cargo-inputs
+     `(#:cargo-inputs
        (("rust-chrono" ,rust-chrono-0.4))))
     (home-page "https://gitlab.com/imp/chrono-humanize-rs")
     (synopsis "Human-friendly time expressions")
--
2.34.1

[bug#57111] [PATCH 56/56] gnu: rust-chrono-tz-0.6: Allow build.

[Jean-Pierre De Jesus DIAZ via Guix-patches via]

* gnu/packages/crates-io.scm (rust-chrono-tz-0.6)[arguments]: Remove
  `#:skip-build? #t'.
---
 gnu/packages/crates-io.scm | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/gnu/packages/crates-io.scm b/gnu/packages/crates-io.scm
index b601ac6af1..7082ee18f6 100644
--- a/gnu/packages/crates-io.scm
+++ b/gnu/packages/crates-io.scm
@@ -10879,8 +10879,7 @@ (define-public rust-chrono-tz-0.6
         (base32 "12qcpjqva4fpj5kdcksbfhsc8dkbdhyi2z56p8dwf9bxc0f1rh34"))))
     (build-system cargo-build-system)
     (arguments
-     `(#:skip-build? #t
-       #:cargo-inputs
+     `(#:cargo-inputs
        (("rust-chrono" ,rust-chrono-0.4)
         ("rust-chrono-tz-build" ,rust-chrono-tz-build-0.0.2)
         ("rust-phf" ,rust-phf-0.10)
--
2.34.1

[bug#57111] [PATCH 00/56] gnu: crates-io: Allow build of various rust packages.

[Maxime Devos]

[-- Attachment #1.1.1: Type: text/plain, Size: 2013 bytes --]


On 10-08-2022 13:48, Jean Pierre De Jesus DIAZ wrote:
> This patch series allows cargo-build-system to fully build and test
> some of these packages. These are small rust packages though.
>
> Probably were added without verifying if the crate could get built or
> not. So these patches are mostly one liners removing `#:skip-build? #t'.
> [...]
> Maxime I've CCed you as this could relate to antioxidant (as it
> requires crates to build, am I right?).

We currently skip-build? #t to reduce build time with the inefficient 
cargo-build-system. To avoid wasting energy, I recommend delaying such 
patches until we have a matching _efficient_ build system.

In antioxidant, I've noticed there are often missing dependencies 
(test-only or otherwise), I have a list '%extra-inputs' that contains 
the required information for adding them Small sample:

;; TODO: add these (upstream) or teach "guix style" to add them.
;; Keep it sorted to find things in it easily!
(define %extra-inputs
   `(("alacritty" ; forgot the reason for adding the dependency
      (("rust-structopt" ,(p rust-structopt-0.3))))
     ("castor" ;; TODO: add them in upstream Guix
      (("rust-gio" ,(@ (gnu packages crates-gtk) rust-gio-0.14))
       [...]))
    [...]))

Currently, 95% of the rust packages compile (and test successfully, 
except for tests I've manually disabled), according to the antiox jobset 
at ci.guix.gnu.org.

As such, you are kind of duplicating work already done.

If you want to help with fixing the build inputs, I recommend using the 
information (currently 1498 lines) I've already gathered in 
antioxidant-packages.scm (%extra-inputs), by teaching "guix style" to 
automatically add dependencies listed in %extra-inputs. Also keep 
%removed-dependencies and %disable-tests in mind, sometimes crates must 
_not_ be added, to avoid cycles (those cycles are resolved in 
cargo-build-system, but cannot be in antioxidant).

Greetings,
Maxime.



[-- Attachment #1.1.2: OpenPGP public key --]
[-- Type: application/pgp-keys, Size: 929 bytes --]

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 236 bytes --]

[bug#57111] [PATCH 00/56] gnu: crates-io: Allow build of various rust packages.

[Jean Pierre De Jesus DIAZ via Guix-patches via]

>We currently skip-build? #t to reduce build time with the inefficient 
>cargo-build-system. To avoid wasting energy, I recommend delaying such 
>patches until we have a matching _efficient_ build system.

This should be written somewhere IMHO if not done already, thought
of removing the `#:skip-build?` for the crates I could find to
solve build and dependency issues where possible as that's
the intention of the (guix)Rust Crates section of the manual:

https://guix.gnu.org/manual/en/html_node/Rust-Crates.html


—
Jean-Pierre De Jesus DIAZ
Senior Software Engineer


------- Original Message -------
On Wednesday, August 10th, 2022 at 8:32 PM, Maxime Devos <maximedevos@telenet.be> wrote:


> 
> On 10-08-2022 13:48, Jean Pierre De Jesus DIAZ wrote:
> 
> > This patch series allows cargo-build-system to fully build and test
> > some of these packages. These are small rust packages though.
> > 
> > Probably were added without verifying if the crate could get built or
> > not. So these patches are mostly one liners removing `#:skip-build? #t'.
> > [...]
> > Maxime I've CCed you as this could relate to antioxidant (as it
> > requires crates to build, am I right?).
> 
> 
> We currently skip-build? #t to reduce build time with the inefficient
> cargo-build-system. To avoid wasting energy, I recommend delaying such
> patches until we have a matching efficient build system.
> 
> In antioxidant, I've noticed there are often missing dependencies
> (test-only or otherwise), I have a list '%extra-inputs' that contains
> the required information for adding them Small sample:
> 
> ;; TODO: add these (upstream) or teach "guix style" to add them.
> ;; Keep it sorted to find things in it easily!
> (define %extra-inputs
>   `(("alacritty" ; forgot the reason for adding the dependency
>      (("rust-structopt" ,(p rust-structopt-0.3))))
>     ("castor" ;; TODO: add them in upstream Guix
>      (("rust-gio" ,(@ (gnu packages crates-gtk) rust-gio-0.14))
>       [...]))
>    [...]))
> 
> Currently, 95% of the rust packages compile (and test successfully,
> except for tests I've manually disabled), according to the antiox jobset
> at ci.guix.gnu.org.
> 
> As such, you are kind of duplicating work already done.
> 
> If you want to help with fixing the build inputs, I recommend using the
> information (currently 1498 lines) I've already gathered in
> antioxidant-packages.scm (%extra-inputs), by teaching "guix style" to
> automatically add dependencies listed in %extra-inputs. Also keep
> %removed-dependencies and %disable-tests in mind, sometimes crates must
> not be added, to avoid cycles (those cycles are resolved in
> cargo-build-system, but cannot be in antioxidant).
> 
> Greetings,
> Maxime.

bug#57111: [PATCH 00/56] gnu: crates-io: Allow build of various rust packages.

[Efraim Flashner]

[-- Attachment #1: Type: text/plain, Size: 1307 bytes --]

On Wed, Aug 10, 2022 at 11:48:16AM +0000, Jean Pierre De Jesus DIAZ via Guix-patches via wrote:
> This patch series allows cargo-build-system to fully build and test
> some of these packages. These are small rust packages though.
> 
> Probably were added without verifying if the crate could get built or
> not. So these patches are mostly one liners removing `#:skip-build? #t'.
> 
> I did a quick pass over the crates to find the simpler ones, there are
> more for sure but don't want to send hundreds of patches. I'll tackle
> these easy ones first and then I'll proceed with most complex ones
> on further patches that require adding new packages and modifying
> existing ones.
> 
> I've tested all of these crates on x86_64 and they build without
> problems.
> 
> Maxime I've CCed you as this could relate to antioxidant (as it
> requires crates to build, am I right?).
> 
> —
> Jean-Pierre De Jesus DIAZ

Better late than never, 23 of the patches applied cleanly, the rest
either were changed to build or were removed.  Patches applied to the
rust-team branch.

-- 
Efraim Flashner   <efraim@flashner.co.il>   רנשלפ םירפא
GPG key = A28B F40C 3E55 1372 662D  14F7 41AA E7DC CA3D 8351
Confidentiality cannot be guaranteed on emails sent or received unencrypted

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]