From: Tomas Volf <~@wolfsden.cz>
To: "Ludovic Courtès" <ludo@gnu.org>
Cc: 69380@debbugs.gnu.org
Subject: [bug#69380] [PATCH] gnu: guile-irregex: Update to 0.9.11.
Date: Sun, 3 Mar 2024 17:57:27 +0100 [thread overview]
Message-ID: <ZeSr9wdkSyTA7suE@ws> (raw)
In-Reply-To: <87o7bwd33a.fsf@gnu.org>
[-- Attachment #1: Type: text/plain, Size: 776 bytes --]
On 2024-03-02 17:13:13 +0100, Ludovic Courtès wrote:
> > + (for-each
> > + (lambda (f)
> > + (symlink (regexp-substitute #f (string-match "/([^/]+)$" f)
> > + 1 ".scm")
> > + f))
>
> I would avoid using regexps for such things: it’s heavyweight, hard to
> read, and error-prone. Looks like you could do away with just
> ‘basename’ and the likes, no?
Yes, I think this could have been just (string-append (basename f) ".scm"). I
forgot there is such function, thanks for pointing it out.
Have a nice day,
Tomas
--
There are only two hard things in Computer Science:
cache invalidation, naming things and off-by-one errors.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
prev parent reply other threads:[~2024-03-03 16:57 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-25 13:26 [bug#69380] [PATCH] gnu: guile-irregex: Update to 0.9.11 Tomas Volf
2024-03-02 16:13 ` bug#69380: " Ludovic Courtès
2024-03-03 16:57 ` Tomas Volf [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZeSr9wdkSyTA7suE@ws \
--to=~@wolfsden.cz \
--cc=69380@debbugs.gnu.org \
--cc=ludo@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).