From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0.migadu.com ([2001:41d0:303:e16b::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms8.migadu.com with LMTPS id IHC3JkAw3mUnJwEAqHPOHw:P1 (envelope-from ) for ; Tue, 27 Feb 2024 19:56:00 +0100 Received: from aspmx1.migadu.com ([2001:41d0:303:e16b::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0.migadu.com with LMTPS id IHC3JkAw3mUnJwEAqHPOHw (envelope-from ) for ; Tue, 27 Feb 2024 19:56:00 +0100 X-Envelope-To: larch@yhetil.org Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=twistfold.it header.s=a1 header.b=EXfQ9m3v; dmarc=fail reason="SPF not aligned (relaxed)" header.from=twistfold.it (policy=none); spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1709060160; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post: dkim-signature; bh=bqLHv01hFub5Gkh+BmwatUXC39pM4ePhwspwRhjE2Sc=; b=DmG5K9p8QYjZ7sFv4er6nJLjB1dS2xN822pMqKj+jpqqoMydn6ZnLpoX9nPmO7B0yOTPuQ kPX/Ey20Pp92BmgSRfFrTijTOcGzQittoIURzmkiBwIJ5qWrvkK5Yha1wXsdZGyoH2E3Qk pH9stAafEvtgAqOGqIR1zwdjauoCPWIemHimtVQS3WCKUDFlU8QORZmA5ShrU/dTwXV/Ch HyE5PEyW11wboztMY9Aks40cNuWP13ibkJ16tgKe4Y9t5yAH3NZkfXa01o5+ViNMY8X8BC 6khkO8rR94GVYA7Ky06IeZ6iuz1tKZ1zuPOLN3ejiahh3f7Ey0VMSkv67lei2Q== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=twistfold.it header.s=a1 header.b=EXfQ9m3v; dmarc=fail reason="SPF not aligned (relaxed)" header.from=twistfold.it (policy=none); spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" ARC-Seal: i=1; s=key1; d=yhetil.org; t=1709060160; a=rsa-sha256; cv=none; b=OXWFxQFMzIlxbAxHYNyzqeg7TTnlFDuOgwxVGGB7HI9GXnxm2+7RRAJ1CiqzCkdWm+EeBR 18pd4Wxw8lkaC2frQ2mUtyWCLIPKsjCSCcUGu/t4x7wB6Uk7OuxsiRh5RyDtyRJlyxqqGz UxD1QOoK//2S3MWJjQcmTLOV9qT0jl8V78/hpp390AnP7MQLcdxIU4W/tire1wnvbO6Ap0 xr9N4khs5gnu5bYnP6B+DrfLa8xu8HeXynUvdrDih6nD1Vq4WTVQqXUQ83qBG3NJTDtD13 LQQpqvazzD9lkl27k1EI4tANEOEvaxIeE7F4XyEsUj7J2RwqdJgRDi7SqDxIjA== Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 5DA9050285 for ; Tue, 27 Feb 2024 19:56:00 +0100 (CET) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rf2c7-0008AV-B1; Tue, 27 Feb 2024 13:55:39 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rf2c4-00089j-FG for guix-patches@gnu.org; Tue, 27 Feb 2024 13:55:37 -0500 Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rf2c4-0002hT-6s for guix-patches@gnu.org; Tue, 27 Feb 2024 13:55:36 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1rf2cU-0005cY-7W for guix-patches@gnu.org; Tue, 27 Feb 2024 13:56:02 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#69355] [PATCH] gnu: Add libgrapheme. Resent-From: cage Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Tue, 27 Feb 2024 18:56:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 69355 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Maxim Cournoyer Cc: 69355@debbugs.gnu.org Received: via spool by 69355-submit@debbugs.gnu.org id=B69355.170906012221504 (code B ref 69355); Tue, 27 Feb 2024 18:56:02 +0000 Received: (at 69355) by debbugs.gnu.org; 27 Feb 2024 18:55:22 +0000 Received: from localhost ([127.0.0.1]:45848 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rf2bp-0005ag-PI for submit@debbugs.gnu.org; Tue, 27 Feb 2024 13:55:22 -0500 Received: from smtpcmd11116.aruba.it ([62.149.156.116]:44424) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rf2ZZ-0005Ty-7i for 69355@debbugs.gnu.org; Tue, 27 Feb 2024 13:53:03 -0500 Received: from obayashi ([84.220.250.74]) by Aruba Outgoing Smtp with ESMTPSA id f2Y2roui4Zt1Af2Y3r29wC; Tue, 27 Feb 2024 19:51:28 +0100 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=twistfold.it; s=a1; t=1709059888; bh=EGi+qMwddmlaGzN6Jb7U4fYdVWi+VkhNGViw+MxRa2I=; h=Date:From:To:Subject:MIME-Version:Content-Type; b=EXfQ9m3vMg++n+OpREaIggoAap5gR5VN6W5sGSRmqwdibhl3HZQY6VE4nmw8lHQ/8 MOHC1RqkHGw/UcMHnkR2xpAlrT6jxmcYNxshtU3bKuMbOXice6S5x/rFuKxUvkcECu bF/fk5bQVAa9334LN+FcDt3LRA61016t8wbI2ZAV2zKaV2K0bfXoyAyInubqwWSY8D OWqYP1qiH0GIgDKgzNbyteIKmW22JRHCm7nu5HZIiyynVVsQNHOEg2cGVIAEw0yMxv Ke9dcrsk40J02GlBU/8q4mVWE83sesObIdmyVKpuJGdlEOegDJbE7IiHGndItFsmqR n5MsBd+X/SjxQ== Date: Tue, 27 Feb 2024 19:51:26 +0100 From: cage Message-ID: References: <505f3bdf672b32d2d9413ed2e4d83a769518d9ea.1708780937.git.cage-dev@twistfold.it> <87msrnjir9.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <87msrnjir9.fsf@gmail.com> X-CMAE-Envelope: MS4xfGiSqN/3j7zr5rZwYUfmKIyzE/A2Pku4SEGD1b12hjVsvvKtpNqbI4puONuL/RuQVp14+MoItzReDVqnDeRssRXRC2FcuS7ZznnT/s6QDv87soyw95LX O9qPUMc6sG9IoTsYnzRJOsgxOcGH+DZGgZRHhW0562z/1H0lAePjKca7OV4v5D2Xw+rq+fZLkAiWNETzRm6wdaHYjVa9jzLJ3g1OHN4hXBQBtzoOIjLwSwsX X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US X-Migadu-Spam-Score: 5.23 X-Spam-Score: 5.23 X-Migadu-Queue-Id: 5DA9050285 X-Migadu-Scanner: mx13.migadu.com X-TUID: nIev4MwTR2/Y On Mon, Feb 26, 2024 at 11:24:42AM -0500, Maxim Cournoyer wrote: > Hi, Hi! [...] > We strive to enable test suites of packages in Guix, as this gives us a > chance to detect breakage across updates. Its page mentions a 'test' > target to run the conformance and unit tests of libgrapheme. Did you > try it, via #:test-target "test" ? (the default is "check", which is > most common). I did not payed the right attention while reading the README file of the package and I missed the mentions of the tests target in the makefile. ^^; > > > + #:phases #~(modify-phases %standard-phases > > + (add-after 'configure 'post-configure > > + (lambda _ > > + (substitute* "config.mk" > > Please leave an explanatory comment mentioning that running ldconfig is > not needed on Guix. sure! > > > + (("ldconfig") ""))))) > > + #:make-flags > > + #~(list (string-append "CC=" #$(cc-for-target)) > > + (string-append "PREFIX=" #$output)))) > > + (home-page "https://libs.suckless.org/libgrapheme/") > > + (synopsis "Library to handle string according to Unicode standard") > > + (description "Libgrapheme is an extremely simple freestanding C99 library > > +providing utilities for properly handling strings > > +according to the latest Unicode standard 15.0.0.") > > nitpick: The paragraph flow seems broken after 'handling strings' -- > "M-;" in Emacs would help. For some reasons this command does not work for me, i used to use M-q, i hope the results is acceptable. ^^; > I'd also drop the exact Unicode standard currently targeted, as this > would probably become outdated information soon. Good idea! > Could you send a v2 with the above changes? Sure! The new patch is attached below. Thanks for your comments, let me know if I have addressed, or not, all the issues. Bye! C. --- gnu/packages/suckless.scm | 33 +++++++++++++++++++++++++++++++++ 1 file changed, 33 insertions(+) diff --git a/gnu/packages/suckless.scm b/gnu/packages/suckless.scm index 81e2151854..b89b3be961 100644 --- a/gnu/packages/suckless.scm +++ b/gnu/packages/suckless.scm @@ -1393,3 +1393,36 @@ (define-public 9base (description "This package provides ported versions of various Plan 9 userland tools for Unix."))) + +(define-public libgrapheme + (package + (name "libgrapheme") + (version "2.0.2") + (source + (origin + (method url-fetch) + (uri (string-append "https://dl.suckless.org/libgrapheme/libgrapheme-" + version + ".tar.gz")) + (sha256 + (base32 "099i2jm9c25nkbg5420wr12z0gd189gcw5j1ssjmpmbbwzfvv2x6")))) + (build-system gnu-build-system) + (arguments + (list #:tests? #true + #:test-target "test" + #:phases #~(modify-phases %standard-phases + (add-after 'configure 'post-configure + (lambda _ + ;; removing call of ldconfing in makefile as it is + ;; not actually needed in guix + (substitute* "config.mk" + (("ldconfig") ""))))) + #:make-flags + #~(list (string-append "CC=" #$(cc-for-target)) + (string-append "PREFIX=" #$output)))) + (home-page "https://libs.suckless.org/libgrapheme/") + (synopsis "Library to handle string according to Unicode standard.") + (description "Libgrapheme is an extremely simple freestanding C99 library +providing utilities for properly handling strings according to the latest +Unicode standard.") + (license license:isc))) base-commit: de24aaf13b17d6c019f3f240fd0eb0e1b8654970 prerequisite-patch-id: aa0b913d42bee51002e7243019d5529984321e91 -- 2.41.0