From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1.migadu.com ([2001:41d0:403:4876::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms8.migadu.com with LMTPS id eI8EIbctvGUEGgAA62LTzQ:P1 (envelope-from ) for ; Fri, 02 Feb 2024 00:48:07 +0100 Received: from aspmx1.migadu.com ([2001:41d0:403:4876::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1.migadu.com with LMTPS id eI8EIbctvGUEGgAA62LTzQ (envelope-from ) for ; Fri, 02 Feb 2024 00:48:07 +0100 X-Envelope-To: larch@yhetil.org Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=riseup.net header.s=squak header.b=UKJHVZeL; dmarc=fail reason="SPF not aligned (relaxed)" header.from=riseup.net (policy=none); spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" ARC-Seal: i=1; s=key1; d=yhetil.org; t=1706831287; a=rsa-sha256; cv=none; b=liNZHhLTnxyDJTGpEDXfJdJAa7N0G3DnDPkMv3QsVRShFhwpJyzshTba1Z8m9VZHd3sunZ xAu3FkUpJ5lQyy5xNpv/EU5vF2FhIqLqNJeHIUbYyrnjXq9UOTt3Q70uTuACXZGtajSKoB Af8LBpJbYowG+6kNsl81g7Jy5/FLtfHmC4jhDtatL717wXTlpFRpL2JkWVtXgSZ0L0Q2Kb k9L037PyiUQrjzrbKjszzAlfZC49/a97Xnzha8ugTrr6JuYTVFoqFauwBZ3DLjnZ+5qxO3 bFAdT7WRI7+Hjtwu8wUJLKsHCNtdPh+lPxBRloX/LHhEV0xIo6cxBtYi7roZ3g== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=riseup.net header.s=squak header.b=UKJHVZeL; dmarc=fail reason="SPF not aligned (relaxed)" header.from=riseup.net (policy=none); spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1706831287; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=BaIENqvlfxs6Qkpi5Pj3CA+Vt3PoIGB4ffpVd3MFusg=; b=fnwemRMTC0W/hTdkGWbdvA16hlj7ZPy+5aqOJGgSiT60RkRNvgbXPeCobJaaAGF/ojB8Hl JgeYW5zo+N5yNaRMtCMPugeRMryiufUFMLJfSfL2g8gfQElE8MSv28UbRrQS2E0KXCC16t kTb284khdDwpyPRC4mebYaFnRiU3JO6703mYljKNg0PHeQCWeimylLCBl7CdnKaHl19Kpx Q0423curwzELGgJ3ZhLm+ymlXmgL7+jt21jYYvjCRfiyei5K1aLveXKUyWTlhevXFOylz7 exSEaVCMHIrEdT9vrdHIgs0CKX7mxtRIEGyjJVcIRbEVgyY3hjS0rpaKOy5tfA== Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 61B372378E for ; Fri, 2 Feb 2024 00:48:06 +0100 (CET) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rVgmf-0005LL-UL; Thu, 01 Feb 2024 18:47:53 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rVgme-0005Kw-6u for guix-patches@gnu.org; Thu, 01 Feb 2024 18:47:52 -0500 Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rVgmd-0003wB-SL for guix-patches@gnu.org; Thu, 01 Feb 2024 18:47:51 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1rVgmo-0002NW-5m for guix-patches@gnu.org; Thu, 01 Feb 2024 18:48:02 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#68577] [PATCH v2 1/2] gnu: torbrowser: Stop inheriting Icecat. Resent-From: =?UTF-8?Q?Andr=C3=A9?= Batista Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Thu, 01 Feb 2024 23:48:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 68577 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: =?UTF-8?Q?Cl=C3=A9ment?= Lassieur Cc: Mark H Weaver , 68577@debbugs.gnu.org, Jonathan Brielmaier , Ian Eure Received: via spool by 68577-submit@debbugs.gnu.org id=B68577.17068312599080 (code B ref 68577); Thu, 01 Feb 2024 23:48:02 +0000 Received: (at 68577) by debbugs.gnu.org; 1 Feb 2024 23:47:39 +0000 Received: from localhost ([127.0.0.1]:43337 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rVgmR-0002MO-8U for submit@debbugs.gnu.org; Thu, 01 Feb 2024 18:47:39 -0500 Received: from mx1.riseup.net ([198.252.153.129]:57420) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rVgmL-0002Lz-Mo for 68577@debbugs.gnu.org; Thu, 01 Feb 2024 18:47:37 -0500 Received: from fews02-sea.riseup.net (fews02-sea-pn.riseup.net [10.0.1.112]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx1.riseup.net (Postfix) with ESMTPS id 4TQwYd4P30zDqP4; Thu, 1 Feb 2024 23:47:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=riseup.net; s=squak; t=1706831237; bh=TVupD6egeuR7UrymrMYfhRo9E5WdHnjD7tXHmyWcP3o=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=UKJHVZeLoqyEqyAZW1y2PsQmqMGL092F4uUwwLvAVs7rOZa4LcHxwns6+9RD1hs5F PhXIprA2e5AFZ6hghupdd5iulqDlL1OfnnUvAexiIOoXdQoNkI3pWR+0BCfGANkTMm LzhDTLXGOc3twb4vrZP47rZmWDz68SbmIZaWrGd0= X-Riseup-User-ID: 84B2EE97E2E29BF1315031E9571006170881A8539A729065D9D3638F153A2475 Received: from [127.0.0.1] (localhost [127.0.0.1]) by fews02-sea.riseup.net (Postfix) with ESMTPSA id 4TQwYb6smpzFsjW; Thu, 1 Feb 2024 23:47:15 +0000 (UTC) Date: Thu, 1 Feb 2024 20:46:58 -0300 From: =?UTF-8?Q?Andr=C3=A9?= Batista Message-ID: References: <7044a87b07b302fb861f9853725ec0ca0abb8354.1706222112.git.clement@lassieur.org> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <7044a87b07b302fb861f9853725ec0ca0abb8354.1706222112.git.clement@lassieur.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US X-Migadu-Scanner: mx10.migadu.com X-Spam-Score: -3.67 X-Migadu-Queue-Id: 61B372378E X-Migadu-Spam-Score: -3.67 X-TUID: NW//y/rMwu75 Hi Clément, I did not yet review the mullvad patch which follows this one, but regarding this, I have only a few comments to make: qui 25 jan 2024 às 23:54:36 (1706237676), clement@lassieur.org enviou: > + > +;; Must be of the form YYYYMMDDhhmmss as in `date +%Y%m%d%H%M%S`. > +(define %moz-build-date "20240123154553") First just a heads up so that you do not forget to update the build-date. And also on tor.scm: > diff --git a/gnu/packages/tor.scm b/gnu/packages/tor.scm > index 6ded83b83fee..2e2a19ae3e41 100644 > --- a/gnu/packages/tor.scm > +++ b/gnu/packages/tor.scm > ... > > @@ -37,16 +36,10 @@ (define-module (gnu packages tor) > #:use-module (guix utils) > #:use-module (guix download) > #:use-module (guix git-download) > - #:use-module (guix hg-download) > - #:use-module (guix build-system copy) > #:use-module (guix build-system gnu) > - #:use-module (guix build-system mozilla) > #:use-module (guix build-system python) > #:use-module (guix build-system pyproject) > #:use-module (gnu packages) > - #:use-module (gnu packages base) I think you've mistankenly removed base and also > - #:use-module (gnu packages bash) > - #:use-module (gnu packages browser-extensions) > #:use-module (gnu packages libevent) > #:use-module (gnu packages linux) > #:use-module (gnu packages check) > @@ -54,11 +47,8 @@ (define-module (gnu packages tor) > #:use-module (gnu packages pcre) > #:use-module (gnu packages freedesktop) > #:use-module (gnu packages glib) > - #:use-module (gnu packages golang) > - #:use-module (gnu packages gnuzilla) > #:use-module (gnu packages pkg-config) > #:use-module (gnu packages python) > - #:use-module (gnu packages python-check) python-check here. They were there before the commit which has added torbrowser. On git logs, it seems 'base' is needed for the 'which' input to torsocks, as per f3cf25c3c2aef91a47b790fe69b5008cdb6a6316. 'python-check' OTOH is needed for the 'python-colorama' input to onionshare, as per 55db762b31531609f43b32680298762487702280. I have not yet tried to rebuild them without those inputs to see if they are actually still needed though. In case they are not, for clarity, I think it would be better to remove them on a separate patch anyway. Finally, I've noticed that we are still using 'ffmpeg-5' as an input to both icecat and torbrowser. However, as we are now based on firefox version 115, ffmpeg is compatible. I've built it to check and it appears to be working fine (though I've only watched one single video to test it and only on torbrowser). IMO, this should be also a separate patch. Other than that, all looks good to me, even if it gives me a headache. :D Cheers, André