unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: Andreas Enge <andreas@enge.fr>
To: Romain Garbage <romain.garbage@inria.fr>
Cc: Ludovic Courtes <ludovic.courtes@inria.fr>,
	Sharlatan Hellseher <sharlatanus@gmail.com>,
	68682@debbugs.gnu.org, Efraim Flashner <efraim@flashner.co.il>,
	Eric Bavier <bavier@posteo.net>
Subject: [bug#68682] [PATCH] gnu: maths: arpack-ng: Modify build settings.
Date: Wed, 24 Jan 2024 17:21:49 +0100	[thread overview]
Message-ID: <ZbE5Hd-z3uVmuube@jurong> (raw)
In-Reply-To: <971019240.17863501.1706112290823.JavaMail.zimbra@inria.fr>

Am Wed, Jan 24, 2024 at 05:04:50PM +0100 schrieb Romain Garbage:
> To me, it doesn't seem that the '-DBUILD_SHARED_LIBS=ON' option is necessary, but I might miss something.
> What do you think?

I agree it is not necessary; in Changes concerning arpack-ng 3.8.0:
 * Only build shared libraries by default.  To build static libraries, use
   --enable-static (autotools) or -DBUILD_SHARED_LIBS=OFF (cmake).

I will send a modified patch to this bug, and although I think this change
is completely harmless, I would suggest to let QA build the dependent
packages before applying it.

Andreas





  reply	other threads:[~2024-01-24 16:23 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-01-24  8:46 [bug#68682] [PATCH] gnu: maths: arpack-ng: Modify build settings Romain GARBAGE
2024-01-24 14:04 ` Andreas Enge
2024-01-24 14:07   ` Andreas Enge
2024-01-24 14:51   ` Ludovic Courtès
2024-01-24 16:04     ` Romain Garbage
2024-01-24 16:21       ` Andreas Enge [this message]
2024-01-24 16:28 ` [bug#68682] [PATCH v2 1/2] gnu: arpack-ng: Add preprocessor flag Andreas Enge
2024-01-24 16:28   ` [bug#68682] [PATCH v2 2/2] gnu: arpack-ng: Update to 3.9.1 Andreas Enge
2024-02-10 21:58   ` [bug#68682] [PATCH v2 1/2] gnu: arpack-ng: Add preprocessor flag Ludovic Courtès
2024-02-11  7:55     ` Andreas Enge
2024-02-14 13:54 ` bug#68682: Close Andreas Enge

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZbE5Hd-z3uVmuube@jurong \
    --to=andreas@enge.fr \
    --cc=68682@debbugs.gnu.org \
    --cc=bavier@posteo.net \
    --cc=efraim@flashner.co.il \
    --cc=ludovic.courtes@inria.fr \
    --cc=romain.garbage@inria.fr \
    --cc=sharlatanus@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).