From: Efraim Flashner <efraim@flashner.co.il>
To: Lars Bilke <lars.bilke@ufz.de>
Cc: 67822@debbugs.gnu.org, "Ludovic Courtès" <ludo@gnu.org>,
"Andreas Enge" <andreas@enge.fr>,
"Eric Bavier" <bavier@posteo.net>
Subject: [bug#67822] [PATCH v3] gnu: maths: petsc: Reduce closure size.
Date: Sun, 7 Jan 2024 11:09:51 +0200 [thread overview]
Message-ID: <ZZpqX6OYjXu-lfB9@3900XT> (raw)
In-Reply-To: <68C18595-278B-4AB1-9260-B154E7BC8E60@ufz.de>
[-- Attachment #1: Type: text/plain, Size: 1165 bytes --]
On Fri, Jan 05, 2024 at 12:52:02PM +0100, Lars Bilke wrote:
> Hi Ludo,
>
> On 5 Jan 2024, at 12:08, Ludovic Courtès wrote:
>
> > Can we instead patch the thing that creates ‘petscvariables’ in the
> > first place?
> >
> > The reason I’m suggesting it is because in general we avoid hardcoding
> > /gnu/store in substitution patterns because it’s possible to configure
> > Guix with a different store directory.
>
> Thanks for your feedback!
>
> In v1 of this patch I removed the 'petscvariables'-file completely but this broke dependent packages as well as not-yet packaged projects which use the file for finding the PETSc library and configuriung their build system.
>
> Is there a possibility to replace the hard-coded /gnu/store with a variable which evaluates to the current store directory?
There's %store-directory in (guix build utils). In fact, it looks like
git might have some code that you can borrow.
--
Efraim Flashner <efraim@flashner.co.il> רנשלפ םירפא
GPG key = A28B F40C 3E55 1372 662D 14F7 41AA E7DC CA3D 8351
Confidentiality cannot be guaranteed on emails sent or received unencrypted
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2024-01-07 9:11 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-14 12:56 [bug#67822] [PATCH] gnu: maths: petsc: Reduce closure size Lars Bilke
2023-12-14 14:53 ` [bug#67822] [PATCH v2] " Lars Bilke
2023-12-15 8:55 ` [bug#67822] [PATCH v3] " Lars Bilke
2024-01-05 11:08 ` Ludovic Courtès
2024-01-05 11:52 ` Lars Bilke
2024-01-07 9:09 ` Efraim Flashner [this message]
2024-01-08 17:20 ` Ludovic Courtès
2024-01-09 18:15 ` [bug#67822] [PATCH v4] " Lars Bilke
2024-02-27 7:49 ` Lars Bilke
2024-02-27 9:50 ` bug#67822: " Ludovic Courtès
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZZpqX6OYjXu-lfB9@3900XT \
--to=efraim@flashner.co.il \
--cc=67822@debbugs.gnu.org \
--cc=andreas@enge.fr \
--cc=bavier@posteo.net \
--cc=lars.bilke@ufz.de \
--cc=ludo@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).