From: Efraim Flashner <efraim@flashner.co.il>
To: "Ludovic Courtès" <ludo@gnu.org>
Cc: 67505-done@debbugs.gnu.org,
Katherine Cox-Buday <cox.katherine.e+guix@gmail.com>
Subject: bug#67505: [PATCH] build/go: Don't use set!
Date: Mon, 4 Dec 2023 11:53:58 +0200 [thread overview]
Message-ID: <ZW2htr6wC4MVr21Q@3900XT> (raw)
In-Reply-To: <87jzpuewbk.fsf@gnu.org>
[-- Attachment #1: Type: text/plain, Size: 1110 bytes --]
On Sun, Dec 03, 2023 at 11:49:03PM +0100, Ludovic Courtès wrote:
> Efraim Flashner <efraim@flashner.co.il> skribis:
>
> > This causes build failures on powerpc-linux.
> >
> > * guix/build/go-build-system.scm (unpack): When the unpack-path is unset
> > use the import-path but don't redefine the unpack-path.
> >
> > Change-Id: I2b5a36eb738abb14307941d388038139dbaf2bdf
>
> [...]
>
> > - (when (string-null? unpack-path)
> > - (set! unpack-path import-path))
> > - (let ((dest (string-append (getenv "GOPATH") "/src/" unpack-path)))
> > + (let ((dest (string-append (getenv "GOPATH") "/src/"
> > + (if (string-null? unpack-path)
> > + import-path
> > + unpack-path))))
>
> Could you adjust indentation of the ‘if’ arms?
>
> Otherwise LGTM, thanks!
Done. Patch pushed!
--
Efraim Flashner <efraim@flashner.co.il> רנשלפ םירפא
GPG key = A28B F40C 3E55 1372 662D 14F7 41AA E7DC CA3D 8351
Confidentiality cannot be guaranteed on emails sent or received unencrypted
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2023-12-04 9:55 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-28 10:24 [bug#67505] [PATCH] build/go: Don't use set! Efraim Flashner
2023-12-03 22:49 ` Ludovic Courtès
2023-12-04 9:53 ` Efraim Flashner [this message]
2023-12-06 12:27 ` Efraim Flashner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZW2htr6wC4MVr21Q@3900XT \
--to=efraim@flashner.co.il \
--cc=67505-done@debbugs.gnu.org \
--cc=cox.katherine.e+guix@gmail.com \
--cc=ludo@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).