unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: Efraim Flashner <efraim@flashner.co.il>
To: Andrew Jose <arnav.jose@gmail.com>
Cc: 66134-done@debbugs.gnu.org
Subject: bug#66134: [PATCH 00/12] Add just
Date: Thu, 28 Sep 2023 21:18:26 +0300	[thread overview]
Message-ID: <ZRXDchlD5tg7mpBV@3900XT> (raw)
In-Reply-To: <20230921124125.580334-1-arnav.jose@gmail.com>

[-- Attachment #1: Type: text/plain, Size: 2011 bytes --]

Thanks for the patches! I applied them, with a few minor changes.

On Thu, Sep 21, 2023 at 06:11:25PM +0530, Andrew Jose wrote:
> The following patches add the crates required
> for just (https://github.com/casey/just) in
> dependency order, a patch to make the tests pass,
> and finally, just in rust-apps.scm
> 
> Andrew Jose (12):
>   gnu: add rust-executable-path-1
>   gnu: add rust-snafu-derive-0.7
>   gnu: add rust-snafu-0.7
>   gnu: add rust-lexiclean-0.0.1
>   gnu: add rust-strum-macros-0.24
>   gnu: add rust-strum-0.24

I combined these two so we could build and run the tests on them both,
since they depended on each other.

>   gnu: add rust-dotenvy-0.15
>   gnu: add rust-cradle-0.2
>   gnu: add rust-target-2
>   gnu: add rust-temptree-0.2
>   gnu: add patch for just
>   gnu: add just

I started by combining these two, but then I removed the one adding a
patch and added cargo-test-flags to skip those two tests. I also made
some minor adjustments to the substitutions to try and more closely
match the exectuables.

I followed up with 2 more patches, one to install the manpage, another
to install the shell completions.

I saw that there were more shebangs in src/shebangs.rs and src/parser.sh
but I didn't adjust those. I wasn't sure if they were supposed to remain
as-is or be patched to refer to paths in the store.

>  gnu/packages/crates-io.scm                  | 224 +++++++++++++++++++-
>  gnu/packages/patches/just-remove-test.patch |  61 ++++++
>  gnu/packages/rust-apps.scm                  |  71 +++++++
>  3 files changed, 348 insertions(+), 8 deletions(-)
>  create mode 100644 gnu/packages/patches/just-remove-test.patch
> 
> 
> base-commit: 15c5f1a2c20b21de0f19f42db1ccab4c42117ebb
> -- 
> 2.34.1
> 
> 
> 
> 

-- 
Efraim Flashner   <efraim@flashner.co.il>   רנשלפ םירפא
GPG key = A28B F40C 3E55 1372 662D  14F7 41AA E7DC CA3D 8351
Confidentiality cannot be guaranteed on emails sent or received unencrypted

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

      parent reply	other threads:[~2023-09-28 18:19 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-09-21 12:41 [bug#66134] [PATCH 00/12] Add just Andrew Jose
2023-09-21 12:44 ` [bug#66134] [PATCH 01/12] gnu: add rust-executable-path-1 Andrew Jose
2023-09-21 12:44   ` [bug#66134] [PATCH 02/12] gnu: add rust-snafu-derive-0.7 Andrew Jose
2023-09-21 12:44   ` [bug#66134] [PATCH 03/12] gnu: add rust-snafu-0.7 Andrew Jose
2023-09-21 12:44   ` [bug#66134] [PATCH 04/12] gnu: add rust-lexiclean-0.0.1 Andrew Jose
2023-09-21 12:44   ` [bug#66134] [PATCH 05/12] gnu: add rust-strum-macros-0.24 Andrew Jose
2023-09-21 12:44   ` [bug#66134] [PATCH 06/12] gnu: add rust-strum-0.24 Andrew Jose
2023-09-21 12:44   ` [bug#66134] [PATCH 07/12] gnu: add rust-dotenvy-0.15 Andrew Jose
2023-09-21 12:44   ` [bug#66134] [PATCH 08/12] gnu: add rust-cradle-0.2 Andrew Jose
2023-09-21 12:44   ` [bug#66134] [PATCH 09/12] gnu: add rust-target-2 Andrew Jose
2023-09-21 12:44   ` [bug#66134] [PATCH 10/12] gnu: add rust-temptree-0.2 Andrew Jose
2023-09-21 12:44   ` [bug#66134] [PATCH 11/12] gnu: add patch for just Andrew Jose
2023-09-21 12:44   ` [bug#66134] [PATCH 12/12] gnu: add just Andrew Jose
2023-09-28 18:18 ` Efraim Flashner [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZRXDchlD5tg7mpBV@3900XT \
    --to=efraim@flashner.co.il \
    --cc=66134-done@debbugs.gnu.org \
    --cc=arnav.jose@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).