From: "Wicki Gabriel (wicg)" <wicg@zhaw.ch>
To: "60732@debbugs.gnu.org" <60732@debbugs.gnu.org>
Cc: "andreas@enge.fr" <andreas@enge.fr>
Subject: [bug#60732] Patch update
Date: Tue, 21 Feb 2023 17:44:15 +0000 [thread overview]
Message-ID: <ZR0P278MB02684E55FE46B54711C406A3C1A59@ZR0P278MB0268.CHEP278.PROD.OUTLOOK.COM> (raw)
In-Reply-To: <20230111163659.wudbizhylifjt3nj@blackbox>
[-- Attachment #1.1: Type: text/plain, Size: 992 bytes --]
Hi
Thank you, Andreas, for your review.
When #:tests? #t the following output is generated (and the build fails)
> running test
> WARNING: Testing via this command is deprecated and will be removed in a future version. Users looking for a generic test entry point independent of test runner are encouraged to use tox.
I am not sure how to achieve this using our package management system and am not sure if it would be of great gain to do so.
According to the documentation [1] ipython, matplotlib, etc are optional dependencies. I wouldn't include them per se since one can easily invoke a Guix shell providing these.
To test one can invoke a guix shell --pure python-scapy python-ipython and run scapy manually.
I have adjusted the patch, thank you for your time and effort in advance!
Please let me know if i can improve it some more!
g
1: https://scapy.readthedocs.io/en/latest/installation.html#optional-dependencies
2: https://scapy.net/
[-- Attachment #1.2: Type: text/html, Size: 5196 bytes --]
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-gnu-Add-python-scapy.patch --]
[-- Type: text/x-patch; name="0001-gnu-Add-python-scapy.patch", Size: 2013 bytes --]
From 0575e799328f93f6c4c5afe893ae10e6e7a9ee28 Mon Sep 17 00:00:00 2001
From: Gabriel Wicki <gabriel@erlikon.ch>
Date: Mon, 9 Jan 2023 16:06:20 +0100
Subject: [PATCH] gnu: Add python-scapy.
* gnu/packages/python-xyz.scm (python-scapy): New variable.
---
gnu/packages/python-xyz.scm | 25 +++++++++++++++++++++++++
1 file changed, 25 insertions(+)
diff --git a/gnu/packages/python-xyz.scm b/gnu/packages/python-xyz.scm
index 32d826d3c5..d9bee20eb8 100644
--- a/gnu/packages/python-xyz.scm
+++ b/gnu/packages/python-xyz.scm
@@ -132,6 +132,7 @@
;;; Copyright © 2022 Garek Dyszel <garekdyszel@disroot.org>
;;; Copyright © 2022 Baptiste Strazzulla <bstrazzull@hotmail.fr>
;;; Copyright © 2022 Nicolas Graves <ngraves@ngraves.fr>
+;;; Copyright © 2023 Gabriel Wicki <gabriel@erlikon.ch>
;;;
;;; This file is part of GNU Guix.
;;;
@@ -1462,6 +1463,30 @@ (define-public python-psutil
iotop, uptime, pidof, tty, taskset, pmap.")
(license license:bsd-3)))
+(define-public python-scapy
+ (package
+ (name "python-scapy")
+ (version "2.5.0")
+ (source (origin
+ (method url-fetch)
+ (uri (pypi-uri "scapy" version))
+ (sha256
+ (base32
+ "1hpbbmpcn4dwj3z7i7sz4cnbpkaf57p7mvl3p84x9n2gflmhq9jv"))))
+ (arguments
+ '(#:tests? #f)) ;The recommendation is to use tox for testing.
+ (build-system python-build-system)
+ (home-page "https://scapy.net")
+ (synopsis "Python network packet crafting library")
+ (description
+ "Scapy is a Python library and executable for interactively
+manipulating network packets. It can forge or decode packets of a number
+of protocols, send them on the wire, capture them, store or read them
+using pcap files, match requests and replies, and so on.
+It can handle tasks such as scanning, tracerouting, probing, unit tests,
+attacks or network discovery.")
+ (license license:gpl2)))
+
(define-public python-shapely
(package
(name "python-shapely")
--
2.39.1
next prev parent reply other threads:[~2023-02-21 17:45 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-11 16:36 [bug#60732] New package: python-scapy Gabriel Wicki
2023-02-20 21:21 ` [bug#60732] Review Andreas Enge
2023-02-21 17:44 ` Wicki Gabriel (wicg) [this message]
2023-02-28 13:50 ` [bug#60732] Patch update Wicki Gabriel (wicg)
2023-03-11 22:24 ` bug#60732: Close patch Andreas Enge
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZR0P278MB02684E55FE46B54711C406A3C1A59@ZR0P278MB0268.CHEP278.PROD.OUTLOOK.COM \
--to=wicg@zhaw.ch \
--cc=60732@debbugs.gnu.org \
--cc=andreas@enge.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).