From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp10.migadu.com ([2001:41d0:403:4789::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms9.migadu.com with LMTPS id EEHzOIFh92TJoAAAG6o9tA:P1 (envelope-from ) for ; Tue, 05 Sep 2023 19:12:34 +0200 Received: from aspmx1.migadu.com ([2001:41d0:403:4789::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp10.migadu.com with LMTPS id EEHzOIFh92TJoAAAG6o9tA (envelope-from ) for ; Tue, 05 Sep 2023 19:12:34 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id D079766EC0 for ; Tue, 5 Sep 2023 19:12:32 +0200 (CEST) Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=aruba.it header.s=a1 header.b=Z0Uhe6ct; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1693933953; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=/0J8/z/L4bJRtD0pgcEMgnYLEt1oVn1/3o2eOiIN2bU=; b=XTcRkgU6rKFYVa1T5FGflXg4MjMifAAMrpWVWIgTUUCv47u6fa3eUVYEplFKX0n7qo9sDD D6oXKflgtxej1N61sdPbUBAtzHp9eHIfG8axey/tkMyfzQwDc2Yianj+kRMtHf2/jiOs/E VXJpdmGfwMm/idmxQxqiIno5CmJkbYjLFKDQ4XwP7xo2iEXdHx9/XxR42k4/3bIy2dFmoQ Sa7dx33BQJfo4qsPNuj6I2S3yzbElfZyol03R1J9I92TEcROTejQkUIVnZs3vMI8eH2scn LcjwVSUc9udhnb+MReLqvElRHRc7bu9s9/Cq7ADWBPpmze++b6dEn35+miRxDA== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=aruba.it header.s=a1 header.b=Z0Uhe6ct; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=none ARC-Seal: i=1; s=key1; d=yhetil.org; t=1693933953; a=rsa-sha256; cv=none; b=IsDo4I9atnTd5IRg+8Cb9+CDGFPgXOVKbm9eBWkxt0HF2pHl3CPHIj26eOwBKKP97rH0g+ osNyQNM2VxK7RJpBrraDAhY3dameWXQrXTvFwvQvMc5OIc8yL407N92rqYpqidOwNJtU51 C4ELd7Ouib3EA/7JX7JB3JsF4BRFw+M9ukPbcU+nsZI4Wxis+A7/qdttad4l9GBAMyxgkM oJ6DKaboAqGeDLRqi2CiVyMWV1de7dwXj72d2u2rrCfaL5oBPZxZGV5ava8gxOImBAQYpa P5oR0i9e7DVc2CId6IJqHdKj2/m19FfsTQenDwQeuFEau/cNZjrlYeBlkiA26w== Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qdZau-0005Ca-Ad; Tue, 05 Sep 2023 13:12:04 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qdZar-0005CA-PC for guix-patches@gnu.org; Tue, 05 Sep 2023 13:12:01 -0400 Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qdZar-0007vU-HA for guix-patches@gnu.org; Tue, 05 Sep 2023 13:12:01 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qdZas-0003yj-2k for guix-patches@gnu.org; Tue, 05 Sep 2023 13:12:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#65097] [PATCH] gnu: Add tk-img. Resent-From: cage Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Tue, 05 Sep 2023 17:12:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 65097 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Maxim Cournoyer Cc: 65097@debbugs.gnu.org, cage Received: via spool by 65097-submit@debbugs.gnu.org id=B65097.169393388815235 (code B ref 65097); Tue, 05 Sep 2023 17:12:02 +0000 Received: (at 65097) by debbugs.gnu.org; 5 Sep 2023 17:11:28 +0000 Received: from localhost ([127.0.0.1]:58808 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qdZaK-0003xf-7A for submit@debbugs.gnu.org; Tue, 05 Sep 2023 13:11:28 -0400 Received: from smtpcmd02101.aruba.it ([62.149.158.101]:38785) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qdZaH-0003xP-25 for 65097@debbugs.gnu.org; Tue, 05 Sep 2023 13:11:26 -0400 Received: from shimizu.casa.net ([84.220.229.183]) by Aruba Outgoing Smtp with ESMTPSA id dZa8q2jsDxg8EdZa8qxXX9; Tue, 05 Sep 2023 19:11:16 +0200 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=aruba.it; s=a1; t=1693933876; bh=vpeNlCB1uVMDUpk6URIJfEwVDXkribr23Pf0r7PMlI0=; h=Date:From:To:Subject:MIME-Version:Content-Type; b=Z0Uhe6ctrqRq5Jk8lr4lOuJHCLgBS6IOzFYlDFv6z/WVMk7ALV6q9dEdYfGMsxn9W 9CvtNQFJdbrxGIX4u8fJ6hhDUz9IZ5qEDS0NB2/P3KNVTjbyO/JeiyuhuMdGEQTqiZ Clzwl/HKgnOfLimmpSYEzWMcMFrP93JIo7rjLx7ENunBZy8TVHlZY0GtwhV5LqeLgt TgxCideh/D6y9D1GmbSFujGbF0Eg/n82y6izErvex+NQEoyzAAsEY3FVtZy9g5TgGy 1Pe97gfXXvFISPCigjwdLR7HIGhcPwFwTNrwJOcs8JwklHfEa1/Hdy0EfoqCqjiKhn ZqakX7Q2H3s3A== Received: by shimizu.casa.net (Postfix, from userid 1000) id 56207DA053A; Tue, 5 Sep 2023 19:11:05 +0200 (CEST) Date: Tue, 5 Sep 2023 19:11:05 +0200 From: cage Message-ID: References: <637de43ce6edf9cebaf84d3b456901a184e6de82.1691242776.git.cage-dev@twistfold.it> <87msy0k8ex.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <87msy0k8ex.fsf@gmail.com> X-CMAE-Envelope: MS4xfBNpp9GTRXCTkjxO0nhyMDnQcb5O4UuIUIHN/kjSSktaOcnreknCyVhVxhcre5h/fTwqYeY1KMWoZDrFPBO4t80vKjaYOmrSz5aC/41BFb0NyRae6bwH OpkRxiNSru+I22pCd/h3Cf4cxTeQuvbiJJD7jIjGK5ZPaca4J7/FZEEjnEY1SPkOM/gyL4Cc71khlKrQg8A6W6RJlGeZCmlu8JffKVm/HIbr1IGluG9I/KGD MnvuAfKSf4Dy1GjTyyT2czovxojYMpKeh0qVAkbcgGo= X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US X-Migadu-Queue-Id: D079766EC0 X-Migadu-Scanner: mx1.migadu.com X-Migadu-Spam-Score: -2.23 X-Spam-Score: -2.23 X-TUID: wezXZ7hpo2Us On Tue, Sep 05, 2023 at 10:21:26AM -0400, you wrote: > Hi! Hi! […] Thank you very much for your accurate review of this patch! I am going to address the issues you highlighted in your messages and updating the patch. I have just a question: > > the package will skips the test (it complains "tk" can not be found"); > It'd be best to say so in the package, with a XXX comment (meaning > subpar/hackish/dirty) like: > > #:tests #f ;tests fails with "tk" can not be found error I am OK with this change but I would rather prefer to not skip the tests, if possible; do you have any suggestions about making the build environment find the tk executable? Thanks again for your help! C.