unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: "André Batista" <nandre@riseup.net>
To: Michael Ford <fanquake@gmail.com>
Cc: 65489@debbugs.gnu.org
Subject: [bug#65489] [PATCH] gnu: tor: Update to 0.4.8.4.
Date: Fri, 1 Sep 2023 11:46:12 -0300	[thread overview]
Message-ID: <ZPH5NDRWdb6lAoba@andel> (raw)
In-Reply-To: <CAFyhPjU3w3dpLB+Xxg02Bhz+hdfUruQvuBk5yK9AioZHTSS4gA@mail.gmail.com>

Hi Michael,

sex 01 set 2023 às 10:31:43 (1693575103), fanquake@gmail.com enviou:
[...]
> diff --git a/gnu/packages/tor.scm b/gnu/packages/tor.scm
> index 7fec88656f..44e62b63cc 100644
> --- a/gnu/packages/tor.scm
> +++ b/gnu/packages/tor.scm
> @@ -63,18 +63,20 @@ (define-module (gnu packages tor)
>  (define-public tor
>    (package
>      (name "tor")
> -    (version "0.4.7.14")
> +    (version "0.4.8.5")
>      (source (origin
>               (method url-fetch)
>               (uri (string-append "https://dist.torproject.org/tor-"
>                                   version ".tar.gz"))
>               (sha256
>                (base32
> -               "1y2xwrji1rvk6h0k15705yra5s74h72h2g84x02zr0338vv6gb55"))))
> +               "06g1awb4piqvgxa97pyswxgjzkpj8rx3iy2jbiaygvi99b8wymv9"))
> +             (patches (search-patches
> "tor-remove-defensive-assert.patch"))))
>      (build-system gnu-build-system)
>      (arguments
>       (list #:configure-flags
> -           #~(list "--enable-lzma"
> +           #~(list "--enable-gpl"
> +                   "--enable-lzma"
>                     "--enable-zstd")
>             #:phases
>             #~(modify-phases %standard-phases

I'm sorry but I forgot to mention you should probably also update the
license field in order to refer to the license option. It seems to me
that the configure flag is a bit misleading, since the license is
LGPLv3[1][2], not GPL.

Other than that, it looks good to me, thank you! I do not have commit
rights, so let's wait for a Guix Maintainer to pick it up.

Cheers!

1 - https://gitlab.torproject.org/tpo/core/tor/-/blob/release-0.4.8/Makefile.am?ref_type=heads#L117
2 - https://gitlab.torproject.org/tpo/core/tor/-/blob/release-0.4.8/src/ext/equix/LICENSE?ref_type=heads




  reply	other threads:[~2023-09-01 14:47 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-08-24  8:58 [bug#65489] [PATCH] gnu: tor: Update to 0.4.8.4 Michael Ford
2023-08-31  0:10 ` André Batista
2023-09-01  7:31   ` Michael Ford
2023-09-01 14:46     ` André Batista [this message]
2023-09-14 14:43       ` Ludovic Courtès
2023-09-14 14:45     ` bug#65489: " Ludovic Courtès

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZPH5NDRWdb6lAoba@andel \
    --to=nandre@riseup.net \
    --cc=65489@debbugs.gnu.org \
    --cc=fanquake@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).